[openstreetmap/openstreetmap-website] Slow response in rendering phase while calling /map endpoint (Issue #6057)
mahmoudhanafy created an issue (openstreetmap/openstreetmap-website#6057) Hi Team, Thanks for the great work you are doing. I'm completely new to ruby and to this project. I'm currently running a local version of osm-website, and I'm calling this endpoint: ``` https://myLocalWebsite/api/0.6/map
Re: [openstreetmap/openstreetmap-website] note comments from a deleted user should still be shown (Issue #6056)
tomhughes left a comment (openstreetmap/openstreetmap-website#6056) Also there's the fact that at least sometimes the user will have been deleted precisely because we want to stop their comments showing up! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/o
Re: [openstreetmap/openstreetmap-website] note comments from a deleted user should still be shown (Issue #6056)
tomhughes left a comment (openstreetmap/openstreetmap-website#6056) As explained many times in different threads this needs a decision on what we are legally allowed to do with regard to deleted users - technically none of this is hard but we need to know what GDPR etc requires of us. -- Reply
[openstreetmap/openstreetmap-website] note comments from a deleted user should still be shown (Issue #6056)
andrewharvey created an issue (openstreetmap/openstreetmap-website#6056) ### URL https://www.openstreetmap.org/note/4620093 ### How to reproduce the issue? 1. User A creates a note 2. User B resolves the note and/or adds a comment 3. User A re-opens the note and/or adds a comment 4. User B dele
[openstreetmap/openstreetmap-website] Bump @stylistic/eslint-plugin-js from 4.2.0 to 4.4.0 (PR #6055)
Bumps [@stylistic/eslint-plugin-js](https://github.com/eslint-stylistic/eslint-stylistic/tree/HEAD/packages/eslint-plugin-js) from 4.2.0 to 4.4.0.Release notes
Sourced from
@stylis
Re: [openstreetmap/openstreetmap-website] New 'social media links' are not included in the API when querying a user (Issue #6054)
pietervdvn left a comment (openstreetmap/openstreetmap-website#6054) > it too easy for people to scrape up the social links A scraper can just as well scrape the HTML from the profile directly -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-w
Re: [openstreetmap/openstreetmap-website] How to remove English text from my profile? (Issue #6048)
hlfan left a comment (openstreetmap/openstreetmap-website#6048) At least now that the heatmap is tied to Turbo compatibility, which is the first thing that breaks in firefox (see #), so the heading also doesn't render in these cases. -- Reply to this email directly or view it on GitHub: ht
Re: [openstreetmap/openstreetmap-website] How to remove English text from my profile? (Issue #6048)
tomhughes left a comment (openstreetmap/openstreetmap-website#6048) We've had other tickets like # where we suspect @maro-21 is using a very old browser or something but I don't think they're ever clarified what they're using... Maybe the missing heatmap is down to something in the CSS not w
Re: [openstreetmap/openstreetmap-website] How to remove English text from my profile? (Issue #6048)
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#6048) > Should be resolved with > https://github.com/openstreetmap/openstreetmap-website/commit/dfbf072b887a5cc63860ae21e82c2f5fe85ec5c4 Yeah. Now he gets localized text he can not edit... -- Reply to this email directly or vie
Re: [openstreetmap/openstreetmap-website] New 'social media links' are not included in the API when querying a user (Issue #6054)
tomhughes left a comment (openstreetmap/openstreetmap-website#6054) Sure but we were unaware of that bit of "creative" use of user descriptions before... I mean maybe this specific case is OK but I worry about making it too easy for people to scrape up the social links to use for nefarious purpo
Re: [openstreetmap/openstreetmap-website] New 'social media links' are not included in the API when querying a user (Issue #6054)
mmd-osm left a comment (openstreetmap/openstreetmap-website#6054) I think this was already in place for quite some time, and looks like this example: https://en.osm.town/@mapcomplete_edits/114543361361396417 In case people maintained a link to their mastodon account on their osm profile, they w
Re: [openstreetmap/openstreetmap-website] New 'social media links' are not included in the API when querying a user (Issue #6054)
tomhughes left a comment (openstreetmap/openstreetmap-website#6054) My question is whether users are going to be happy with us enabling that behaviour... I certainly wouldn't want to start getting random "pings" on my social media accounts because of some edit I made. -- Reply to this email di
Re: [openstreetmap/openstreetmap-website] New 'social media links' are not included in the API when querying a user (Issue #6054)
pietervdvn left a comment (openstreetmap/openstreetmap-website#6054) The bot downloads the changesets made with mapcomplete, then checks the user profile of the person who made it. If a mastodon link is found, it'll ping the mastodon user instead of using the osm user name. But that 'detecting
Re: [openstreetmap/openstreetmap-website] Inline SVGs with helper module (PR #5938)
@hlfan pushed 1 commit. 08895a33a25a8cc10160b73d58e350dbd37072e9 Move social link icons to partials -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5938/files/13c45a4f23efdd46bb69aa7506d8348248acfb6a..08895a33a25a8cc10160b73d58e350dbd37072e9 You are receiving t
Re: [openstreetmap/openstreetmap-website] New 'social media links' are not included in the API when querying a user (Issue #6054)
tomhughes left a comment (openstreetmap/openstreetmap-website#6054) I'm not sure why you'd expect the API to include them - what's the use case for that? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6054#issuecomment-2910410
Re: [openstreetmap/openstreetmap-website] Inline SVGs with helper module (PR #5938)
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#5938) 1 Warning :warning: Number of updated lines of code is too large to be in one PR. Perhaps it should be separated into two or more? Gener
[openstreetmap/openstreetmap-website] Drop selenium monkey patch in favour of upstream fix (PR #6053)
Upstream now has a workaround in place, first attempted in https://github.com/SeleniumHQ/selenium/issues/15707 and then fixed by me in https://github.com/SeleniumHQ/selenium/pull/15458. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetm
Re: [openstreetmap/openstreetmap-website] New 'social media links' are not included in the API when querying a user (Issue #6054)
mmd-osm left a comment (openstreetmap/openstreetmap-website#6054) Ok, please ignore my previous comment. Your bot was relying on the fact that users put in a social media link in their profile description text, which you were able to obtain from the description. With the recent changes, users w
Re: [openstreetmap/openstreetmap-website] New 'social media links' are not included in the API when querying a user (Issue #6054)
mmd-osm left a comment (openstreetmap/openstreetmap-website#6054) I'd say, Mastodon links look almost the same as before: Old: ``` [Edit your OSM profile], make it include My fediverse acount ``` New: ``` https://en.osm.town/@username";> ``` So there's still the "ref="...me" in place. The que
Re: [openstreetmap/openstreetmap-website] Inline SVGs with helper module (PR #5938)
@hlfan pushed 2 commits. 9c274b9caeca37c9c6e2ab282ee12f87e3994b5a Prepare social link icons 13c45a4f23efdd46bb69aa7506d8348248acfb6a Move social link icons to partials -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5938/files/499c45105ee32f7635c51025b40b9fa43
[openstreetmap/openstreetmap-website] New 'social media links' are not included in the API when querying a user (Issue #6054)
pietervdvn created an issue (openstreetmap/openstreetmap-website#6054) ### URL https://www.openstreetmap.org/api/0.6/user/3818858.json ### How to reproduce the issue? Hi, I did set mastodon in the social links (which are a nice addition). However, my mastodon bot (https://en.osm.town/@mapcompl
Re: [openstreetmap/openstreetmap-website] Fix UserLocationChangeTest (Issue #6022)
hlfan left a comment (openstreetmap/openstreetmap-website#6022) Ok but what else is to blame if the heatmap doesn't slow down the user show action and the test [still fails](https://github.com/hlfan/openstreetmap-website/actions/runs/15258197126/job/42910679709)? -- Reply to this email directl
Re: [openstreetmap/openstreetmap-website] Use same logic for feature names (PR #6037)
@hlfan pushed 1 commit. 507579af021b0ba28901833a8d9b83c1fa044365 Use same logic for feature names -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6037/files/bfce1118549636e08d88d8a698c4d5885ea86916..507579af021b0ba28901833a8d9b83c1fa044365 You are receiving thi
Re: [openstreetmap/openstreetmap-website] Use same logic for feature names (PR #6037)
@AntonKhorev commented on this pull request. > +preferred_languages.expand.each do |locale| + key = "name:#{locale}" + return tags[key] if tags[key] + + key = "name:#{locale.to_s.split('-').first}" + return tags[key] if tags[key] +end `expand` adds candidate language
Re: [openstreetmap/openstreetmap-website] Inline SVGs with helper module (PR #5938)
@hlfan pushed 1 commit. 499c45105ee32f7635c51025b40b9fa43f6d0e21 Move social link icons to partials -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5938/files/f637c55ef2236613ef57c304e01dcced9703c413..499c45105ee32f7635c51025b40b9fa43f6d0e21 You are receiving t
Re: [openstreetmap/openstreetmap-website] Can we avoid inlining svgs into erb templates? (Issue #5880)
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5880) > **@AntonKhorev** seems to have quite a preference for mixing multiple > languages and concerns within a single file. Take a look at this > https://github.com/openstreetmap/openstreetmap-website/pull/5352#issuecomment-249593
Re: [openstreetmap/openstreetmap-website] Inline SVGs with helper module (PR #5938)
@hlfan pushed 6 commits. b55e635720ffe9f0eee23ab6a751b2358b1d43b0 Make Rails handle SVG partials efa8b86c1c1fd573244a72f94f2c9a38436f8b54 Move search icons to partials ff114c559795c3da316e998acfa87123a2e128ab Move about icons to partials b1f8ffea90cddb527dfa06f3bcd23c329e167174 Move welcome ic
Re: [openstreetmap/openstreetmap-website] Add dir=auto to user generated content (PR #3429)
@AntonKhorev commented on this pull request. > @@ -1,6 +1,7 @@ class TracesController < ApplicationController include UserMethods include PaginationMethods + include ActionView::Helpers::TagHelper Is this include still needed after the fix https://github.com/openstreetmap/openstreetmap
Re: [openstreetmap/openstreetmap-website] How to remove English text from my profile? (Issue #6048)
hlfan left a comment (openstreetmap/openstreetmap-website#6048) Should be resolved with dfbf072b887a5cc63860ae21e82c2f5fe85ec5c4 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6048#issuecomment-2909681349 You are receiving this
Re: [openstreetmap/openstreetmap-website] TranslateWiki doesn't sync changes (Issue #6036)
hlfan left a comment (openstreetmap/openstreetmap-website#6036) Should be resolved with dfbf072b887a5cc63860ae21e82c2f5fe85ec5c4 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6036#issuecomment-2909682112 You are receiving this
Re: [openstreetmap/openstreetmap-website] Localisation updates from https://translatewiki.net. (dfbf072)
FINALLY! 🎉 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/commit/dfbf072b887a5cc63860ae21e82c2f5fe85ec5c4#commitcomment-158026657 You are receiving this because you are subscribed to this thread. Message ID: _
Re: [openstreetmap/openstreetmap-website] Remove legacy OpenID login (PR #6038)
tomhughes left a comment (openstreetmap/openstreetmap-website#6038) Thanks. I think this looks good now. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6038#issuecomment-2909418636 You are receiving this because you are subscribe
Re: [openstreetmap/openstreetmap-website] Removing legacy OpenID login option (Issue #6020)
Closed #6020 as completed via #6038. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6020#event-17813044594 You are receiving this because you are subscribed to this thread. Message ID: _
Re: [openstreetmap/openstreetmap-website] Remove legacy OpenID login (PR #6038)
Merged #6038 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6038#event-17813044376 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Remove legacy OpenID login (PR #6038)
tomhughes left a comment (openstreetmap/openstreetmap-website#6038) No that can stay - that allows seamless migration from Google's old Open ID based login to the new OAuth 2 based one. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/
Re: [openstreetmap/openstreetmap-website] Remove legacy OpenID login (PR #6038)
mmd-osm left a comment (openstreetmap/openstreetmap-website#6038) I also haven't addressed this bit yet: https://github.com/openstreetmap/openstreetmap-website/blob/dcd886e3e37af9b5f0003aec0563eef5a7b02c1e/app/controllers/users_controller.rb#L142-L146 Should we remove it? It seems to be some sor
