AntonKhorev left a comment (openstreetmap/openstreetmap-website#6052)
The answer is going to be something like
https://github.com/openstreetmap/openstreetmap-website/pull/5964#discussion_r2068774443.
For example, `#menu-icon` is not going to exist once it's replaced by the
[Bootstrap navbar](ht
Instead of adding a rule for each invertible icon/image, bundle these together
into a utility class.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6052
-- Commit Summary --
* Invert icons in dark mode with common
matkoniecz left a comment (openstreetmap/openstreetmap-website#6041)
> The ###social_links rule is also used in other filter lists
feel free to file issues there
this is in fact social link, and if ablocker tries to remove social links then
users should not be surprised when in fact removes so
@mmd-osm pushed 1 commit.
706d167f08d9a5e6eaa55f024e346146e6bfb1f5 Remove legacy OpenID login
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6038/files/a52b33ba96918d3523c9c6e91c1cf218b50e9e25..706d167f08d9a5e6eaa55f024e346146e6bfb1f5
You are receiving this be
@mmd-osm commented on this pull request.
> @@ -24,9 +24,8 @@
:include_blank => t("auth.providers.none"),
:hide_label => true,
:wrapper => { :class => "col-auto mb-0" } %>
- <%= f.text_field(:auth_uid, :hide_label => true, :wrapper
tomhughes left a comment (openstreetmap/openstreetmap-website#6041)
But if we're not careful we get accused of trying to evade ublock and they add
even more rules to target us.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/60
deevroman left a comment (openstreetmap/openstreetmap-website#6041)
IMHO, the fix (which consists in renaming the element id) is more reliable to
do on the OSM side
The `###social_links` rule is also used in other filter lists
https://github.com/search?q=%23%23%23social_links&ref=opensearch&typ
@tomhughes commented on this pull request.
> @@ -24,9 +24,8 @@
:include_blank => t("auth.providers.none"),
:hide_label => true,
:wrapper => { :class => "col-auto mb-0" } %>
- <%= f.text_field(:auth_uid, :hide_label => true, :wrappe
@tomhughes commented on this pull request.
><% end -%>
<% end %>
-
- <%# :tabindex starts high to allow rendering at the bottom of the template %>
- <%= form_tag auth_path(:provider => "openid"), :id => "openid_login_form",
:class => "collapse" do %>
-
-
-<%
@tomhughes commented on this pull request.
>$("input#user_avatar").on("change", function () {
$("#user_avatar_action_new").prop("checked", true);
});
- function enableAuth() {
-$("#auth_prompt").hide();
-$("#auth_field").show();
-$("#user_auth_uid").prop("disabled", fa
@tomhughes commented on this pull request.
> @@ -33,7 +34,7 @@ def index
elsif current_user && current_user == target_user
t ".my_gps_traces"
else
- t ".public_traces_from", :user => target_user.display_name
+ t ".public_tra
@tomhughes pushed 2 commits.
736f7141aa8b7ae428843ff7288abe0aaf352add Add dir=auto to user generated content
deb0ed84c4fe5435d72043a18757ed599034831b Add dir=auto to usernames
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3429/files/85759a3250397b2570100ba9b
@mmd-osm commented on this pull request.
>$("input#user_avatar").on("change", function () {
$("#user_avatar_action_new").prop("checked", true);
});
- function enableAuth() {
-$("#auth_prompt").hide();
-$("#auth_field").show();
-$("#user_auth_uid").prop("disabled", fals
@mmd-osm commented on this pull request.
><% end -%>
<% end %>
-
- <%# :tabindex starts high to allow rendering at the bottom of the template %>
- <%= form_tag auth_path(:provider => "openid"), :id => "openid_login_form",
:class => "collapse" do %>
-
-
-<%=
mmd-osm left a comment (openstreetmap/openstreetmap-website#6038)
Regarding the `preferred_auth_provider`, I was looking for the exact URL to
trigger the different layout. It seems I need to include this parameter along
with the respective auth provider in the referer parameter:
* http://localh
Closed #6041 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6041#event-17804600571
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
matkoniecz left a comment (openstreetmap/openstreetmap-website#6041)
1) maybe Social Widgets add-on filter should be expected to block these?
2) I opened https://github.com/easylist/easylist/issues/21852 - I think that it
covers the issue and this can be closed
--
Reply to this email directly
tomhughes left a comment (openstreetmap/openstreetmap-website#6051)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6051#issuecomment-2907853252
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#6038)
If there's no referer then the we should just be leaving out the parameter -
that may well be a bug that was introduced recently while refactoring how
parameters are handled to use `URLSearchParams`.
Setting `preferred_auth_pro
Merged #6051 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6051#event-17804510018
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
deevroman left a comment (openstreetmap/openstreetmap-website#6041)
Meanwhile, there is a second victim
https://c.osm.org/t/add-social-link-isnt-working/130446/4
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6041#issuecomme
21 matches
Mail list logo
