[openstreetmap/openstreetmap-website] Social media icons are not visible in the dark theme of the site (Issue #6043)

2025-05-22 Thread Roman Deev via rails-dev
deevroman created an issue (openstreetmap/openstreetmap-website#6043) ### URL https://www.openstreetmap.org/user/TrickyFoxy ### How to reproduce the issue? https://github.com/user-attachments/assets/89275aad-c906-47ef-8d9f-17958c86f00c"; /> ### Screenshot(s) or anything else? _No response_

[openstreetmap/openstreetmap-website] Focus first endpoint when routing is activated (PR #6042)

2025-05-22 Thread Tom Hughes via rails-dev
When routing is activated we are presumably about to look for a route, and anything already in the search box will have been transferred to the route end field, so focus on the route start field ready to accept input. You can view, comment on, or merge this pull request online at: https://gith

Re: [openstreetmap/openstreetmap-website] Setting for adding social media links conflicts with EasyList – Social Widgets (Issue #6041)

2025-05-22 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6041) We can't really be expected to avoid every class and/or id that some random extension might have decided to block... -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/i

[openstreetmap/openstreetmap-website] Setting for adding social media links conflicts with EasyList – Social Widgets (Issue #6041)

2025-05-22 Thread Roman Deev via rails-dev
deevroman created an issue (openstreetmap/openstreetmap-website#6041) I use uBlock Origin with the EasyList – Social Widgets add-on filter, which makes the settings item invisible: https://github.com/user-attachments/assets/f8603551-263c-4855-b8aa-8cf5fb2afd8a"; /> The filter contains a rule `

[openstreetmap/openstreetmap-website] Focus on newly added social link fields (PR #6040)

2025-05-22 Thread Tom Hughes via rails-dev
When a new social link is added presumably the user is about to fill it in, so focus on it. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6040 -- Commit Summary -- * Focus on newly added social link fields -- Fil

Re: [openstreetmap/openstreetmap-website] Add recent diaries section to user profile (Issue #6009)

2025-05-22 Thread Tom Hughes via rails-dev
Closed #6009 as completed via #6010. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6009#event-1147895 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

2025-05-22 Thread Tom Hughes via rails-dev
@tomhughes pushed 1 commit. 86dd9bfd6beb490a7680fcbee923fcfa0a52639b Add social profile links -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/c410c5704ac3e3649f3e64293b6628e8becee5b8..86dd9bfd6beb490a7680fcbee923fcfa0a52639b You are receiving this be

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

2025-05-22 Thread Tom Hughes via rails-dev
@tomhughes approved this pull request. I pushed a small change to remove `config/i18-js.yml` which had crept back in here during a rebase and to cleanup trailing whitespace in a few files and with that I think this is good to merge - thanks for working on it. -- Reply to this email directly

[openstreetmap/openstreetmap-website] Drop skype from social links (PR #6039)

2025-05-22 Thread Tom Hughes via rails-dev
Drop skype from social links for it has ceased to be and is an ex-social network. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6039 -- Commit Summary -- * Skype is no more -- File Changes -- D app/assets/im

Re: [openstreetmap/openstreetmap-website] Remove routing submit button (PR #5960)

2025-05-22 Thread Tom Hughes via rails-dev
Merged #5960 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5960#event-1147662 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

2025-05-22 Thread Tom Hughes via rails-dev
Merged #5439 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5439#event-1543339 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Add latest diaries partial to profile page (PR #6010)

2025-05-22 Thread Tom Hughes via rails-dev
Merged #6010 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6010#event-1147617 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] When is it used this "not_public_flash" ? (Issue #6035)

2025-05-22 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#6035) Okay, I see what you mean. Obviously this particular feature will only be relevant to a very small group, if at all. You can be assured that we re-evaluate features from time to time and remove them when they are no longer releva

Re: [openstreetmap/openstreetmap-website] When is it used this "not_public_flash" ? (Issue #6035)

2025-05-22 Thread Andres Gomez Casanova via rails-dev
angoca left a comment (openstreetmap/openstreetmap-website#6035) Thank you for your answer. By reading again the wiki page, I see that this only applies to a tiny population of OSM users: "This only affects a tiny minority of people who joined OSM before 2007 and have not edited OSM since 2009"

Re: [openstreetmap/openstreetmap-website] Remove routing submit button (PR #5960)

2025-05-22 Thread Tom Hughes via rails-dev
@tomhughes approved this pull request. I think this looks good now, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5960#pullrequestreview-2862075425 You are receiving this because you are subscribed to this thread. Mes

Re: [openstreetmap/openstreetmap-website] Remove legacy OpenID login (PR #6038)

2025-05-22 Thread mmd via rails-dev
@mmd-osm pushed 1 commit. d9c9ea5f1cfa553da2bbc8586a1e83ae60271183 Remove legacy OpenID login -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6038/files/42f4bfc9e341d20275c6a096167acb9cc39a2f49..d9c9ea5f1cfa553da2bbc8586a1e83ae60271183 You are receiving this be

Re: [openstreetmap/openstreetmap-website] Add latest diaries partial to profile page (PR #6010)

2025-05-22 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6010) I'm slightly worried that stripping all the HTML tags from the body text might be problematic but we'll probably only find out if people start seeing cases where it causes problems so I think this is probably good to merge - tha

Re: [openstreetmap/openstreetmap-website] When is it used this "not_public_flash" ? (Issue #6035)

2025-05-22 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#6035) Not sure what exactly your point is, `not_public_flash` is still in use: https://github.com/openstreetmap/openstreetmap-website/blob/1b63e9e16dff92df226aed707058b7228527bc6e/app/controllers/site_controller.rb#L100 -- Reply to thi

Re: [openstreetmap/openstreetmap-website] When is it used this "not_public_flash" ? (Issue #6035)

2025-05-22 Thread Andres Gomez Casanova via rails-dev
angoca left a comment (openstreetmap/openstreetmap-website#6035) Ok, thank you for your prompt answer. One last question: Does this mean the website no longer has usable features? They should be removed to ease the translations. What is the purpose of having all these strings (in translatewiki)

Re: [openstreetmap/openstreetmap-website] TranslateWiki doesn't sync changes (Issue #6036)

2025-05-22 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#6036) @Nikerabbit : thanks a lot for the super quick fix, much appreciated! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6036#issuecomment-2901964263 You are receivi

Re: [openstreetmap/openstreetmap-website] TranslateWiki doesn't sync changes (Issue #6036)

2025-05-22 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#6036) Maybe @Nikerabbit could help here from TranslateWiki side? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6036#issuecomment-2901866257 You are receiving this bec

Re: [openstreetmap/openstreetmap-website] HTTP 500 error on user profile pages (Issue #6023)

2025-05-22 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#6023) Let's close this one, the issue has been fixed in the meantime. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6023#issuecomment-2901870479 You are receiving thi

Re: [openstreetmap/openstreetmap-website] TranslateWiki doesn't sync changes (Issue #6036)

2025-05-22 Thread Niklas Laxström via rails-dev
Nikerabbit left a comment (openstreetmap/openstreetmap-website#6036) Thanks for bringing this to our attention. One of the recent message renames had failed halfway and our system as safety measure disables all syncing if that happens. I fixed the rename manually and syncing should work again.

Re: [openstreetmap/openstreetmap-website] Please add NATO coordinates, Here is why. (Issue #5984)

2025-05-22 Thread LeeWellsUU via rails-dev
LeeWellsUU left a comment (openstreetmap/openstreetmap-website#5984) Right that's exactly why you only use ENGLISH for all your maps right? 38°10'00.1"N 85°47'23.8"W and 16SFH0800025000 is exactly the same place. you just didn't know that or you choose to call it 'value added' information. Get r

Re: [openstreetmap/openstreetmap-website] Please add NATO coordinates, Here is why. (Issue #5984)

2025-05-22 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5984) Right but www.openstreetmap.org has a design goal of supporting mappers and it is specifically out of scope to support end users - we leave that to downstream consumers of our data. -- Reply to this email directly or view it o

Re: [openstreetmap/openstreetmap-website] Use same logic for feature names (PR #6037)

2025-05-22 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > - return tags["addr:housenumber"] + " " + tags["addr:street"]; + return OSM.i18n.t( +"javascripts.query.address", +{ housenumber: tags["addr:housenumber"], street: tags["addr:street"] } + ); Should an addres at an arb

Re: [openstreetmap/openstreetmap-website] Please add NATO coordinates, Here is why. (Issue #5984)

2025-05-22 Thread LeeWellsUU via rails-dev
LeeWellsUU left a comment (openstreetmap/openstreetmap-website#5984) Well I feel like I am asking people that admit to speaking different languages to accept a different coordinate system with a built in directions and a built in metric scale. I am just asking it to be an option, like French or En

[openstreetmap/openstreetmap-website] Remove legacy OpenID login (PR #6038)

2025-05-22 Thread mmd via rails-dev
### Description Fixes #6020 ### How has this been tested? Scenarios tested on local instance: 1. GitHub as single third party provider - Log in / Sign up - Change external authentication on "My Account" from "Github" to "None", and back to "Github", check log in process 2. No third party prov

Re: [openstreetmap/openstreetmap-website] Use same logic for feature names (PR #6037)

2025-05-22 Thread Ciaran McKeown via rails-dev
@CiaranMcKeown21 approved this pull request. Looks good to me -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6037#pullrequestreview-2861635648 You are receiving this because you are subscribed to this thread. Message ID:

[openstreetmap/openstreetmap-website] Use same logic for feature names (PR #6037)

2025-05-22 Thread Marwin Hochfelsner via rails-dev
JS and Ruby side feature naming has been a bit different. Using a similar structure and logic, these parts can become nearly identical to read. I also moved the standard address to i18n as some languages have it the other way round. Closes #3447 You can view, comment on, or merge this pull reques

Re: [openstreetmap/openstreetmap-website] TranslateWiki doesn't sync changes (Issue #6036)

2025-05-22 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6036) Yes they haven't synced for a while but that's for them to deal with and not something we can do anything about here. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/

[openstreetmap/openstreetmap-website] TranslateWiki doesn't sync changes (Issue #6036)

2025-05-22 Thread Marwin Hochfelsner via rails-dev
hlfan created an issue (openstreetmap/openstreetmap-website#6036) Many of the new features include translatable content, but they don't show up in translatewiki and also don't get added into the repo by @translatewiki. -- Reply to this email directly or view it on GitHub: https://github.com/ope

Re: [openstreetmap/openstreetmap-website] TranslateWiki doesn't sync changes (Issue #6036)

2025-05-22 Thread Tom Hughes via rails-dev
Closed #6036 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6036#event-17771608167 You are receiving this because you are subscribed to this thread. Message ID: ___ rai

Re: [openstreetmap/openstreetmap-website] Remove routing submit button (PR #5960)

2025-05-22 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#5960) Are the tests OK now @tomhughes? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5960#issuecomment-2900775694 You are receiving this because you are subscribed to thi

Re: [openstreetmap/openstreetmap-website] Add latest diaries partial to profile page (PR #6010)

2025-05-22 Thread Marwin Hochfelsner via rails-dev
@hlfan approved this pull request. Thanks for the changes! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6010#pullrequestreview-2860745317 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

2025-05-22 Thread David Tsiklauri via rails-dev
@nertc commented on this pull request. > +class SocialLink < ApplicationRecord + belongs_to :user + + validates :url, :format => { :with => %r{\A(https?://.+|@([a-zA-Z0-9_]+)@([\w\-\.]+))\z}, :message => :http_parse_error } + + URL_PATTERNS = { +:bluesky => %r{\Ahttps?://(?:www\.)?bsky\

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

2025-05-22 Thread David Tsiklauri via rails-dev
nertc left a comment (openstreetmap/openstreetmap-website#5439) PR was updated. `master` was merged and conflicts were resolved. Code was changed according to the reviews. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5439#issu

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

2025-05-22 Thread David Tsiklauri via rails-dev
@nertc pushed 1 commit. c410c5704ac3e3649f3e64293b6628e8becee5b8 Add social profile links -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/2c79d415e458aa91ceb7deaa330f1e3e56a838e1..c410c5704ac3e3649f3e64293b6628e8becee5b8 You are receiving this becaus

Re: [openstreetmap/openstreetmap-website] Add latest diaries partial to profile page (PR #6010)

2025-05-22 Thread Emin Kocan via rails-dev
kcne left a comment (openstreetmap/openstreetmap-website#6010) > Thanks for the update, it's coming together! I still found a few nitpicks. Resolved the issues. Thank you for review. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pul

Re: [openstreetmap/openstreetmap-website] Add latest diaries partial to profile page (PR #6010)

2025-05-22 Thread Emin Kocan via rails-dev
@kcne commented on this pull request. > + +<% diary_entries.each do |entry| %> + + + + + http://www.w3.org/2000/svg"; width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stro

Re: [openstreetmap/openstreetmap-website] Add latest diaries partial to profile page (PR #6010)

2025-05-22 Thread Emin Kocan via rails-dev
@kcne commented on this pull request. > + <%= t(".latest_diaries") %> + +<% diary_entries.each do |entry| %> + + + + + http://www.w3.org/2000/svg"; width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="

Re: [openstreetmap/openstreetmap-website] Add latest diaries partial to profile page (PR #6010)

2025-05-22 Thread Emin Kocan via rails-dev
@kcne commented on this pull request. > @@ -0,0 +1,31 @@ +<% if diary_entries.present? %> + <%= t(".latest_diaries") %> + +<% diary_entries.each do |entry| %> + + + + + http://www.w3.org/2000/svg"; width="24" height="24" viewBox="0 0 24 24

Re: [openstreetmap/openstreetmap-website] Add latest diaries partial to profile page (PR #6010)

2025-05-22 Thread Emin Kocan via rails-dev
@kcne pushed 1 commit. 8f7deefadf16957cdf048711e4988a360894e6c2 Add profile diaries partial to profile -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6010/files/5132e7ffa718005a0b9f85a6ce063b5eb8f6c085..8f7deefadf16957cdf048711e4988a360894e6c2 You are receivin