andrewharvey left a comment (openstreetmap/openstreetmap-website#4194)
> blocking users from manually setting their username to user_NNN type
> usernames, to avoid collisions,
> giving the user "name" in the browse pages. We are already publishing the uid
> and generated username in the XML and
@AntonKhorev pushed 1 commit.
f0bc5d01e887f8b7295c6fa3987085dc41236d9d Use dir="auto" for comments on
element browse pages
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6033/files/33fbf7028252587f66793abc8949b9e98baf54ae..f0bc5d01e887f8b7295c6fa3987085dc4123
Not part of #3429.
Fixes the first wrong image from
https://github.com/openstreetmap/openstreetmap-website/pull/3429#issuecomment-2828944354.
Before:
After:
@tomhughes: So the issue with the current code seems to be related to
ruby-openid, which has been archived a couple of years ago:
https://github.com/openid/ruby-openid
During callback processing, the user session no longer includ
danieldegroot2 left a comment (openstreetmap/openstreetmap-website#1735)
Yes, that would be my other suggestion, but is more noticeable change / might
be more work to redo rather than add code, though I suppose linking pop-up to
marker is the same thing and does not solve below directly.
> Curr
Merged #6029 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6029#event-17739099347
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@hlfan commented on this pull request.
> @@ -130,11 +134,23 @@ OSM.History = function (map) {
nextNewList.children().appendTo(oldList);
nextNewList.remove();
}
+
+if (location.pathname === "/history") {
+ setPaginationMapHashes();
+}
+ }
+
+ function setPaginati
@hlfan requested changes on this pull request.
File a bug report at https://github.com/domoritz/leaflet-locatecontrol instead
of disabling the needle for everyone
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6032#pullrequest
@AntonKhorev commented on this pull request.
> assert_response :success
# The data should not be empty
heatmap_data = assigns(:heatmap_data)
assert_not_nil heatmap_data
assert_predicate heatmap_data[:data], :any?
# The data should be in the right format
-assert(
@AntonKhorev pushed 3 commits.
997831c904b20f1c4b527f1b7fc652c8214ed76e Test if max_id is present in heatmap
data
f071e03efc4743541d9f41d74fc4753c1d25df1f Split heatmap rendering test
251599ba6c2592504afd8ef747af8e8f5d110d6b Show heatmap only to logged in users
--
View it on GitHub:
https://
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#5829)
1 Warning
:warning:
Merge commits are found in PR. Please rebase to
get rid of the merge commits in this PR, see CONTRIBUTING.md.
Genera
@AntonKhorev pushed 6 commits.
aa14f2577426575b1028f74bc5a21e35ae94d743 Add dir=auto to user generated content
85759a3250397b2570100ba9b409b2f3b5a33df9 Add dir=auto to usernames
ea601a6e65db9c0efc1dc277aaf106c62f9fde49 Merge remote-tracking branch
'upstream/pull/3429'
d9011934097e3177635073957
@hlfan commented on this pull request.
> assert_response :success
# The data should not be empty
heatmap_data = assigns(:heatmap_data)
assert_not_nil heatmap_data
assert_predicate heatmap_data[:data], :any?
# The data should be in the right format
-assert(heatma
Closes #6030
I didn't test this.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6032
-- Commit Summary --
* Don't draw compass needle
-- File Changes --
M app/assets/javascripts/leaflet.locate.js (1)
-- Patc
verhovsky left a comment (openstreetmap/openstreetmap-website#6030)
It seems to be possible with `showCompass: false`
https://github.com/domoritz/leaflet-locatecontrol/blob/70b5bd24cdb5fa1debddbf9cd3d37f957278873e/README.md?plain=1#L97
--
Reply to this email directly or view it on GitHub:
https
tomhughes left a comment (openstreetmap/openstreetmap-website#6032)
Oh no sorry I was misreading `yarn.lock` and we are on 0.84.2 now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6032#issuecomment-2893803128
You are receiving
@AntonKhorev commented on this pull request.
> @@ -33,7 +34,7 @@ def index
elsif current_user && current_user == target_user
t ".my_gps_traces"
else
- t ".public_traces_from", :user => target_user.display_name
+ t ".public_t
hlfan left a comment (openstreetmap/openstreetmap-website#5853)
Has there been any policy decision yet?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5853#issuecomment-2894554455
You are receiving this because you are subscribed
danieldegroot2 left a comment (openstreetmap/openstreetmap-website#1735)
Was #670
@AntonKhorev Would it be possible to open a single item menu on left and/or
right click with 'remove marker' (and the right click menu)? (if user uses
(right) click at/near marker user probably wants to click on m
hlfan left a comment (openstreetmap/openstreetmap-website#6032)
That fix has landed here, and this only only regards the transform attribute I
misplaced. This doesn't have to do with the location marker selection.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstre
AntonKhorev left a comment (openstreetmap/openstreetmap-website#1735)
> The user can already
>
>* (a list of completely different things)
...and the solutions proposed here are *let's do another completely different
thing like a popup menu*.
If we don't want to introduce *another completel
hlfan left a comment (openstreetmap/openstreetmap-website#4167)
Putting these in the search bar sounds suspiciously like #1123
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/4167#issuecomment-2893848744
You are receiving this b
danieldegroot2 left a comment (openstreetmap/openstreetmap-website#737)
Sidenote: a button to solely 'Discard all changes', which would be in addition
not as a replacement, is being discussed at
[iD#10045](https://github.com/openstreetmap/iD/pull/10045)
--
Reply to this email directly or view
tomhughes left a comment (openstreetmap/openstreetmap-website#6032)
Probably https://github.com/domoritz/leaflet-locatecontrol/issues/367 is the
culprit which is fixed in 0.84.2 but it looks like dependabot hasn't noticed
that for some reason.
--
Reply to this email directly or view it on GitH
Closed #6032.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6032#event-17731276793
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
monperrus left a comment (openstreetmap/openstreetmap-website#6031)
yes, the default can only match the intuitive expectation of the majority. hard
to measure though.
I believe that lots of people expects markers because this is how it's done in
lots of Maps apps, incl. Google Maps.
--
Reply
@HolgerJeromin requested changes on this pull request.
should be closed
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6032#pullrequestreview-2853409350
You are receiving this because you are subscribed to this thread.
Message
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#6032)
This checks internally for support of
https://developer.mozilla.org/en-US/docs/Web/API/DeviceOrientationEvent/alpha
or
https://developer.apple.com/documentation/webkitjs/deviceorientationevent/1804777-webkitcompassheading
Wh
tomhughes left a comment (openstreetmap/openstreetmap-website#6031)
It seems to me that this is very much a question of personal preference -
there's no obvious right or wrong answer to what the default should be.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstre
monperrus left a comment (openstreetmap/openstreetmap-website#6025)
Created https://github.com/openstreetmap/openstreetmap-website/pull/6031
accordingly
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6025#issuecomment-28931651
30 matches
Mail list logo
