mmd-osm left a comment (openstreetmap/openstreetmap-website#6022)
We never see these screenshots images taken when something is failing:
`[Screenshot Image]:
/home/runner/work/openstreetmap-website/openstreetmap-website/tmp/screenshots/failures_test_translated_links.png`
https://dev.to/ugifract
@AntonKhorev pushed 3 commits.
0403f719a386c73fbb528dcb6c12a8c5a2fc6f00 Replace text input with select for
basic language preference
713585e76efa16ae018d656b0328013aedf4cff3 Adapt basic language select to update
single language value
64b41a8879050a7f82ec670f5fd3a8ccbc2bb042 Adapt basic langua
@AntonKhorev pushed 11 commits.
d60cb53eacff4136545f75ad5fd6173748c27fa6 Move basic preferences controller to
preferences module
05753f705a2e3783e7de1762dc17ae734d4c4ef0 Create parent preferences controller
class
29f075322f9e58bc438e9565e16abdb33e11ea19 Add empty advanced preferences page
837
verhovsky left a comment (openstreetmap/openstreetmap-website#5998)
> just 5 color buckets is easier to read than a continuous gradient
for example I can't see any of my contributions because in the last few months
I've had days with a lot more contributions
https://github.com/user-attachments/
@AntonKhorev pushed 2 commits.
9795ef613d2612a12ae55b96250154cbd43faaa2 Adapt basic language select to update
single language value
64e406aed8b8c6ce2bcb3ba502ff362520f2e9cc Adapt basic language select to update
multiple language values
--
View it on GitHub:
https://github.com/openstreetmap/o
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#6024)
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Gener
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-web
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5992)
The only thing that could be significantly improved here were km/mi buttons
code. I didn't do this because I haven't finished with them. There were
supposed to be tooltips and I also wanted to try miles-yards, in which case th
@hlfan commented on this pull request.
> @@ -2,6 +2,7 @@ class UsersController < ApplicationController
include EmailMethods
include SessionMethods
include UserMethods
+ include HeatmapHelper
I don't think it should have been in the controller at all.
--
Reply to this email directly
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5992)
What was an improvement here?
Especially given this [let's move unit conversions out of
formatters](https://github.com/openstreetmap/openstreetmap-website/pull/5915#discussion_r2039306783),
which I did, followed by [let's mov
deevroman left a comment (openstreetmap/openstreetmap-website#6023)
Related to a bug in heatmaps processing
https://github.com/openstreetmap/openstreetmap-website/issues/6021#issuecomment-2888487364
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstree
tomhughes left a comment (openstreetmap/openstreetmap-website#6022)
Well I'd love to fix it but I can't work out what's going wrong!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6022#issuecomment-2888473006
You are receiving
tomhughes left a comment (openstreetmap/openstreetmap-website#6023)
I couldn't be bothered to work out if that could be done so I just restarted
the caches to flush everything...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/
hlfan left a comment (openstreetmap/openstreetmap-website#6023)
@tomhughes what does it take to delete all cache entries with keys containing
"heatmap"?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6023#issuecomment-28884918
@tomhughes approved this pull request.
Thanks. This looks good to me now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6018#pullrequestreview-2848342981
You are receiving this because you are subscribed to this thread.
Messa
hlfan left a comment (openstreetmap/openstreetmap-website#6021)
Great! Now it returns HTTP 500 status codes... 😬
Next time I guess I'll rename the cache keys again
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6021#issuecommen
1ec5 created an issue (openstreetmap/openstreetmap-website#6023)
### URL
https://www.openstreetmap.org/user/Minh%20Nguyen
### How to reproduce the issue?
Open certain user profile pages (can’t figure out a pattern yet).
### Screenshot(s) or anything else?
--
Reply to this email directly or view it on GitHub:
https://
deevroman left a comment (openstreetmap/openstreetmap-website#6021)
I saw that the cause had already been found
https://github.com/openstreetmap/openstreetmap-website/pull/5998#issuecomment-2888280658
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstr
mmd-osm left a comment (openstreetmap/openstreetmap-website#6021)
Same results here: Chrome Version 128.0.6613.84 on Linux x64 is failing,
Firefox is ok.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6021#issuecomment-2888348
deevroman created an issue (openstreetmap/openstreetmap-website#6021)
### URL
https://www.openstreetmap.org/user/TrickyFoxy
### How to reproduce the issue?
Open any active user profile
Version 136.0.7103.114 (Official Build) (arm64)
macOS 15
### Screenshot(s) or anything else?
https://github
@hlfan pushed 1 commit.
19938d5c7aa23c247fa41ef2c7fa2992b8ef7303 Fix heatmap not appearing when first
day of the week is a Sunday
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6018/files/3f7fe6412d499e63d06ab0a0b1c8e290e333136d..19938d5c7aa23c247fa41ef2c7fa2
hlfan left a comment (openstreetmap/openstreetmap-website#5998)
I think I've found the culprit:
https://github.com/openstreetmap/openstreetmap-website/blob/32f23461fc37f93ba7fcddd901ed156d544c575e/app/assets/javascripts/heatmap.js#L23
getUTCDay is [0,6], weekInfo.firstDay is [1,7]
--
Reply to th
tomhughes left a comment (openstreetmap/openstreetmap-website#5998)
Looks OK to me in both Firefox and Chromium on linux whether or not I am logged
in.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5998#issuecomment-2888277827
git-tgo left a comment (openstreetmap/openstreetmap-website#5998)
nenad-vujicic > ... looks now (Edge, Chrome ...
I can partly agree.
 | logged in | logged out
-- | -- | --
FF | ok | ok
Edge | not ok | ok
Chrome | not ok | ok
--
Reply to this email directly or view it on GitHub:
https://git
nenad-vujicic left a comment (openstreetmap/openstreetmap-website#5998)
I'm not 100% sure merging of this PR is causing this, but take a look at how
e.g. (my profile page)[https://www.openstreetmap.org/user/Nenad%20Vujicic]
looks now (Edge, Chrome, .. every browser and user profile I tried):
