tomhughes left a comment (openstreetmap/openstreetmap-website#5906)
Thanks for all the work on this but I think there's general agreement that
#5998 is the better option so I've merged that now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap
Merged #5998 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5998#event-17680157062
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5906 via #5998.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5906#event-17680157247
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-de
Closed #5905 as completed via #5998.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5905#event-17680157351
You are receiving this because you are subscribed to this thread.
Message ID:
_
Closed #5810 as completed via #5998.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5810#event-17680157387
You are receiving this because you are subscribed to this thread.
Message ID:
_
@tomhughes approved this pull request.
Thanks. I think this is good now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5998#pullrequestreview-2845136366
You are receiving this because you are subscribed to this thread.
Messag
@hlfan commented on this pull request.
> +border-radius: 25%;
+div {
+ background-color: var(--bs-success-text-emphasis);
+ @extend .h-100;
+}
+&:empty {
+ @extend .bg-body-secondary, .bg-opacity-75;
+}
+&:hover {
+ border: solid 1px #8884;
+}
+ }
@hlfan pushed 1 commit.
77371e8f3eea6d38ea2092a3bbdca1d8a190b396 Prerender heatmap in partial
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5998/files/6250bfa015fd915aaf600e08ca20e7014b07e24d..77371e8f3eea6d38ea2092a3bbdca1d8a190b396
You are receiving this be
@hlfan commented on this pull request.
> +border-radius: 25%;
+div {
+ background-color: var(--bs-success-text-emphasis);
+ @extend .h-100;
+}
+&:empty {
+ @extend .bg-body-secondary, .bg-opacity-75;
+}
+&:hover {
+ border: solid 1px #8884;
+}
+ }
Merged #6015 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6015#event-17679511826
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6014 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6014#event-17679511864
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes requested changes on this pull request.
> +border-radius: 25%;
+div {
+ background-color: var(--bs-success-text-emphasis);
+ @extend .h-100;
+}
+&:empty {
+ @extend .bg-body-secondary, .bg-opacity-75;
+}
+&:hover {
+ border: solid 1px #8884;
tomhughes left a comment (openstreetmap/openstreetmap-website#6014)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6014#issuecomment-2885100803
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#6015)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6015#issuecomment-2885093257
You are receiving this because you are subscribed to this t
mmd-osm left a comment (openstreetmap/openstreetmap-website#5973)
Thank you for your feedback, in particular for the interesting example about
the create action.
> I didn't see anyone respond above to @joto's point
I think I sort of addressed this one: _I agree that the action attribute
doesn
@hlfan pushed 5 commits.
772143a7a0891980c1f28aac4cc671e97fc4c50f Add InlineSvg module
a77530b4be76e1a0a30fa5e21d7ef9b99974525c Inline search icons with helper
640f2ba2ac7a83eddc6ac00cf0167d183fd2c290 Inline about icons with helper
f8c941e8738e647d583c276424cc2f23ba5341ff Inline welcome icons
@1ec5 commented on this pull request.
> +class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with =>
%r{\A(https?://.+|@([a-zA-Z0-9_]+)@([\w\-\.]+))\z}, :message =>
:http_parse_error }
+
+ URL_PATTERNS = {
+:bluesky => %r{\Ahttps?://(?:www\.)?bsky\.
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6015#pullrequestreview-2844862193
You are receiving this because you are subscribed to this thread.
Message ID:
__
@1ec5 commented on this pull request.
> +#
+# Indexes
+#
+# index_social_links_on_user_id (user_id)
+#
+# Foreign Keys
+#
+# fk_rails_... (user_id => users.id)
+#
+
+class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :mess
jake-low left a comment (openstreetmap/openstreetmap-website#5973)
> Edit: I've just noticed that https://github.com/OSMCha/osmchange-parser has
> already implemented the re-grouping. Maybe @jake-low has some insights to
> share on the JSON format.
Just dropping in to respond to this ping, sorr
@AntonKhorev commented on this pull request.
> +
+
+
+
+
Small layout with `w-auto`:
Small layout with the wrapper:
@([\w\-\.]+))\z}, :message =>
:http_parse_error }
+
+ URL_PATTERNS = {
+:bluesky => %r{\Ahttps?://(?:www\.)?b
Merged #6012 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6012#event-17676350541
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6013 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6013#event-17676350530
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6010)
I wonder if this should go underneath the heatmap rather than above it? It
pretty much pushes the heatmap below the fold on a laptop...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/open
tomhughes left a comment (openstreetmap/openstreetmap-website#6012)
I still don't really understand but I guess this is harmless.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6012#issuecomment-2884510105
You are receiving this
tomhughes left a comment (openstreetmap/openstreetmap-website#6013)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6013#issuecomment-2884489119
You are receiving this because you are subscribed to this t
mmd-osm left a comment (openstreetmap/openstreetmap-website#5758)
@AntonKhorev : can you take a look at the proposed db schema changes and
comment if you're ok with them?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5758#iss
mmd-osm left a comment (openstreetmap/openstreetmap-website#5973)
So we could probably deploy the cgimap implementation on the dev server (as
dedicated entry in https://apis.dev.openstreetmap.org/) for further testing,
and get some feedback on the proposed format.
The implementation covers chan
@hlfan commented on this pull request.
> +
+
+
+
+
You don't have to wrap the table in a div
```suggestion
```
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6015#pullrequestreview-2844234586
You a
Our search results and changeset lists in the sidebar look like this:
They take full width with borders between entries going from one side to
another.
However out routing directions look a little different
hlfan left a comment (openstreetmap/openstreetmap-website#5998)
> we might want to set a fixed border-radius
This is what is currently being applied with Bootstrap's `rounded-1`, but I
agree a relative border-radius looks more consistent.
> the scrollbar overlaps with the heatmap area
I've add
@hlfan pushed 4 commits.
8a0a9c9c726e724adff9817b6af571b751a7acc6 Use common note marker definitions
0bb1763f8746aa6a6dc958d1cc1236e5a3daebae Generalize leaflet-marker-icon
selector
8d22262e41e7e72db3e5af15b9e6cfbc5b4d75c0 Update and inline markers
2ea82ae937a16a6c7ef3d9d8db4b8e46ba38fabc Cle
@hlfan pushed 1 commit.
6250bfa015fd915aaf600e08ca20e7014b07e24d Prerender heatmap in partial
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5998/files/fb5e574d09fc2d5fd31800349f9b250a4d60ae68..6250bfa015fd915aaf600e08ca20e7014b07e24d
You are receiving this be
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6012)
I'm changing these implementation details in the next PR #6014. Do I test for
the current behavior (read diary entry properties from params except for the
language but only in `new` action) or do I test for something that make
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6014
-- Commit Summary --
* Test if preferred diary entry language is selected
* Allow new diary entry language to be specified in params
* Rename default_lang to
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6013
-- Commit Summary --
* Add diary entries navigation template
* Rename @entry to @diary_entry to match model name
* Add new diary entry links to user's own dia
@nertc commented on this pull request.
> +#
+# Indexes
+#
+# index_social_links_on_user_id (user_id)
+#
+# Foreign Keys
+#
+# fk_rails_... (user_id => users.id)
+#
+
+class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :mes
@nertc pushed 1 commit.
a7bd92a69a0ec4489a54cbbeaae136548950d8d3 Add social profile links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/4c88ed958a347124a4068568944e1ae422cf5b17..a7bd92a69a0ec4489a54cbbeaae136548950d8d3
You are receiving this becaus
kcne left a comment (openstreetmap/openstreetmap-website#5998)
I've noticed that the border radius of the day cells changes between desktop
and mobile — it looks slightly rounded on desktop but becomes almost
pill-shaped on mobile. If this isn’t intentional, we might want to set a fixed
border-
kcne left a comment (openstreetmap/openstreetmap-website#6010)
> If we're going to call it "Recent Diaries" should we apply some sort of date
> limit to the selection? Otherwise maybe "Latest Diaries" would be a better
> title?
Changed the naming here since latest diaries makes a bit more sense
nertc left a comment (openstreetmap/openstreetmap-website#5439)
Last commits from `master` were merged and `Metrics/ClassLength` was changed to
623.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439#issuecomment-2883014297
You
@nertc pushed 1 commit.
2c79d415e458aa91ceb7deaa330f1e3e56a838e1 Add social profile links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/a7bd92a69a0ec4489a54cbbeaae136548950d8d3..2c79d415e458aa91ceb7deaa330f1e3e56a838e1
You are receiving this becaus
@nertc commented on this pull request.
> +
+class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :message =>
:http_parse_error }
+
+ URL_PATTERNS = {
+:bluesky => %r{\Ahttps?://(?:www\.)?bsky\.app/profile/([a-zA-Z0-9\._-]+
nertc left a comment (openstreetmap/openstreetmap-website#5439)
PR was updated. `master` was merged. All conflicts were resolved.
PR was changed according to the suggestions.
Only RuboCop error is about the length of the `User` class (this PR added only
2 necessary lines to it). I can change `Met
tomhughes left a comment (openstreetmap/openstreetmap-website#5439)
You'll need to bump that value for now - we can't take this with failing lint.
See
https://github.com/openstreetmap/openstreetmap-website/pull/5988#issuecomment-2859279812
and following comments for recent discussion around thi
@nertc commented on this pull request.
> +#
+# Foreign Keys
+#
+# fk_rails_... (user_id => users.id)
+#
+
+class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :message =>
:http_parse_error }
+
+ URL_PATTERNS = {
+:blues
@kcne pushed 1 commit.
e659e475229d96044e1584370427f2357f50b94f Add recent diaries partial to profile
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6010/files/efdfaedeab560e0f4189d073e253ebc653ebb899..e659e475229d96044e1584370427f2357f50b94f
You are receiving
@kcne commented on this pull request.
> @@ -0,0 +1,27 @@
+<% if diary_entries.present? %>
+ <%= t(".recent_diaries") %>
Certainly does. Applied. Thank you.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6010#discussion_r20904
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#5439)
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Gener
@kcne pushed 1 commit.
270fd70b102a08f63f2d99def89c5de8226258fa Add recent diaries partial to profile
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6010/files/544532037f8a49096d7a00451cf7880cafe9d54f..270fd70b102a08f63f2d99def89c5de8226258fa
You are receiving
@kcne pushed 1 commit.
544532037f8a49096d7a00451cf7880cafe9d54f Add recent diaries partial to profile
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6010/files/e659e475229d96044e1584370427f2357f50b94f..544532037f8a49096d7a00451cf7880cafe9d54f
You are receiving
@kcne commented on this pull request.
On app/views/diary_entries/_profile_diaries.html.erb:
Refactored. Thank you.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6010#discussion_r2090489793
You are receiving this because you a
@kcne commented on this pull request.
> +<% diary_entries.each do |entry| %>
+
+
+
+
+ <%= image_tag "note.svg", :class => "card-icon", :alt => "Note"
%>
+ <%= link_to entry.title, diary_entry_path(@user, entry) %>
+
@kcne commented on this pull request.
> @@ -0,0 +1,27 @@
+<% if diary_entries.present? %>
+ <%= t(".recent_diaries") %>
+
+<% diary_entries.each do |entry| %>
+
+
+
+
+ <%= image_tag "note.svg", :class => "card-icon", :alt => "Note"
%>
+
56 matches
Mail list logo
