hlfan left a comment (openstreetmap/openstreetmap-website#5998)
I've now moved the bootstrap styling to the CSS, saving about a dozen+ kB in
the page response size.
Also `data-month` now counts beyond 12 so I don't have to deal with jQuery
selecting both labels of the same month.
And I've fixed
@hlfan pushed 1 commit.
fb5e574d09fc2d5fd31800349f9b250a4d60ae68 Prerender heatmap in partial
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5998/files/699ff148af9e759365c2a8e6904a3bae59283f27..fb5e574d09fc2d5fd31800349f9b250a4d60ae68
You are receiving this be
@rkoeze commented on this pull request.
Looks great. Left a couple of comments.
I wonder if there's an opportunity to use some of these design elements on the
`/diaries` page.
> @@ -0,0 +1,27 @@
+<% if diary_entries.present? %>
+ <%= t(".recent_diaries") %>
Would it make sense to style the "R
nenad-vujicic left a comment (openstreetmap/openstreetmap-website#5904)
> **Mutable text/coordinates of Notes however looks highly problematic to me.**
>
> ...
>
> Changing the text or coordinates of an original note (or previous comment) at
> a later time, (potentially) changes the meaning of
@hlfan commented on this pull request.
> -
-cal.on("mouseover", (event, timestamp, value) => {
- if (!displayName || !value) return;
- if (event.target.parentElement.nodeName === "a") return;
+}
+if (weekColumn === 1) {
+ $day.addClass("d-none");
+ continue;
+
@tomhughes commented on this pull request.
> -
-cal.on("mouseover", (event, timestamp, value) => {
- if (!displayName || !value) return;
- if (event.target.parentElement.nodeName === "a") return;
+}
+if (weekColumn === 1) {
+ $day.addClass("d-none");
+ continue;
+
Merged #5988 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5988#event-17658151168
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6005 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6005#event-17658151124
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6005)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6005#issuecomment-2881045431
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#6012)
Sure it's possible, but it's an implementation detail not a public API that we
want people to take advantage of, so what exactly is the use for making this
work? Is there some internal use where we need it?
--
Reply to this em
tomhughes left a comment (openstreetmap/openstreetmap-website#5988)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5988#issuecomment-2881019011
You are receiving this because you are subscribed to this t
It's possible to open the new diary entry link with parameters to
initialize the form values like this:
https://www.openstreetmap.org/diary/new?diary_entry[title]=Subject&diary_entry[body]=texttexttext
The only value that is not supported is entry language because it's
overwritten by user pref
@rkoeze pushed 2 commits.
8fadbd353415cb69986d662aa368a4dc8ac33a53 Move gravatar_enable method to User
model
3b7dce75b2d9ce4f27d163b3bd4383c6da1698ea Bump ClassLength rubocop_todo
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5988/files/d8423e8e10091dfe6ce9
@rkoeze pushed 1 commit.
45b947f4a9661af57e25567fc2db821c2bbf287b Support interactive debugger
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5851/files/75d3fed09441b7e7cb8b2cad424ccdea024f92e6..45b947f4a9661af57e25567fc2db821c2bbf287b
You are receiving this b
14 matches
Mail list logo
