Re: [openstreetmap/openstreetmap-website] Change language for welcome mat (Issue #5991)

2025-05-07 Thread Tom Hughes via rails-dev
Closed #5991 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5991#event-17567567639 You are receiving this because you are subscribed to this thread. Message ID: ___ rai

Re: [openstreetmap/openstreetmap-website] Change language for welcome mat (Issue #5991)

2025-05-07 Thread Minh Nguyễn via rails-dev
1ec5 left a comment (openstreetmap/openstreetmap-website#5991) The welcome mat for corporate and institutional editing teams is a separate website. Unfortunately it doesn’t appear to be translatable yet: osmfoundation/welcome-mat#8. -- Reply to this email directly or view it on GitHub: https:/

[openstreetmap/openstreetmap-website] Change language for welcome mat (Issue #5991)

2025-05-07 Thread Andres Gomez Casanova via rails-dev
angoca created an issue (openstreetmap/openstreetmap-website#5991) ### Problem I want to know if the Welcome section https://welcome.openstreetmap.org/ is translated into other languages? And if so, then how to change the language for this welcome section: I cannot find the translation under

Re: [openstreetmap/openstreetmap-website] Permalinks break when user changes their display name (#482)

2025-05-07 Thread Andrew Harvey via rails-dev
andrewharvey left a comment (openstreetmap/openstreetmap-website#482) Recently a DWG member who had changed their display name, had another user claim their prior display name who then went on to use the profile to spread insults towards DWG members. This was problematic because the user profile

Re: [openstreetmap/openstreetmap-website] Move `gravatar_enable` method to User model (PR #5988)

2025-05-07 Thread rkoeze via rails-dev
rkoeze left a comment (openstreetmap/openstreetmap-website#5988) As a fly-by-night contributor I'll happily defer to whatever course of action you prefer. A couple of thoughts: - I put together [a quick spike](https://github.com/rkoeze/openstreetmap-website/pull/2) showing how we might use conc

Re: [openstreetmap/openstreetmap-website] Proposal for adding support for map notes tags (Issue #5294)

2025-05-07 Thread Kyℓe Hensel via rails-dev
k-yle left a comment (openstreetmap/openstreetmap-website#5294) would this allow the user who closes a note to add tags? use case: the person who closes the note wants to link the note to the changeset that solved the issue - https://github.com/openstreetmap/iD/issues/9510 -- Reply to this

Re: [openstreetmap/openstreetmap-website] API versions, capabilities and permissions resources (PR #5979)

2025-05-07 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#5979) > "If a client only supports one version they can jump straight to the > versioned capabilities call." Turning off /api/capabilitites and having the clients call the versioned capabilities would still require some changes on the

Re: [openstreetmap/openstreetmap-website] Adds note versions and variable note tags (PR #5904)

2025-05-07 Thread Nenad Vujicic via rails-dev
nenad-vujicic left a comment (openstreetmap/openstreetmap-website#5904) > I think this PR would benefit from outlying in more details exactly _**why**_ > is it doing changes (i.e. what exactly new user-requested functionality will > become available), instead of just enumerating low-level techni

Re: [openstreetmap/openstreetmap-website] Company Name on Profile Page (PR #5987)

2025-05-07 Thread Minh Nguyễn via rails-dev
1ec5 left a comment (openstreetmap/openstreetmap-website#5987) There’s already a fairly strong disincentive to claim corporate affiliation in at least some parts of the OSM community. 😅 Maybe optimistically linking to a matching wiki page could help by giving the user a way to verify for themse

Re: [openstreetmap/openstreetmap-website] Copyright page update (PR #5989)

2025-05-07 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5989) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5989#issuecomment-2859766630 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Company Name on Profile Page (PR #5987)

2025-05-07 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5987) One possible concern with this is that people could start claiming an association with companies that they are not in fact associated with... -- Reply to this email directly or view it on GitHub: https://github.com/openstreetma

Re: [openstreetmap/openstreetmap-website] Update Copyright Page (Issue #5132)

2025-05-07 Thread Tom Hughes via rails-dev
Closed #5132 as completed via #5989. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5132#event-17561436161 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [openstreetmap/openstreetmap-website] Copyright page update (PR #5989)

2025-05-07 Thread Tom Hughes via rails-dev
Merged #5989 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5989#event-17561435898 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Attribution example simpler (Issue #5990)

2025-05-07 Thread Andres Gomez Casanova via rails-dev
Closed #5990 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5990#event-17560922131 You are receiving this because you are subscribed to this thread. Message ID: ___ rai

Re: [openstreetmap/openstreetmap-website] Attribution example simpler (Issue #5990)

2025-05-07 Thread Andres Gomez Casanova via rails-dev
angoca left a comment (openstreetmap/openstreetmap-website#5990) Great! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5990#issuecomment-2859594027 You are receiving this because you are subscribed to this thread. Message ID:

Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

2025-05-07 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 3 commits. 451d3d65350cac5d9c0b212ce431988157d751ca Click links instead of icons in tests 47c92e657dc2e6c9b91dddcc99fd337fa4b71fbe Unify active control button behaviour 68fae56b9dfcaec172b282fc09c7e4521267b8ae Remove controls sprite -- View it on GitHub: https://github.com/opens

Re: [openstreetmap/openstreetmap-website] API versions, capabilities and permissions resources (PR #5979)

2025-05-07 Thread Andy Allan via rails-dev
gravitystorm left a comment (openstreetmap/openstreetmap-website#5979) > JOSM needs to call /api/versions + /api/0.6/capabilities, instead of > /api/capabilities as it is today. Only if it supports multiple API versions. From the original commit message, "If a client only supports one version t

Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

2025-05-07 Thread Marwin Hochfelsner via rails-dev
@hlfan commented on this pull request. > +<%= map_hash = params[:lat].to_f && params[:lon].to_f ? > "#map=#{params[:zoom].to_i || 17}/#{params[:lat].to_f}/#{params[:lon].to_f}" > : "" + t ".how_to_help.add_a_note.instructions_1_html", + :note_icon => link_to(render(:p

Re: [openstreetmap/openstreetmap-website] Deduplicate note adding instructions (PR #5870)

2025-05-07 Thread Tom Hughes via rails-dev
Merged #5870 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5870#event-17560209739 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Deduplicate note adding instructions (PR #5870)

2025-05-07 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5870) This looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5870#issuecomment-2859359091 You are receiving this because you are subscribed to t

Re: [openstreetmap/openstreetmap-website] Clean OSM.formatHash calls (PR #5887)

2025-05-07 Thread Tom Hughes via rails-dev
Merged #5887 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5887#event-17560209703 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Copyright page update (PR #5989)

2025-05-07 Thread Mikel Maron via rails-dev
mikelmaron left a comment (openstreetmap/openstreetmap-website#5989) @AntonKhorev this is a good step forward. CWG is 👍 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5989#issuecomment-2859304442 You are receiving this because y

Re: [openstreetmap/openstreetmap-website] Move `gravatar_enable` method to User model (PR #5988)

2025-05-07 Thread Andy Allan via rails-dev
gravitystorm left a comment (openstreetmap/openstreetmap-website#5988) > You can just bump that limit - anything in `.rubocop_todo.yml` is just there > to allow things that we haven't got around to doing anything yet and for > those metrics ones at least it's not at all clear what if anything we

Re: [openstreetmap/openstreetmap-website] Clean OSM.formatHash calls (PR #5887)

2025-05-07 Thread Tom Hughes via rails-dev
@tomhughes approved this pull request. Thanks for the changes - this looks good to me now. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5887#pullrequestreview-2822502327 You are receiving this because you are subscribed to th

Re: [openstreetmap/openstreetmap-website] Move `gravatar_enable` method to User model (PR #5988)

2025-05-07 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5988) You can just bump that limit - anything in `.rubocop_todo.yml` is just there to allow things that we haven't got around to doing anything yet and for those metrics ones at least it's not at all clear what if anything we even wan

Re: [openstreetmap/openstreetmap-website] Adds note versions and variable note tags (PR #5904)

2025-05-07 Thread Matija Nalis via rails-dev
mnalis left a comment (openstreetmap/openstreetmap-website#5904) I think this PR would benefit from outlying in more details exactly ***why*** is it doing changes (i.e. what exactly new user-requested functionality will become available), instead of just enumerating low-level technical steps whi

Re: [openstreetmap/openstreetmap-website] Adds note versions and variable note tags (PR #5904)

2025-05-07 Thread Nenad Vujicic via rails-dev
@nenad-vujicic pushed 25 commits. 0e9912a46ac04b5b05cd9d4467bdb2b5060a2b7f Adds note versioning and adds note_versions table 79f4670c0948333be32eccc83c6fc3c7f8cb4c51 Adds from_* and save_*! methods to notes a156431a3cff46ff6e58b45c5ee2b594a58a1f81 Adds using from_* and save_*! methods a9175cd

Re: [openstreetmap/openstreetmap-website] Company Name on Profile Page (PR #5987)

2025-05-07 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#5987) It would be good to have a maximum field length, both for home_location_name as well as company. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5987#issuecomment-

Re: [openstreetmap/openstreetmap-website] Attribution example simpler (Issue #5990)

2025-05-07 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#5990) The copyright page will change shortly. Can you check https://github.com/osmfoundation/ewg_bidding/pull/20 + #5989 for planned updates? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/opens

[openstreetmap/openstreetmap-website] Attribution example simpler (Issue #5990)

2025-05-07 Thread Andres Gomez Casanova via rails-dev
angoca created an issue (openstreetmap/openstreetmap-website#5990) ### Problem In this page: https://www.openstreetmap.org/copyright The attribution example is this: https://github.com/user-attachments/assets/b7131184-23da-4d2d-8e86-145afd536d02"; /> However, in the OSMF it says that only the

Re: [openstreetmap/openstreetmap-website] Adds note versions and variable note tags (PR #5904)

2025-05-07 Thread Nenad Vujicic via rails-dev
nenad-vujicic left a comment (openstreetmap/openstreetmap-website#5904) > > 1. for keeping note versions like it is done for other elements (nodes, > > ways and relations) > > I continue to think that this is not a good idea, for starters notes are > _not_ like or even the same class of entity

[openstreetmap/openstreetmap-website] Copyright page update (PR #5989)

2025-05-07 Thread Anton Khorev via rails-dev
Fixes #5132 with update https://github.com/osmfoundation/ewg_bidding/pull/20#issuecomment-2793086541. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5989 -- Commit Summary -- * Add legal babble paragraph helper *