Previously strokes were suppressed using weight: 0 which made them have zero
width. That produced some unnecessary svg attributes for strokes.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5985
-- Commit Summary --
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5981)
> Is there a specific reason you do this in pixel coordinates instead of
> lat/lon coordinates where you can use
> `changeset.bounds.contains(map.getBounds())`?
In pixels I take bbox border widths into account, which is maybe
@AntonKhorev pushed 2 commits.
1d9dc6b87c695f1d90c8a5108053abfc95227e9a Remove area layers for changesets
completely covering map view
da0e75e2de7835a3ad99325ee6c6dd8069fba514 Remove selected changeset classes on
map move/zoom
--
View it on GitHub:
https://github.com/openstreetmap/openstreet
@AntonKhorev commented on this pull request.
>
-for (const layer of this._bboxLayers) {
- layer.updateChangesetLayerBounds(changeset);
Because `updateChangesetsOrder` clears all bbox layers and adds the necessary
bboxes again.
Previously it wasn't necessary in response to n
mmd-osm left a comment (openstreetmap/openstreetmap-website#5973)
Indeed, this looks like a good option. It's probably a matter of taste to have
"type": "create" or "action": "create", either way should be ok. I can see the
benefit of keeping the element objects clean.
NB: I plan to use an even
1ec5 left a comment (openstreetmap/openstreetmap-website#5984)
> aren't you guys sort of competing with Google?
Only in the sense of providing geographic data about on-the-ground stuff that
others could use to create services that compete with Google. You’ve basically
asked the plumber to bake
LeeWellsUU left a comment (openstreetmap/openstreetmap-website#5984)
I don't know if I am allowed to appeal or not so here goes anyway.
1. Many people don't know what the NATO grid is. True Many People don't
know what OpenStreetMaps is but Google Maps knows what MGRS is (the NATO
destination for U
tomhughes left a comment (openstreetmap/openstreetmap-website#5983)
I'm looking at it through cloudflare as well... Obviously there could be one
cache doing something weird but it seems unlikely especially with only one
report.
--
Reply to this email directly or view it on GitHub:
https://gith
@hlfan pushed 1 commit.
1e13706e1de0479d48ea8c8c1db4f83a90aeb9f0 Clean OSM.formatHash calls
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5887/files/12c9885e63c4d2e8536d10e01c90877be1d526ec..1e13706e1de0479d48ea8c8c1db4f83a90aeb9f0
You are receiving this beca
@hlfan pushed 1 commit.
12c9885e63c4d2e8536d10e01c90877be1d526ec Clean OSM.formatHash calls
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5887/files/d0fd248d99f300bd575728c4c3ab23a9f3917c5c..12c9885e63c4d2e8536d10e01c90877be1d526ec
You are receiving this beca
mmd-osm left a comment (openstreetmap/openstreetmap-website#5983)
I see cf-way in the http header, as well as some mix up of different header
fields. Could this be Cloudflare related?
It would be interesting to see if https://master.apis.dev.openstreetmap.org has
the same issue (which doesn't h
tomhughes left a comment (openstreetmap/openstreetmap-website#5984)
I have no idea what any of this has to do with POTUS or why you think it might
appear to be subversive in any case it's not really relevant as this seems like
an end user feature so is out of scope for openstreetmap.org which ex
Closed #5984 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5984#event-17522504452
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
LeeWellsUU created an issue (openstreetmap/openstreetmap-website#5984)
### Problem
This might be considered a subversive email, but here it is anyway.
As you may know many people differ with the positions of our current POTUS, and
that's great. It is a free country and people should be free to
wolfy1339 left a comment (openstreetmap/openstreetmap-website#5983)
It's to the `map.json` endpoint
`https://api.openstreetmap.org/api/0.6/map.json?bbox=-70.927734375,46.3658837048498,-70.9222412109375,46.36967413462374`
--
Reply to this email directly or view it on GitHub:
https://github.com/o
tomhughes left a comment (openstreetmap/openstreetmap-website#5983)
Which request exactly is that the response to? Because I can't see any request
with a response like that :-(
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/59
wolfy1339 left a comment (openstreetmap/openstreetmap-website#5983)
there is nothing unusual at all... It was working fine just yesterday. I
disabled all the tracking stuff within firefox, and any adblockers. heck even
all extensions disabled
What extensions do you have installed? Please try disabling anything that might
be interfering with requests and see if that helps.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstre
tomhughes left a comment (openstreetmap/openstreetmap-website#5983)
I actually use Firefox 138 on Fedora 42 myself and I just tested it and this is
what I see in the inspector for the response to the CORS preflight check:
I think if this was generally true then we would have a lot more reports so
there must be something unusual about your browser - thousands of people use iD
every day without any problem after all.
--
Reply to this email direct
tomhughes left a comment (openstreetmap/openstreetmap-website#5982)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5982#issuecomment-2851386193
You are receiving this because you are subscribed to this t
Merged #5982 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5982#event-17521797024
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
wolfy1339 created an issue (openstreetmap/openstreetmap-website#5983)
### URL
https://www.openstreetmap.org/edit
### How to reproduce the issue?
Firefox 138.0 Fedora 42
1. Open iD at any location
3. iD doesn't load any data
4. Open the Network tab in the developper tools
5. Observe many failed
@hlfan requested changes on this pull request.
Is there a specific reason you do this in pixel coordinates instead of lat/lon
coordinates where you can use `changeset.bounds.contains(map.getBounds())`?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/open
Going through the Rubocop config, I found a few exclusions that weren't
necessary anymore.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5982
-- Commit Summary --
* Remove a few exclusions from RuboCop configurati
Merged #5979 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5979#event-17518809730
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5980 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5980#event-17518809729
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5979)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5979#issuecomment-2850880174
You are receiving this because you are subscribed to this t
@tomhughes commented on this pull request.
>
-for (const layer of this._bboxLayers) {
- layer.updateChangesetLayerBounds(changeset);
This updating of the bounds got removed at the point where you merged
`updateChangesetLocations` into `updateChangesetsGeometry` but it's not
tomhughes left a comment (openstreetmap/openstreetmap-website#5980)
Looks OK to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5980#issuecomment-2850836871
You are receiving this because you are subscribed to this thr
@hlfan pushed 1 commit.
8a97b03a38ea226077a88b682c58a661d9602339 Remove u-turn side decision
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5777/files/4073971014485b09c0f301267b5043ce24822d53..8a97b03a38ea226077a88b682c58a661d9602339
You are receiving this bec
@hlfan pushed 1 commit.
199139f5fb4993b706ad51735b322ae6e6c2b5de Remove svg symbol tags
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5776/files/dd4068c8c7638beeb8e39181ded99dfc82dec90f..199139f5fb4993b706ad51735b322ae6e6c2b5de
You are receiving this because
mmd-osm left a comment (openstreetmap/openstreetmap-website#5979)
This seems like a breaking change. As an example, JOSM needs to call
/api/versions + /api/0.6/capabilities, instead of /api/capabilities as it is
today.
--
Reply to this email directly or view it on GitHub:
https://github.com/op
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5981
-- Commit Summary --
* Switch to NorthWest/SouthEast corners in updateChangesetLocations
* Switch to topLeft/bottomRight corners in updateChangesetShapes
* Ch
34 matches
Mail list logo
