Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)
@AntonKhorev pushed 1 commit. 6597d503f2e62b0e65ff194914b675675054c1a7 Move api changeset upload combined action tests -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5590/files/06224442f61185e8c77509d2a95aca68408c2f6d..6597d503f2e62b0e65ff194914b675675054c1a7
Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)
@AntonKhorev pushed 5 commits. 9500c0534c1b6b567a8579a3f35178314c2e6dd8 Move api changeset upload create tests 7f5ec937e16150ddda20dcd6a3db2ce697b52632 Move api changeset upload delete tests 15bacbc50b6b4a4611165b6c7a3a4b84f76daa94 Move api changeset upload modify tests f55d83cbc874e026de1dbfac
Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)
@AntonKhorev pushed 3 commits. 5f43c751034c55595c1201e37cd31a682412c8c4 Move api changeset upload modify tests ddc229ada5671439af656128f9bbcb83a13d5008 Move api changeset upload unknown action test d83d672962ef23960617c46178c97ffdd0ac0889 Move api changeset upload combined action tests -- V
Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)
@AntonKhorev pushed 3 commits. 25d38a45932633e5affbb9183e1a76f976342be9 Move api changeset upload modify tests 4ba32b39b4eaf59254a642da85b46fd953ae4eea Move api changeset upload unknown action test 24846bcf905e6b943a9e80dd202555b42985cc49 Move api changeset upload combined action tests -- V
Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)
@AntonKhorev pushed 2 commits. f2dc7e55a7b17facc0b5bc465913cd08268871fd Move api changeset upload unknown action test a85992fa0d605f540b51777f466c8719e95b21e4 Move api changeset upload combined action tests -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/559
Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)
@AntonKhorev pushed 7 commits. 897ae79996ea7c63021776caa290310b4b00d49b Create api changeset upload resource 722418dee2bd5af4ed30a8f20eea7a2f67b7159a Remove unnecessary RuboCop exclusions 29c2032346701613f2b143846a0d058fe92dfc44 Move api changeset upload route test 03b34412eb227b9948cabb07c71fe
Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)
@AntonKhorev pushed 1 commit. 5f7b088906f2f6257e994b352ae684a017797efb Move api changeset upload modify tests -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5590/files/cee4d514bd53d30ee16a74901a97e6078b3556df..5f7b088906f2f6257e994b352ae684a017797efb You are r
Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#5590) 1 Warning :warning: Number of updated lines of code is too large to be in one PR. Perhaps it should be separated into two or more? Gener
Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)
@AntonKhorev pushed 7 commits. 5d7dead30d4cbb47c299a31d7cb5100a59f203b3 Create changeset upload resource 99fc30e42942806c43febb9e77d83d132beff610 Remove unnecessary RuboCop exclusions 26d8f6185b69791ad77d6a30c501dbca278bd43c Move changeset upload route test 6750c6636635fbb40a7f95fbec8285cc6d0cf
Re: [openstreetmap/openstreetmap-website] Bump eslint from 9.25.1 to 9.26.0 (PR #5975)
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#5975) 1 Warning :warning: Number of updated lines of code is too large to be in one PR. Perhaps it should be separated into two or more? Gener
[openstreetmap/openstreetmap-website] Bump eslint from 9.25.1 to 9.26.0 (PR #5975)
Bumps [eslint](https://github.com/eslint/eslint) from 9.25.1 to 9.26.0.@hlfan pushed 4 commits. f6e6bd42821dc8780e2edf060ef2a59b7540619e Use common note marker definitions ca88543e9898034678e7e50660ce8a980bdd1ba5 Generalize leaflet-marker-icon selector 05ef75f1cf61752cab15c8ac1f6cc8e3feba684d Update and inline markers 2d75db92d74b5f5635883a171da64f66e6d7e585 Cle
Re: [openstreetmap/openstreetmap-website] Hide routing submit button (PR #5960)
@hlfan pushed 5 commits. e1ae64c5d3bb415859c0dc21d83188df006be1a6 Add tests for directions b88213ad91536a2afb53f04f4aede1d3d495e99e Move routing settings before endpoint fields 60edf02ec5ec21c04506a97935dce423871a5e11 Remove submit button e74a6b842d4ac312b2eb536a3adf2c360c7fbc15 Group close b
Re: [openstreetmap/openstreetmap-website] Support Sign in with Apple (#2799)
HarelM left a comment (openstreetmap/openstreetmap-website#2799) My use case is an app that runs capacitor and opens a secured browser season for OSM login. You can check it out here if you'd like: Https://israelhiking.osm.org.il/ This will prompt you to install the app, which you can try the lo
Re: [openstreetmap/openstreetmap-website] Implement JSON support for the changeset download API (PR #5973)
mmd-osm left a comment (openstreetmap/openstreetmap-website#5973) > > Changefiles today are usually sorted by (OSM type, OSM id, version). This > > ensures that most(*) dependent changes are already available, when reading > > an object. Consumers may rely on that order. > I think we can keep
Re: [openstreetmap/openstreetmap-website] Support Sign in with Apple (#2799)
tomhughes left a comment (openstreetmap/openstreetmap-website#2799) I believe the problem is that if an app opens a webview on osm.org to let the user login and authorise a token then that is considered part of the app so needs to follow those rules. -- Reply to this email directly or view it
Re: [openstreetmap/openstreetmap-website] Support Sign in with Apple (#2799)
pnorman left a comment (openstreetmap/openstreetmap-website#2799) The terms linked are for apps, not websites. https://developer.apple.com/sign-in-with-apple/usage-guidelines-for-websites-and-other-platforms/ is all I found for websites. If you're developing an app, you don't care about what ty
Re: [openstreetmap/openstreetmap-website] Hide routing submit button (PR #5960)
@hlfan pushed 3 commits. 684b844a4a133422ca5380ff150605d6a6f647fd Remove submit button 5109c332cb162ded846a958d5baed2fa707efb93 Group close button into settings ec44e9104dc2b1e0c17bfada523606134cf1816b Clean up layout -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-websit
Re: [openstreetmap/openstreetmap-website] Hide routing submit button (PR #5960)
@hlfan pushed 5 commits. cb1bde01cbbb9dce70735b2b84e37f86507c29bd Prevent aborted requests from logging as errors dcd88d940afb305418421c5d0f44e8bd52c78171 Move routing settings before endpoint fields 44f79dcd1d3b5daa9fd4f1a2904f4f0084729484 Remove submit button ecd5632bd3ae86c9581114943ab62fb
Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)
@hlfan commented on this pull request. > @@ -26,6 +26,10 @@ <% else %> <%= render :partial => "notes_paging_nav" %> + +<%= render :partial => "layouts/defs_markers", :locals => { :types => %w[cross tick] } %> That and `` being the subtree root. Not needed when it includes the SVG
Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)
@hlfan pushed 2 commits. f1f73518758a3d1ae0eefdcc8e10a9b68f9db8e5 Update and inline markers e3c859d4ef22cbb1bb5cb4a47a42063c68f6bf7d Clean up old markers -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5854/files/8bb6564c1b611961832eb6b02b64237aedaa9884..e3c85
Re: [openstreetmap/openstreetmap-website] Hide routing submit button (PR #5960)
hlfan left a comment (openstreetmap/openstreetmap-website#5960) If capybara really doesn't trigger the onchange event after filling in the input, then some other interaction is needed for the routing to run. You already saw that even with re-selecting the first input, > There's some sort of race
Re: [openstreetmap/openstreetmap-website] Implement JSON support for the changeset download API (PR #5973)
mmd-osm left a comment (openstreetmap/openstreetmap-website#5973) I tried a few variations to have `if-unused` on the same level as it is in the XML version. This turned out to be tricky. It would require us to introduce another `elements` array that would have to be added to create and modify
Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)
@tomhughes commented on this pull request. > @@ -26,6 +26,10 @@ <% else %> <%= render :partial => "notes_paging_nav" %> + As all three places that include the partial wrap it in the same `svg` element why not include that in the partial? > @@ -26,6 +26,10 @@ <% else %> <%= render
Re: [openstreetmap/openstreetmap-website] Add outlines for in-viewport changeset bboxes (PR #5964)
Merged #5964 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5964#event-17502840770 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Add outlines for in-viewport changeset bboxes (PR #5964)
tomhughes left a comment (openstreetmap/openstreetmap-website#5964) I think looks good, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5964#issuecomment-2847727537 You are receiving this because you are subscribed to this
Re: [openstreetmap/openstreetmap-website] Add outlines for in-viewport changeset bboxes (PR #5964)
@tomhughes commented on this pull request. > @@ -119,14 +119,12 @@ OSM.HistoryChangesetsLayer = L.FeatureGroup.extend({ const changeset = this._changesets.get(id); if (!changeset) return; -let highlightRect = this._highlightLayer.getLayer(id); -if (!state && highlightRect) {
Re: [openstreetmap/openstreetmap-website] Hide routing submit button (PR #5960)
tomhughes left a comment (openstreetmap/openstreetmap-website#5960) I mean I was really thinking why does there need to be a submit element at all? Then again I don't really like what you've had to do to the test... I mean testing that the reverse direction regenerates the route is fine but we s
Re: [openstreetmap/openstreetmap-website] Add outlines for in-viewport changeset bboxes (PR #5964)
@AntonKhorev commented on this pull request. > @@ -119,14 +119,12 @@ OSM.HistoryChangesetsLayer = L.FeatureGroup.extend({ const changeset = this._changesets.get(id); if (!changeset) return; -let highlightRect = this._highlightLayer.getLayer(id); -if (!state && highlightRect)
Re: [openstreetmap/openstreetmap-website] Add outlines for in-viewport changeset bboxes (PR #5964)
@AntonKhorev commented on this pull request. > @@ -119,14 +119,12 @@ OSM.HistoryChangesetsLayer = L.FeatureGroup.extend({ const changeset = this._changesets.get(id); if (!changeset) return; -let highlightRect = this._highlightLayer.getLayer(id); -if (!state && highlightRect)
Re: [openstreetmap/openstreetmap-website] Support Sign in with Apple (#2799)
HarelM left a comment (openstreetmap/openstreetmap-website#2799) Below is the message that I got from Apple today. I generally **think** that OSM adheres to the requirements, but I think Apple is pushing to allow their login by rejecting application and making the developers (like me) try and pu
Re: [openstreetmap/openstreetmap-website] Support Sign in with Apple (#2799)
tomhughes left a comment (openstreetmap/openstreetmap-website#2799) Whatever arguments there are for this they don't come from that requirement as people can always use a local OSM account to authenticate which would meet the requirements surely? -- Reply to this email directly or view it on G
Re: [openstreetmap/openstreetmap-website] Support Sign in with Apple (#2799)
gy-mate left a comment (openstreetmap/openstreetmap-website#2799) _Relevant Apple guideline: https://developer.apple.com/app-store/review/guidelines/#login-services_ _Related GitHub issue comment: https://github.com/openstreetmap/openstreetmap-website/issues/3476#issuecomment-2668670924_ -- R
Re: [openstreetmap/openstreetmap-website] Don't visit profile page after tested profile location update (PR #5955)
hlfan left a comment (openstreetmap/openstreetmap-website#5955) Sometimes in that test "Profile updated" is still not found. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5955#issuecomment-2847361688 You are receiving this becau
Re: [openstreetmap/openstreetmap-website] Support Sign in with Apple (#2799)
HarelM left a comment (openstreetmap/openstreetmap-website#2799) That's a valid point, and I can totally respect that, but I'm mainly trying to get my life easier since I need to respond every time they reject my app :-/ I can reframe that implementing this would be helpful to my app and thus to
Re: [openstreetmap/openstreetmap-website] Support Sign in with Apple (#2799)
tomhughes left a comment (openstreetmap/openstreetmap-website#2799) I mean personally I don't want to give Apple the satisfaction of paying them to make life easier for their users... -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/is
Re: [openstreetmap/openstreetmap-website] Support Sign in with Apple (#2799)
HarelM left a comment (openstreetmap/openstreetmap-website#2799) @tomhughes is the gap here are only the 79 EU a year or are there still technical issues preventing this from getting completed? I use OSM login for my app in the app store and it keeps getting rejection due to missing Apple login
Re: [openstreetmap/openstreetmap-website] Routing by Car is extremely slow (probably down?), but by Bicycle and by Foot are fine (Issue #5974)
Closed #5974 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5974#event-17496737288 You are receiving this because you are subscribed to this thread. Message ID: ___ rai
Re: [openstreetmap/openstreetmap-website] Routing by Car is extremely slow (probably down?), but by Bicycle and by Foot are fine (Issue #5974)
weizhepei left a comment (openstreetmap/openstreetmap-website#5974) Got it! Many thanks for the pointer! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5974#issuecomment-2846616547 You are receiving this because you are subscri
Re: [openstreetmap/openstreetmap-website] Routing by Car is extremely slow (probably down?), but by Bicycle and by Foot are fine (Issue #5974)
lonvia left a comment (openstreetmap/openstreetmap-website#5974) This isn't the right place to report issues with the OSRM demo server. Usually it is probably best to contact the sysadmins via the email listed at https://map.project-osrm.org/about.html. That said, the sysadmins are aware of the
