weizhepei created an issue (openstreetmap/openstreetmap-website#5974)
### URL
https://www.openstreetmap.org/directions?engine=fossgis_osrm_foot&route=40.2756511%2C-80.1682275%3B40.4395912%2C-79.9895408#map=11/40.3549/-80.0773
### How to reproduce the issue?
Example (By Foot):
https://www.opens
hlfan left a comment (openstreetmap/openstreetmap-website#5960)
> I certainly don't understand the point of having the button present but
> invisible so that it can only be navigated to with tab - what is supposed to
> be the use case for that?
I thought it might be better for accessibility to
@hlfan pushed 4 commits.
5a9a82b8405afd9708af82a8654f329989c3bfec Use common note marker definitions
2f24cfcf3e6a297b36cf24f19970ee62d9018c36 Generalize leaflet-marker-icon
selector
f7af8afec6d1be3d3299b128f58c1acc49d37dd7 Update and inline markers
8bb6564c1b611961832eb6b02b64237aedaa9884 Cle
@hlfan pushed 2 commits.
29732545b866f094deb88904fb1b31dbb2667388 Update and inline markers
322a72203e2b535ec4d22da714da2b929462016a Clean up old markers
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5854/files/7806af3e1ca04a46be22e9da2a8fd58aa6fa329f..322a7
@hlfan pushed 8 commits.
2efc37395f289015a3f7e116eba87024eb0b5bd3 Prevent aborted requests from logging
as errors
594c9fcb0ca19583c9d4cab4b3fdffdc20e85cc5 Keep sidebar closed until next submit
action
ee6ff26e2e1bbd9b8bd86c5fe66aa62556eeb6a0 Move routing settings before endpoint
fields
91c9eb
nenad-vujicic left a comment (openstreetmap/openstreetmap-website#5815)
@tomhughes @AntonKhorev @gravitystorm
Do we have some conclusions about notes versioning / tags? At the beginning I
proposed non-mutable note tags in #5344, then you requested notes versioning
([here](https://github.com/op
@tomhughes commented on this pull request.
> @@ -119,14 +119,12 @@ OSM.HistoryChangesetsLayer = L.FeatureGroup.extend({
const changeset = this._changesets.get(id);
if (!changeset) return;
-let highlightRect = this._highlightLayer.getLayer(id);
-if (!state && highlightRect) {
Closed #5971 as completed via #5972.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5971#event-17490035243
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5972 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5972#event-17490034896
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5960)
I certainly don't understand the point of having the button present but
invisible so that it can only be navigated to with tab - what is supposed to be
the use case for that?
--
Reply to this email directly or view it on GitHu
tomhughes left a comment (openstreetmap/openstreetmap-website#5972)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5972#issuecomment-2845248220
You are receiving this because you are subscribed to this t
simonpoole left a comment (openstreetmap/openstreetmap-website#5966)
> It happens with some map style repositories, such as ..
But not if they are GPL 2.0 licensed (which is the reason for this discussion).
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap
@hlfan pushed 1 commit.
22c041cb7e20ada79a96f1d5e64ed03e8cdfe177 Use display grid to align the buttons
on the right
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5960/files/288990650224680b711789c021a69e63c3aa7212..22c041cb7e20ada79a96f1d5e64ed03e8cdfe177
Yo
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5966)
Source images are here:
https://github.com/openstreetmap/openstreetmap-website/tree/master/assets
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5966#issuec
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5960)
Why do we need the *Go* button at all? One scenario is when the user closes the
directions panel by clicking this close button:
Why wou
1ec5 left a comment (openstreetmap/openstreetmap-website#5966)
> I also wouldn't say it's that common for open source projects that are
> primarily code based to go to the trouble of specifying a different license
> for artwork. I'm sure it does happen but I can't think of any examples off
> th
angoca left a comment (openstreetmap/openstreetmap-website#5966)
I wrote him in LinkedIn, and he answered me this:
https://github.com/user-attachments/assets/da3d5f7f-88b0-4b36-8089-c3b5e3175dbf";
/>
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstr
tomhughes left a comment (openstreetmap/openstreetmap-website#5966)
Only if you can identify the creators of the files and get their permission.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5966#issuecomment-2844957453
You ar
angoca left a comment (openstreetmap/openstreetmap-website#5966)
GPL is not the best-suited license for images or other kinds of artwork. It was
designed for software. A similar situation is that CC-BY is inappropriate for
data, like when OSM switched to ODbL.
In many open-source projects, code
mmd-osm left a comment (openstreetmap/openstreetmap-website#5973)
I think we can keep the sorting of objects (per action) as is, regardless of
the format.
Obviously we would have to define in which sequence create/modified/delete
actions need to be processed, b/c JSON properties don't have a de
joto left a comment (openstreetmap/openstreetmap-website#5973)
I could never understand why there are the `create`, `modify`, and `delete`
actions in the osmChange format, or why there is an osmChange format at all.
Why not use the format that the history file uses: A version 1 is a basically a
lonvia left a comment (openstreetmap/openstreetmap-website#5973)
Changefiles today are usually sorted by (OSM type, OSM id, version). This
ensures that most(*) dependent changes are already available, when reading an
object. Consumers may rely on that order.
(*) The obvious exception are nested
k-yle left a comment (openstreetmap/openstreetmap-website#5973)
got it, I wonder if we actually need to support this behaviour in the new JSON
upload endpoint. Since this is brand new, we have a (somewhat rare) opportunity
to define the format more strictly.
I think it's important that upload
mmd-osm left a comment (openstreetmap/openstreetmap-website#5973)
They could in theory, but the xml format today doesn't have any assumptions in
that direction. Processing happens from top to bottom in the exact sequence
defined in xml, and you're free to do pretty much whatever you like in term
k-yle left a comment (openstreetmap/openstreetmap-website#5973)
> Now for the upload, you might have multiple create/modify/delete blocks in
> random order, including repeating blocks for the same action. How would this
> work with your proposed format?
If I understand you correctly, you're ref
mmd-osm left a comment (openstreetmap/openstreetmap-website#5973)
> In my opinion, this format is better because: …
Now for the upload, you might have multiple create/modify/delete blocks in
random order, including repeating blocks for the same action. How would this
work with your proposed for
@k-yle commented on this pull request.
> @@ -0,0 +1,7 @@
+json.partial! "api/root_attributes"
+
+json.osmChange do
+ json.create @created.map { |elt| JSON.parse(render(partial:
"api/#{elt.to_partial_path}", object: elt)) }
+ json.modify @modified.map { |elt| JSON.parse(render(partial:
"api/#
@hlfan commented on this pull request.
> @@ -0,0 +1,7 @@
+json.partial! "api/root_attributes"
+
+json.osmChange do
+ json.create @created.map { |elt| JSON.parse(render(partial:
"api/#{elt.to_partial_path}", object: elt)) }
+ json.modify @modified.map { |elt| JSON.parse(render(partial:
"api/#
@k-yle pushed 1 commit.
4a83726780112a29e01e4d061ad5e8b1bba1580c Implement JSON support for the
changeset download API
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5973/files/097c347442e60ac971f5f4c95b136341c2c06db3..4a83726780112a29e01e4d061ad5e8b1bba1580c
Closes #5970
### Description
Created a new endpoint `/changeset/:id/download.json` which returns the
`osmChange` in a JSON format in addition to the existing XML endpoint.
For example:
```jsonc
{
"version": "0.6",
"generator": "OpenStreetMap server",
"copyright": "OpenStreetMap and contri
30 matches
Mail list logo
