mmd-osm left a comment (openstreetmap/openstreetmap-website#5970)
I would start in this repo with a json version of
app/views/api/changesets/downloads/show.xml.builder, then add some test cases.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetma
Fixes #5971.
`user.js` does too many different things. It's better to take it apart and
have smaller scripts included from all of the pages that currently include it.
This PR takes out dashboard-specific code from `user.js` and puth it into
`dashboard.js`. This code doesn't include OSM.HomeLoca
AntonKhorev left a comment (openstreetmap/openstreetmap-website#1747)
Was reimplemented in #5915.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1747#issuecomment-2844081598
You are receiving this because you are subscribed to th
Closed #1747.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1747#event-17483721853
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
@AntonKhorev pushed 5 commits.
704e1e9dbb27e45975bb3d88b1de21ad1df6084e Create changeset upload resource
794fb3e3a78ee7d3ae66f9c64d1f389a3ee06084 Remove unnecessary RuboCop exclusions
9ca1d7cd21071d9cef4b5da41329df256a6a0248 Move changeset upload route test
531c6f90d9db4cd9878c89c5469fecadd058f
@AntonKhorev pushed 11 commits.
5425578700fd18bb6fe8511d97f677ca4bf3b762 Simplify toggleChangesetHighlight
71632ff33eb370fbc4fd9b355f309129e00cc55d Collect bbox layers
835608a3aa6dacf80fb0a35064941450d604a9e3 Create HistoryChangesetBboxLayer
parent class
755d108e1aac722c2f2f1971d5ff4bf1e7569ac
@hlfan pushed 1 commit.
f2f99dfb15db93d2bd42848ab8aee990d42940c1 Remove controls sprite
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5752/files/1067440bee947d93ffddd42ee5711280abd663a7..f2f99dfb15db93d2bd42848ab8aee990d42940c1
You are receiving this because
@hlfan pushed 3 commits.
805a17859c1c05fc85df552d055a5a0c7bd4f0fc Click links instead of icons in tests
ae0ba462f5ac71feac7eebab973c9d46d55fd59f Unify active control button behaviour
1067440bee947d93ffddd42ee5711280abd663a7 Remove controls sprite
--
View it on GitHub:
https://github.com/opens
hlfan created an issue (openstreetmap/openstreetmap-website#5971)
### URL
https://www.openstreetmap.org/dashboard
### How to reproduce the issue?
With a location set for the current user, load the page
### Screenshot(s) or anything else?
Uncaught TypeError: Cannot read properties of undefined
k-yle left a comment (openstreetmap/openstreetmap-website#5970)
would it make sense to implement it here first, and then port it to cgimap? I
assume that the idealistic outcome is an identical implementation in ruby and
c++
--
Reply to this email directly or view it on GitHub:
https://github.c
@hlfan commented on this pull request.
> +.directions_form {
+ div {
+align-items: center;
+grid-template-columns: 1fr auto;
+ }
+}
+
I've tried to build this grid layout with display flex (in the `d-flex` and
`row`/`col` flavours).
In neither can I get the close button to be in just
@hlfan pushed 5 commits.
a6e5460d01432a049d0be28b802546618637a235 Prevent aborted requests from logging
as errors
0d75562594edddb2a981ecb195418913cb412a83 Move routing settings before endpoint
fields
6108146a24d8b843a479be7c03fc836ff6368078 Hide submit button after reverse
directions button
tomhughes left a comment (openstreetmap/openstreetmap-website#5967)
This looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5967#issuecomment-2842884428
You are receiving this because you are subscribed to t
Merged #5915 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5915#event-17477964853
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5967 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5967#event-17477964811
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes approved this pull request.
Thanks for the work on this... I think it looks good to merge now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5915#pullrequestreview-2807998341
You are receiving this because you are s
Merged #5963 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5963#event-17477390710
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5965 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5965#event-17477390671
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5969 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5969#event-17477390676
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5965)
Looks good to me and as you say any change to the semantics is a larger issue
that would need to be discussed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/59
tomhughes left a comment (openstreetmap/openstreetmap-website#5969)
Looks fine to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5969#issuecomment-2842721840
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5963)
This looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5963#issuecomment-2842701161
You are receiving this because you are subscribed to t
@tomhughes commented on this pull request.
> this._highlightLayer.clearLayers();
for (const changeset of this._changesets.values()) {
- const rect = L.rectangle(changeset.bounds,
this._getInteractiveStyle(changeset));
+ const rect = L.rectangle(changeset.bounds,
this._get
mmd-osm left a comment (openstreetmap/openstreetmap-website#5970)
Changeset download in XML format is currently being served by
https://github.com/zerebubuth/openstreetmap-cgimap. That's where the productive
implementation for JSON format would have to go as well.
--
Reply to this email direct
hlfan left a comment (openstreetmap/openstreetmap-website#5967)
I'm not in charge of deciding if that has to wait, but I don't see any big
conflicts between the two PRs.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5967#issuec
@hlfan commented on this pull request.
On app/assets/stylesheets/common.scss:
Yeah, but I'm talking about the current state - when you change the colors
later this outdated comment will be collapsed anyway.
Until then I'm still behind this suggestion, another nesting layer would then
still ma
@AntonKhorev pushed 1 commit.
d31ceaefe99ea0520cb10e062407a0900840e82b Test diffResult in api changeset
test_upload_modify_elements
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5590/files/b0a2e12dba383e37fdb3f4967a4058baaea5611a..d31ceaefe99ea0520cb10e06240
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#5590)
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Gener
@AntonKhorev pushed 1 commit.
b0a2e12dba383e37fdb3f4967a4058baaea5611a Split and move api changeset
test_upload_simple_valid
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5590/files/64331ea771e101174cc60634243dc5be32b76650..b0a2e12dba383e37fdb3f4967a4058baae
k-yle left a comment (openstreetmap/openstreetmap-website#5970)
true, but it doesn't work in nodejs, so you can't reuse the same code in the
browser and node.
It's also extremely cumbersome to parse and generate xml, and you lose all the
typesafety benefits from the JS/TS ecosystem
--
Reply
@AntonKhorev commented on this pull request.
> +.directions_form {
+ div {
+align-items: center;
+grid-template-columns: 1fr auto;
+ }
+}
+
Imagine @gravitystorm appearing here and telling all of what he told in #3620
about *custom grid*.
--
Reply to this email directly or view it
@AntonKhorev commented on this pull request.
On app/assets/stylesheets/common.scss:
Have you thought that I might change the colors later?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5964#discussion_r2068774443
You are rece
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5967)
You're not going to wait for #5915, right?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5967#issuecomment-2842150072
You are receiving this because you are s
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5970)
Browsers can parse both xml and json natively.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5970#issuecomment-2842133378
You are receiving this because you
k-yle left a comment (openstreetmap/openstreetmap-website#3501)
I opened #5970 specifically for JSON support for downloading changesets. I'm
happy to attempt a PR if this idea is welcome
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website
k-yle created an issue (openstreetmap/openstreetmap-website#5970)
### Problem
- **As a** developer of web-based tools,
- **I want** to avoid bundling a massive xml-parsing library just for a single
API endpoint (since almost all others support JSON now)
- **so that** the page loads faster, we a
The destructuring of parseHash.center makes using parseHash more unwieldy.
Adding these parameters separately allows for easier integration elsewhere.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5969
-- Commit Summ
@hlfan pushed 1 commit.
251ab6891201b42889c4748e00c856d2d0d10af7 Fix routing mode selection in
directions test
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5960/files/ca36cd7683f0875ac7fa2da0fe5df1f18e0a3f65..251ab6891201b42889c4748e00c856d2d0d10af7
You are
For the geoURI handling to be available more broadly, on the first hover over
the geoURI link of a session, try to register the handler. If not accepted, try
again only in the next session.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstr
@hlfan pushed 5 commits.
4f9a4fbac20e58dd9e758b979e30cb37b47d2c29 Prevent aborted requests from logging
as errors
5cce9845270f290c93ace5d32c893899596ec921 Move routing settings before endpoint
fields
e55a9c4d0c53f2b1833e7bb3ed9160791b8b61d3 Hide submit button after reverse
directions button
@hlfan pushed 1 commit.
ca36cd7683f0875ac7fa2da0fe5df1f18e0a3f65 Fix routing mode selection in
directions test
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5960/files/7c3c2ff6f4bc9cddf28952108f0c4f6bbde07bfd..ca36cd7683f0875ac7fa2da0fe5df1f18e0a3f65
You are
#5961's fix to #5959 was to delay starting the route request until the
sidebar loaded, which isn't needed.
With this fix to #5959, I'm merging the page's pushstate/popstate with
load and pulling out the sidebar requirement into a helper function also used
in getRoute after the request, enabling
@hlfan commented on this pull request.
On app/assets/stylesheets/common.scss:
Have you thought about a general changeset class so you don't need to define
the outline color thrice and the fill color twice with the same color?
--
Reply to this email directly or view it on GitHub:
https://gith
43 matches
Mail list logo
