tomhughes left a comment (openstreetmap/openstreetmap-website#5966)
In other words GPLv2 as documented in
https://github.com/openstreetmap/openstreetmap-website/blob/master/LICENSE.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issu
tomhughes left a comment (openstreetmap/openstreetmap-website#5966)
Do you have some reason to think it's license is different to the rest of the
repository?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5966#issuecomment-284
mmd-osm left a comment (openstreetmap/openstreetmap-website#5965)
In case you’re changing something regarding this endpoint, can you also create
an issue for cgimap as well? I can’t commit this will be picked up in the near
future, but at least it should be documented.
--
Reply to this email d
@AntonKhorev pushed 11 commits.
55ee5a481d1f6c52edb1eb45c1e6e67c650fedd6 Create api changeset close resource
and controller
649cb1f915b04fc76f9e11a3c18dac4821b72b0b Move api changeset close tests to
their own module
6c6f4fd8e1eb6beee41ecd6c37cd65c070c0ded9 Split api changeset close test_updat
@AntonKhorev pushed 1 commit.
198405dd5ebe78fea094c81fe6d90768c2b6c8ab Test closing changeset twice
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5965/files/0931221d2ac201e2ee02be78821d264aafa66d51..198405dd5ebe78fea094c81fe6d90768c2b6c8ab
You are receiving t
angoca created an issue (openstreetmap/openstreetmap-website#5966)
### Problem
I would like to know the license of the images in the website, specifically the
planet during the registration.
I asked the same in communities:
https://community.openstreetmap.org/t/what-is-the-license-for-the-imag
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5965
-- Commit Summary --
* Create api changeset close resource and controller
* Move api changeset close tests to their own module
* Split api changeset close tes
@AntonKhorev pushed 4 commits.
ce237e5d7af3a8bf8c3bb5ab307f2272941db0ed Make api close changeset path
resourceful
324c3a0980e02e9fa8309f69e60c18308ecb19d3 Create changeset upload resource
6d0792758b9cb57ac97d63a857e3a32075ceeb53 Remove unnecessary RuboCop exclusions
c90d9ba05e47c1859c7495f5210
@AntonKhorev pushed 10 commits.
b144b1463d56e3126252dcfcbc098373f928ee33 Collect bbox layers
b6bdbed9fb37fc2e4d980f4892d2866243912eed Create HistoryChangesetBboxLayer
parent class
0cbd3a1d65c1669c1050fd3ec32a82d7d43811b4 Move getLayerId to
HistoryChangesetBboxLayer
b524ce125b5d1977dab9f7fb707
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5963)
@hlfan see #5964
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5963#issuecomment-2840503029
You are receiving this because you are subscribed to this thread.
@AntonKhorev commented on this pull request.
> this._highlightLayer.clearLayers();
for (const changeset of this._changesets.values()) {
- const rect = L.rectangle(changeset.bounds,
this._getInteractiveStyle(changeset));
+ const rect = L.rectangle(changeset.bounds,
this._g
@AntonKhorev pushed 9 commits.
7d8cfff149d3b0184c58f6b3c1b8a697105a2dc2 Simplify toggleChangesetHighlight
9a9f5b87274b1e5c79a6bc1fd7790ff108cbd0cf Create HistoryChangesetBboxLayer
parent class
616e2a72986adf78d27279a3affb07dba00d8e85 Move getLayerId to
HistoryChangesetBboxLayer
b31fa31c2945e2
@tomhughes commented on this pull request.
> this._highlightLayer.clearLayers();
for (const changeset of this._changesets.values()) {
- const rect = L.rectangle(changeset.bounds,
this._getInteractiveStyle(changeset));
+ const rect = L.rectangle(changeset.bounds,
this._get
@hlfan requested changes on this pull request.
> this._highlightLayer.clearLayers();
for (const changeset of this._changesets.values()) {
- const rect = L.rectangle(changeset.bounds,
this._getInteractiveStyle(changeset));
+ const rect = L.rectangle(changeset.bounds,
this.
@AntonKhorev commented on this pull request.
> this._highlightLayer.clearLayers();
for (const changeset of this._changesets.values()) {
- const rect = L.rectangle(changeset.bounds,
this._getInteractiveStyle(changeset));
+ const rect = L.rectangle(changeset.bounds,
this._g
hlfan left a comment (openstreetmap/openstreetmap-website#5960)
Is there a function like `click_on` that I can call by class name instead of by
text content?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5960#issuecomment-28399
@tomhughes requested changes on this pull request.
There's some sort of race condition in the new test here that causes it to
sometimes pass and sometimes fail.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5960#pullrequestre
tomhughes left a comment (openstreetmap/openstreetmap-website#5906)
Just to add of course CSP warnings can be resolved but we're not going to be
allowing inline script so I'd need to know where that is coming from exactly to
know what me might do abut it.
It also looks like it was trying to loa
@tomhughes requested changes on this pull request.
This needs some sort of rebasing because the third commit seems to remove stuff
that was added by the first commit...
I don't know if it just needs to be one commit or if there's some sensible way
to structure it into multiple commits but right
Merged #5961 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5961#event-17459921595
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5962 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5962#event-17459921607
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5959 as completed via #5961.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5959#event-17459921858
You are receiving this because you are subscribed to this thread.
Message ID:
_
@tomhughes commented on this pull request.
> this._highlightLayer.clearLayers();
for (const changeset of this._changesets.values()) {
- const rect = L.rectangle(changeset.bounds,
this._getInteractiveStyle(changeset));
+ const rect = L.rectangle(changeset.bounds,
this._get
tomhughes left a comment (openstreetmap/openstreetmap-website#5962)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5962#issuecomment-2839656308
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5961)
Thanks. This looks good to me then.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5961#issuecomment-2839653938
You are receiving this because you are subscribed
The next step if #5963 is merged.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5964
-- Commit Summary --
* Split interact
The goal is to have the following z-order:
1. areas of changeset bboxes outside the sidebar viewport
2. areas of changeset bboxes inside the sidebar viewport
3. borders of changeset bboxes outside the sidebar viewport
4. borders of changeset bboxes inside the sidebar viewport
You can view, comment
petr-hajek left a comment (openstreetmap/openstreetmap-website#4042)
> > Yes, I confirm that. Many thanks @zdila to push this PR.
> > We may take over it.
>
> Are you planning on taking over this PR? I have some work that will build on
> it, but I want to figure out what order to do the work in.
@nenad-vujicic approved this pull request.
This looks and works great on my side! Good catch, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5962#pullrequestreview-2803049030
You are receiving this because you are subsc
kcne left a comment (openstreetmap/openstreetmap-website#5906)
I updated the code to manually render the labels in order to eliminate CSP
warnings and remove the need for extra plugins. Please let me know if you
prefer this manual approach or would rather stick with the plugin.
The main advant
@kcne pushed 1 commit.
376ff6c54a68848726fdc0e3d08dff64e39924fd Do month and week label rendering
manually - remove CalendarLabel plugin
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5906/files/903b1e1f06a23e069f0942245a382b81028f62a9..376ff6c54a68848726fdc0
31 matches
Mail list logo
