[openstreetmap/openstreetmap-website] Limit number of directions endpoint geocoding results to 1 (PR #5962)

2025-04-28 Thread Anton Khorev via rails-dev
Geocoding for route endpoints requests the default number of results, which is 10, but only uses the first one. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5962 -- Commit Summary -- * Limit number of directions

Re: [openstreetmap/openstreetmap-website] Change colors of changeset bboxes when they enter/exit the viewport (PR #5924)

2025-04-28 Thread DesertBear via rails-dev
DesertBear left a comment (openstreetmap/openstreetmap-website#5924) Sorry, but this change is terrible. I check my local area (35×35 miles) daily for changes. This involves panning the area and then clicking on new changeset bounding boxes. In a populated area, this can be quite a few change

Re: [openstreetmap/openstreetmap-website] Fix outputting route before directions sidebar is loaded (PR #5961)

2025-04-28 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > - map.setSidebarOverlaid(!endpoints[0].latlng || !endpoints[1].latlng); -} +map.setSidebarOverlaid(!endpoints[0].latlng || !endpoints[1].latlng); Yes, it's still needed. 1. Reload the map view to make sure that the directions sideba

Re: [openstreetmap/openstreetmap-website] Fix outputting route before directions sidebar is loaded (PR #5961)

2025-04-28 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > - map.setSidebarOverlaid(!endpoints[0].latlng || !endpoints[1].latlng); -} +map.setSidebarOverlaid(!endpoints[0].latlng || !endpoints[1].latlng); And after that `OSM.loadSidebarContent` resets it. `map.setSidebarOverlaid` is here to

Re: [openstreetmap/openstreetmap-website] Fix outputting route before directions sidebar is loaded (PR #5961)

2025-04-28 Thread Tom Hughes via rails-dev
@tomhughes commented on this pull request. > - map.setSidebarOverlaid(!endpoints[0].latlng || !endpoints[1].latlng); -} +map.setSidebarOverlaid(!endpoints[0].latlng || !endpoints[1].latlng); Is this still needed now that we always call `page.load` and it does the same thing? --

Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)

2025-04-28 Thread Paul Norman via rails-dev
pnorman left a comment (openstreetmap/openstreetmap-website#4042) > Yes, I confirm that. Many thanks @zdila to push this PR. > > We may take over it. Are you planning on taking over this PR? I have some work that will build on it, but I want to figure out what order to do the work in. -- Repl

Re: [openstreetmap/openstreetmap-website] Fix outputting route before directions sidebar is loaded (PR #5961)

2025-04-28 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5961) > Could this be done in a way that keeps the requests concurrent and only waits > for the sidebar when needing to write to it? The correct question is the above + *and doesn't make the fix more complicated* + *and not causing

Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)

2025-04-28 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 3 commits. cf7bca1b565cc6118ea6c6868908165cc667e4bd Create changeset upload resource 5559c237028afe989f0852905403e99f92965949 Remove unnecessary RuboCop exclusions 5bbcf1f508bb537924817236bd9c9248e92ad6b2 Move changeset upload route test -- View it on GitHub: https://githu

Re: [openstreetmap/openstreetmap-website] Fix outputting route before directions sidebar is loaded (PR #5961)

2025-04-28 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#5961) Could this be done in a way that keeps the requests concurrent and only waits for the sidebar when needing to write to it? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website

Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)

2025-04-28 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. 3d3fca66344718b7f05b7c5280ca2f7c4c0d5d6f Make api close changeset path resourceful -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5590/files/bfa7074ed775f941269e10d3cdf8539b16cde901..3d3fca66344718b7f05b7c5280ca2f7c4c0d5d6f You a

Re: [openstreetmap/openstreetmap-website] Add profile location (bafaf78)

2025-04-28 Thread Anton Khorev via rails-dev
But such cases should fail in tests. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/commit/bafaf78c7de4e8a224e1957f5b7c3f054ad05211#r155986068 You are receiving this because you are subscribed to this thread. Message ID:

Re: [openstreetmap/openstreetmap-website] Add profile location (bafaf78)

2025-04-28 Thread Tom Hughes via rails-dev
I think so yes... Rails is a bit too clever for it's own good and fakes up `Home location name` in the UI from the field name by removing the underscores and capitalising the first word making it not at all obvious that there is a missing translation! -- Reply to this email directly or view it

Re: [openstreetmap/openstreetmap-website] Add profile location (bafaf78)

2025-04-28 Thread Petr Kadlec via rails-dev
This seems to be missing localization? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/commit/bafaf78c7de4e8a224e1957f5b7c3f054ad05211#r155982134 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Adds note versions and variable note tags (PR #5904)

2025-04-28 Thread Nenad Vujicic via rails-dev
nenad-vujicic left a comment (openstreetmap/openstreetmap-website#5904) Updated PR to display how notes versioning, removing special note comments (ones with non-present body which are not "commented"), `event` column from `note_comments` and versioned variable note tags could look like. -- Re

Re: [openstreetmap/openstreetmap-website] Adds note versions and variable note tags (PR #5904)

2025-04-28 Thread Nenad Vujicic via rails-dev
@nenad-vujicic pushed 23 commits. 77d7d4d226a9b383be7f0db4275bf45e59189214 Adds note versioning and adds note_versions table 222b1469579312a5a95fca23c6bb930897f8b3cd Adds from_* and save_*! methods to notes b55512db48296856ac461bd360ebfaad16ac9055 Adds using from_* and save_*! methods 1325312

Re: [openstreetmap/openstreetmap-website] restore in-progress comments after restoring a closed browser tab (Issue #5624)

2025-04-28 Thread Andrew Harvey via rails-dev
andrewharvey left a comment (openstreetmap/openstreetmap-website#5624) It's also very easy to happen by simply starting a comment, then clicking on a linked object within the changeset, and suddenly you loose your comment. -- Reply to this email directly or view it on GitHub: https://github.com