@AntonKhorev pushed 2 commits.
e6b25effed79d6a7a318e71df038cac6b149a029 Show referer link in already logged
in warning
86488522b66d64eb27f6c9fd164a1deed4e09895 Preserve anchor in referer link
inside warning
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/595
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5956)
This looks like a different info for each engine.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5956#issuecomment-2833142795
You are receiving this because
@AntonKhorev pushed 1 commit.
90931cb1846e2a956597c1d9c26e277e86f96762 Preserve anchor in referer link
inside warning
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5957/files/cdb27bebc19f674603e9ac38205e4e0d0ae95f08..90931cb1846e2a956597c1d9c26e277e86f96762
@AntonKhorev commented on this pull request.
> $("#referer").val($("#referer").val() + location.hash);
+$("#referer_link").prop("href", $("#referer_link").prop("href") +
location.hash);
`$("#referer_link")[0].hash = location.hash;` requires the link to exist and
we're not checking th
@AntonKhorev pushed 2 commits.
595281f82f156e7eba30f7730a60e844ede7b8c8 Show referer link in already logged
in warning
cdb27bebc19f674603e9ac38205e4e0d0ae95f08 Preserve anchor in referer link
inside warning
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/595
@AntonKhorev pushed 5 commits.
9eee576d0f9968b4e0e62078e9456978a841abce Rename integration login test
f6107c62db1d4eb32f7692dcfc141ad89c51880a Move OpenID button test to user login
tests
7b5ea31310791886a430243b3361757f6e4af46b Warn on login page if already logged
in
f00d5089e9c944e8733a9d380
hlfan left a comment (openstreetmap/openstreetmap-website#5736)
> I couldn't get it fully working
probably because of the [still very low browser
compatibility](https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/Manifest/Reference/protocol_handlers#browser_compatibility).
Given it
@hlfan commented on this pull request.
> $("#referer").val($("#referer").val() + location.hash);
+$("#referer_link").prop("href", $("#referer_link").prop("href") +
location.hash);
The insistence on using jQuery reduces the legibility:
``` suggestion
$("#referer")[0].value += locat
Fixes #5441 by showing a warning as described in
https://github.com/openstreetmap/openstreetmap-website/issues/5441#issuecomment-2563121432.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5957
-- Commit Summary --
hlfan created an issue (openstreetmap/openstreetmap-website#5958)
### Problem
When checking that the website behaves correctly, I don't have an easy way to
tell whether a feature from the repository is already live.
### Description
If precompiled assets included a `Last-Modified` header, I cou
Addresses a concern from #3123 about the routing engine providers not being
labeled.
|
|
|
![image](https://githu
The system test from #5302 sometimes fails:
```
Failure:
UserLocationChangeTest#test_User_can_change_their_location
[test/system/user_location_change_test.rb:20]:
expected to find text "Test Location" in
"OpenStreetMap\nEdit\nHistory\nExport\nGPS Traces\nUser
Diaries\nCommunities\nCopyright\nHel
@AntonKhorev commented on this pull request.
> @@ -82,6 +82,18 @@ time[title] {
100% { opacity: 1 }
}
+/* Bootstrap close button overrides for nested light/dark themes */
But the overrides are for close button. If they affect anything else, that's
not intentional.
--
Reply to this emai
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5937)
Merged, thanks.
I don't think we use `to_time` directly.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5937#issuecomment-2832331995
You are receiving this be
Merged #5937 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5937#event-17417117872
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@hlfan approved this pull request.
> @@ -82,6 +82,18 @@ time[title] {
100% { opacity: 1 }
}
+/* Bootstrap close button overrides for nested light/dark themes */
```suggestion
/* Bootstrap overrides for nested light/dark themes */
```
--
Reply to this email directly or view it on GitHub:
@AntonKhorev pushed 1 commit.
29e3533a460a64464fecfff6612226f2af39422f Update fix for close button inside
themed elements
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5952/files/0c75728832a621e8a5fe8bd13b5e9f4381410d64..29e3533a460a64464fecfff6612226f2af394
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5954)
https://github.com/openstreetmap/operations is the right place for this report
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5954#issuecomment-2832271181
jidanni left a comment (openstreetmap/openstreetmap-website#5954)
I see. They are updating the wiki, and I hit it during the vulnerable
microseconds.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5954#issuecomment-2832274141
Closed #5954 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5954#event-17416787514
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
jidanni created an issue (openstreetmap/openstreetmap-website#5954)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5954
You are receiving this because you are subscribed to this thread.
Message ID: ___
@hlfan requested changes on this pull request.
Ok this implementation makes it way more clear where this is needed.
But setting `--bs-btn-close-filter` means you don't have to target `.btn-close`
anymore.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/o
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5953#pullrequestreview-2795824804
You are receiving this because you are subscribed to this thread.
Message ID:
__
I don't think the svg icon added in #5735 ever worked.
Before:
See that the path is wrong.
After:
