AntonKhorev left a comment (openstreetmap/openstreetmap-website#5736)
I'm merging this but I couldn't get it fully working, as well as pwas with
protocol handler.
It should work in Chromium on Linux, the browser sees that the pwa has the
protocol handler:
 {
+if (typeof geoURI !== "string") return;
+let url;
+try {
+ url = new URL(geoURI.toLowerCase());
+} catch (e) { return; }
+if (u
Update the close button light/dark theme fix from #4761 after Bootstrap v5.3.4
broke it.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5952
-- Commit Summary --
* Revert "Remove unneeded and broken bootstrap close
Merged #5951 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5951#event-17410377240
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5951)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5951#issuecomment-2831096638
You are receiving this because you are subscribed to this t
Closed #5947 as completed via #5951.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5947#event-17410377508
You are receiving this because you are subscribed to this thread.
Message ID:
_
@hlfan pushed 3 commits.
aa89366ded46bae404475afc9cfeeba3d027c5d5 Add parseGeoURI function and tests
d2e03330a9b8bfba6f84c7b7464b888026ccdb3f Add support for marker radius in map
parameters
090c9da0a2d06e05dd07d756773be96a955d695c Add PWA geo protocol handler
--
View it on GitHub:
https://gi
@hlfan commented on this pull request.
> @@ -121,6 +135,30 @@ OSM = {
return mapParams;
},
+ parseGeoURI: function (geoURI) {
+if (typeof geoURI !== "string") return;
+let url;
+try {
+ url = new URL(geoURI.toLowerCase());
+} catch (e) { return; }
+if (url.pro
Merged #5948 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5948#event-17409227147
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
hlfan left a comment (openstreetmap/openstreetmap-website#5949)
Yay, my fix for my breaking of the locator compass landed!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5949#issuecomment-2830992809
You are receiving this because
### Description
Fixes #5947 by removing the broken reference to `--bs-btn-close-white-filter`
and also the `filter: none` because both are already taken care of by
Bootstrap's definition of `--bs-btn-close-filter`.
### How has this been tested?
dev tools
You can view, comment on, or merge this p
Merged #5302 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302#event-17409438001
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5302)
I think this is looking good now - thanks for all the work on it!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302#issuecomment-2830921005
You are receiving t
Merged #5949 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5949#event-17409227119
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
1ec5 left a comment (openstreetmap/openstreetmap-website#5950)
Yes, I’m looking into starting a series of posts on the forum periodically
highlighting noteworthy changes as they go in, similar to what I’ve been doing
for OpenHistoricalMap. These won’t technically be release notes, since this
pr
mjourdan left a comment (openstreetmap/openstreetmap-website#3123)
Thanks @hlfan and @AntonKhorev, I updated the mockups according to your remarks.
--
Reply to this email directly or view it on GitHub:
htt
@Zverik commented on this pull request.
> @@ -121,6 +135,30 @@ OSM = {
return mapParams;
},
+ parseGeoURI: function (geoURI) {
+if (typeof geoURI !== "string") return;
+let url;
+try {
+ url = new URL(geoURI.toLowerCase());
+} catch (e) { return; }
+if (url.pr
@AntonKhorev commented on this pull request.
> @@ -121,6 +135,30 @@ OSM = {
return mapParams;
},
+ parseGeoURI: function (geoURI) {
+if (typeof geoURI !== "string") return;
+let url;
+try {
+ url = new URL(geoURI.toLowerCase());
+} catch (e) { return; }
+if (u
@nertc pushed 1 commit.
bafaf78c7de4e8a224e1957f5b7c3f054ad05211 Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/491091b70e618b5c49df7a62f28738ae658a0fa6..bafaf78c7de4e8a224e1957f5b7c3f054ad05211
You are receiving this because yo
etienneJr left a comment (openstreetmap/openstreetmap-website#5934)
> globally? by given IP address?
I propose to use the cookie `_osm_anonymous_notes_count` introduced
[here](https://github.com/etienneJr/openstreetmap-website/blob/0f2df0b9efcfff1d6bb0f7b2d16fa23f85d8708d/app/assets/javascripts/
@kcne pushed 1 commit.
31b6bf6c90f8a02fdf369add69669b1ebc7b4b8d Do month and week label rendering
manually - remove CalendarLabel plugin"
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5906/files/37c9b3ed97bd7904cb3d0d47390ffcc31a2963c8..31b6bf6c90f8a02fdf369
tomhughes left a comment (openstreetmap/openstreetmap-website#5950)
I know @1ec5 has plans to start publicising some of the more significant
changes but it's not going to take this form.
I would dispute the claim that 99.99% of FOSS projects work like that anyway -
there are a wide variety of d
Closed #5950 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5950#event-17406172425
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
@hlfan pushed 3 commits.
48408ca4395f8c2db06c82d2f7dca085bf24fba4 Add parseGeoURI function and tests
6cf81e88e063d3a7ff47837cbf8c0cc6be3cd6e6 Add support for marker radius in map
parameters
d9adf46bece2091803f8c9ad56063527946c2c70 Add PWA geo protocol handler
--
View it on GitHub:
https://gi
@hlfan commented on this pull request.
> @@ -121,6 +135,27 @@ OSM = {
return mapParams;
},
+ parseGeoURI: function (geoURI) {
+if (!geoURI || !URL.canParse(geoURI)) return;
+const url = new URL(geoURI);
+if (url.protocol !== "geo:" || !url.pathname) return;
+const [pat
opk12 left a comment (openstreetmap/openstreetmap-website#5950)
Ah, to be clear, it's not a duplicate of the git history, the 99.99% of the
volunteer FOSS projects provides a 1-line summary + link to PR, for the
user-visible changes.
I think that [continuous
integration](https://en.wikipedia.o
mmd-osm left a comment (openstreetmap/openstreetmap-website#3107)
The two screenshots I posted initially were based on a similar approach
(obviously without using chatgpt back then). The main goal was to declare the
API structure, in order to extract it as OpenAPI format (OAS3) later on.
I have
tomhughes left a comment (openstreetmap/openstreetmap-website#5950)
Plus we don't do releases, we just deploy continually - usually multiple times
a week and sometimes multiple times a day!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-webs
matkoniecz left a comment (openstreetmap/openstreetmap-website#5934)
> after, let's say, 100 anonymous notes have already been posted?
globally? by given IP address?
> He does not reply to our messages on these notes
only users can comment on notes
> Following PR
> https://github.com/openstre
matkoniecz left a comment (openstreetmap/openstreetmap-website#5950)
are you volunteering for maintaining it?
given quite scarce development resources it would probably better to spend them
on reviewing 100+ waiting PRs (or fixing PRs based on reviews that were made)
--
Reply to this email dir
opk12 created an issue (openstreetmap/openstreetmap-website#5950)
### Problem
What about having a proper changelog? Standard software development practice is
to mark a version as a `tag` or a `release` and fully describe new features and
changes under the relevant entry found
[here](https://gi
@hlfan commented on this pull request.
> @@ -121,6 +135,27 @@ OSM = {
return mapParams;
},
+ parseGeoURI: function (geoURI) {
+if (!geoURI || !URL.canParse(geoURI)) return;
+const url = new URL(geoURI);
+if (url.protocol !== "geo:" || !url.pathname) return;
+const [pat
HarelM left a comment (openstreetmap/openstreetmap-website#5639)
I'm not sure this is a different problem or not, but I'm also unable to get the
trace's icon using Oauth2 header, i.e:
https://www.openstreetmap.org/user/Harel%20M/traces/11959548/icon
With the header of Authorization: Bearer .
I d
33 matches
Mail list logo
