Re: [openstreetmap/openstreetmap-website] Changeset highlights in a layer on top of normal bboxes (PR #5940)

2025-04-20 Thread rkoeze via rails-dev
@rkoeze approved this pull request. Looks good to me 👍 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5940#pullrequestreview-2780375556 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

2025-04-20 Thread Marwin Hochfelsner via rails-dev
@hlfan commented on this pull request. > +<%= t ".how_to_help.add_a_note.instructions_1_html", :note_icon => > tag.a(render(:partial => "layouts/note_icon"), + :class => "icon note", I meant a central definitio

Re: [openstreetmap/openstreetmap-website] Add kilometers/miles switch to directions (PR #5915)

2025-04-20 Thread Marwin Hochfelsner via rails-dev
@hlfan commented on this pull request. > + let distanceUnits = "km"; let downloadURL = null; - function formatTotalDistance(m) { -if (m < 1000) { - return OSM.i18n.t("javascripts.directions.distance_m", { distance: Math.round(m) }); -} else if (m < 1) { - return OSM

Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

2025-04-20 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > +<%= t ".how_to_help.add_a_note.instructions_1_html", :note_icon => > tag.a(render(:partial => "layouts/note_icon"), + :class => "icon note", > But while https://g

Re: [openstreetmap/openstreetmap-website] blocks with needs_view flag not shown when user does oauth authorisation (for example login into an OSM editor) (Issue #5490)

2025-04-20 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5490) > what do you think of > https://github.com/openstreetmap/openstreetmap-website/issues/5490#issuecomment-2602015806 Depends on if it proposes to abandon the currently used redirects to block pages or not. I'd personally not d

Re: [openstreetmap/openstreetmap-website] Search and latlon/nominatim query resources (PR #5868)

2025-04-20 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. 8bb894f3beb9acce6739a4f9efa8997860b6b54a Rename "OSM Nominatim" to "Nominatim" in search headings -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5868/files/39134a487f24f809158c37d0651bdbd7bcf92cb0..8bb894f3beb9acce6739a4f9efa8997

Re: [openstreetmap/openstreetmap-website] Search and latlon/nominatim query resources (PR #5868)

2025-04-20 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. 39134a487f24f809158c37d0651bdbd7bcf92cb0 Rename "OSM Nominatim" to "Nominatim" in search headings -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5868/files/2f37d06b9d66e1850b948f2bc60b0bb5b411fd64..39134a487f24f809158c37d0651bdbd

Re: [openstreetmap/openstreetmap-website] Search and latlon/nominatim query resources (PR #5868)

2025-04-20 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5868) Removed `osm_` and *OpenStreetMap* from results headings too: ![image](https://github.com/user-attachments/assets/1029c47a-fb2f-489d-8487-f61f9c1f0192) -- Reply to this email directly or view it on GitHub: https://github.com/

Re: [openstreetmap/openstreetmap-website] Search and latlon/nominatim query resources (PR #5868)

2025-04-20 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. 2f37d06b9d66e1850b948f2bc60b0bb5b411fd64 Rename "OSM Nominatim" to "Nominatim" in search headings -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5868/files/6f071c135265d22028b0326bdff78ac3d1f41edf..2f37d06b9d66e1850b948f2bc60b0bb

Re: [openstreetmap/openstreetmap-website] Search and latlon/nominatim query resources (PR #5868)

2025-04-20 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 11 commits. 8e29c117259920af5c0828e205ca30a2a9994193 Remove RuboCop AssignmentInCondition exclusion for search 26a0370808952b8408fab5c379d075c264c0ac54 Merge search params with regexp captures property d4fedb66dd74e0c8e1d2196c0c37eca90fd075c1 Remove escape_query method fro

Re: [openstreetmap/openstreetmap-website] Add kilometers/miles switch to directions (PR #5915)

2025-04-20 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > + let distanceUnits = "km"; let downloadURL = null; - function formatTotalDistance(m) { -if (m < 1000) { - return OSM.i18n.t("javascripts.directions.distance_m", { distance: Math.round(m) }); -} else if (m < 1) { - retu

Re: [openstreetmap/openstreetmap-website] Arm in registration globe was deleted (Issue #5941)

2025-04-20 Thread Tom Hughes via rails-dev
Closed #5941 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5941#event-17331016673 You are receiving this because you are subscribed to this thread. Message ID: ___ rai

Re: [openstreetmap/openstreetmap-website] Change colors of changeset bboxes when they enter/exit the viewport (PR #5924)

2025-04-20 Thread Roman Deev via rails-dev
deevroman left a comment (openstreetmap/openstreetmap-website#5924) > In principle, omitting changesets covering the entire map viewport sounds > like an interesting idea. In practice, you will encounter a problem: what is the threshold value to take? What if a big changeset did change somethin

Re: [openstreetmap/openstreetmap-website] Arm in registration globe was deleted (Issue #5941)

2025-04-20 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#5941) It was removed on purpose: #4696 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5941#issuecomment-2817098184 You are receiving this because you are subscribed to

Re: [openstreetmap/openstreetmap-website] Change colors of changeset bboxes when they enter/exit the viewport (PR #5924)

2025-04-20 Thread limes11 via rails-dev
limes11 left a comment (openstreetmap/openstreetmap-website#5924) > > I strongly urge you to rethink this approach. Whilst I do not oppose using > > different colours depending on the age of changesets, the fact that older > > changesets are no longer clickable, makes scanning an area which does