Re: [openstreetmap/openstreetmap-website] Draft: Refactor confirmations controller (PR #5895)

2025-04-19 Thread rkoeze via rails-dev
@rkoeze pushed 2 commits. 6c577038d00932e8dfcfbba85156621b10072f8f Update routes 3c06cca86e0bd4c2237486b96156ec999f80df31 Get confirmations controller tests passing -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5895/files/71195ca644ff932d0f7c5b440af6e2f4ff6

Re: [openstreetmap/openstreetmap-website] Draft: Refactor confirmations controller (PR #5895)

2025-04-19 Thread rkoeze via rails-dev
@rkoeze pushed 12 commits. 4dfe38237e3be4e2f85bdf569055093c61040fe1 Change highlighted bbox border width to 4px on history pages f71878516853281a6e24c28e7a58a1a1e378a3ea Provide a truncated view of recent diaries 5c3fb16da43b52c054ce709f583342f7f283a067 Localisation updates from https://tran

Re: [openstreetmap/openstreetmap-website] Draft: Refactor confirmations controller (PR #5895)

2025-04-19 Thread github-actions[bot] via rails-dev
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#5895) 2 Warnings :warning: Number of updated lines of code is too large to be in one PR. Perhaps it should be separated into two or more? :

Re: [openstreetmap/openstreetmap-website] Arm in registration globe was deleted (Issue #5941)

2025-04-19 Thread Andres Gomez Casanova via rails-dev
angoca left a comment (openstreetmap/openstreetmap-website#5941) A bigger image as it used to be. ![Image](https://github.com/user-attachments/assets/ffb23272-7974-4eec-9ca8-d7d04e774ee4) -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-websit

[openstreetmap/openstreetmap-website] Arm in registration globe was deleted (Issue #5941)

2025-04-19 Thread Andres Gomez Casanova via rails-dev
angoca created an issue (openstreetmap/openstreetmap-website#5941) ### Problem I want to know if the Arm deletion was on purpose or a mistake? It used to be like this: ![Image](https://github.com/user-attachments/assets/a0247478-88a4-41ae-81f6-682ce6731a2a) But now, it is like this (without th

[openstreetmap/openstreetmap-website] Changeset highlights in a layer on top of normal bboxes (PR #5940)

2025-04-19 Thread Anton Khorev via rails-dev
A fix for ["Also, sometimes the hover fails and the bbox ends up not on top of other bboxes"](https://community.openstreetmap.org/t/better-osm-org-a-script-that-adds-useful-little-things-to-osm-org/121670/105), look at the animation of the lower bbox in the second image. You can view, comment on

Re: [openstreetmap/openstreetmap-website] Change colors of changeset bboxes when they enter/exit the viewport (PR #5924)

2025-04-19 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5924) > You can scroll with a delay. Then you'll have to decide on the length of the delay. Too short and it's useless. Too long and it's annoying because you have to wait for at least this long, and usually it's annoying for delay

Re: [openstreetmap/openstreetmap-website] Changeset highlights in a layer on top of normal bboxes (PR #5940)

2025-04-19 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. cbb6e3089ba736767fe61da0fe6b38d44cd925c2 Replace changeset highlight state/style with highlight sublayer -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5940/files/99017fa8c3153f78609c1d4ea759eefb956f2a02..cbb6e3089ba736767fe61da0

Re: [openstreetmap/openstreetmap-website] Change colors of changeset bboxes when they enter/exit the viewport (PR #5924)

2025-04-19 Thread Roman Deev via rails-dev
deevroman left a comment (openstreetmap/openstreetmap-website#5924) > Use scrollIntoView() to bring the selected list-group-item into view in the > sidebar so you can always see what you're hovering over in the map. This is a tricky function. I use it in my script for osm.org to navigate betwee

Re: [openstreetmap/openstreetmap-website] Change colors of changeset bboxes when they enter/exit the viewport (PR #5924)

2025-04-19 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5924) > Give it a try and see if it works as a viable option rather than outright > dismissing it You give it a try. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull

Re: [openstreetmap/openstreetmap-website] Workaround a bug in file 5.46 (PR #5930)

2025-04-19 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5930) Oh yes I hacked mkmf to allow some of the extensions to build by forcing `-std=c11` or something. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5930#issuecomme