@rkoeze pushed 1 commit.
523a91edde43eb34170f0a8716c11b66e150839b Fix a couple of bugs
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5895/files/5b216da0e0c259e4217a91f7816b9c3854adc842..523a91edde43eb34170f0a8716c11b66e150839b
You are receiving this because y
@rkoeze pushed 1 commit.
949f87a806c57f7ab5643f0725ab705d6f9d5279 Fix a couple of bugs
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5895/files/523a91edde43eb34170f0a8716c11b66e150839b..949f87a806c57f7ab5643f0725ab705d6f9d5279
You are receiving this because y
This refactors our trace file format detection so that we only do it in one and
then adjusts that code to work around https://bugs.astron.com/view.php?id=643
which otherwise means that we fail to identify zip files on systems using
version 5.46 of the file command.
You can view, comment on, or m
rkoeze left a comment (openstreetmap/openstreetmap-website#5902)
@tomhughes sorry about that, and thanks for the reminder
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5902#issuecomment-2800017105
You are receiving this because
kcne left a comment (openstreetmap/openstreetmap-website#5906)
Got this working using the `CalendarLabel` plugin, though I'm seeing some CSP
warnings in the console. I'm pretty sure the CSP warnings here are related to
[CalendarLabel](https://cal-heatmap.com/docs/plugins/calendarLabel) plugin.
@kcne pushed 2 commits.
de84f559484849f103a940f49702e121bcb4bde1 Add yearly template to localize start
of the week and end the heatmap on todays date.
4d89f0f59451770ef9704e3a19bfacd9fb42a9cf Move week label rendering to
heatmap.js
--
View it on GitHub:
https://github.com/openstreetmap/opens
@AntonKhorev commented on this pull request.
> @@ -1,15 +1,40 @@
OSM.HistoryChangesetsLayer = L.FeatureGroup.extend({
- _changesets: [],
+ newerColor: "#AA8866",
+ olderColor: "#AA",
Includes workaround for https://github.com/leaflet/leaflet/issues/2662
--
Reply to this email directly
@AntonKhorev commented on this pull request.
> @@ -1,15 +1,40 @@
OSM.HistoryChangesetsLayer = L.FeatureGroup.extend({
- _changesets: [],
+ newerColor: "#AA8866",
+ olderColor: "#AA",
Moved colors to css.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstre
@AntonKhorev pushed 4 commits.
38be871d5736287c25d1ac8060c739946cdd1e6b Move changeset colors to css
a725f6e7d638273536446fb24c55af19e7a4720f Change colors of bboxes when they
enter/exit the viewport
49d77c456cb5c8c18a28ff319d1b7dca2aa7556a Take viewport intersection into
account when sorting
@AntonKhorev pushed 7 commits.
70de6463d88c5bbfb00b36ce468a527e9ff31764 Store changesets of history
changesets layer in map
ea3f6c215dad1602c8e645a79af8bd8dcd03 Convert changeset (un)highlight to
toggle function
99232dd4e52122888c4cef1ae3b04a29cc7e36b9 Maintain highlight states in history
Merged #5929 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5929#event-17238783401
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5928 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5928#event-17238783405
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5927 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5927#event-17238783406
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5929)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5929#issuecomment-2799974421
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5928)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5928#issuecomment-2799974262
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5927)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5927#issuecomment-2799973993
You are receiving this because you are subscribed to this t
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5929
-- Commit Summary --
* Remove custom position and margin css from .content-inner
-- File Changes --
M app/assets/stylesheets/common.scss (2)
M app/views
For spinners that appear after clicking this button in search results:
Removes a little bit of custom css.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/o
@AntonKhorev pushed 1 commit.
343b7543af52b04bcb37ec3c225bce881a1d9bce Wait for changeset link before
clicking the map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5927/files/a6fe062f743194a54fef357b08415bdc445b1a23..343b7543af52b04bcb37ec3c225bce881a1d9bce
The test from #5921 might have a timing issue when the map is clicked before
the chagesets are loaded.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5927
-- Commit Summary --
* Wait for changeset link before click
AntonKhorev left a comment (openstreetmap/openstreetmap-website#2629)
> JOSM is also external, but openstreetmap.org links to it via "Edit with
> Remote Control".
openstreetmap.org doesn't link to JOSM
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/open
tomhughes left a comment (openstreetmap/openstreetmap-website#5925)
Apparently I did, which is really weird because I retested it before I pushed
and it seemed to be correct!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5925#i
Closed #1000 as completed via #5925.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/1000#event-17238269253
You are receiving this because you are subscribed to this thread.
Message ID:
_
@tomhughes requested changes on this pull request.
The third commit should be squashed into the first one rather than keeping it
as a fixup commit.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5902#pullrequestreview-27627287
Merged #5925 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5925#event-17238269208
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
hlfan left a comment (openstreetmap/openstreetmap-website#5925)
Did you just merge the old version in 283e034b562ed4786d9f9fc6020e2c61fd1dca02?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5925#issuecomment-2799892275
You are r
@tomhughes approved this pull request.
Thanks. This looks good to me now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5925#pullrequestreview-2762728413
You are receiving this because you are subscribed to this thread.
Messa
@tomhughes commented on this pull request.
Technically this looks so I think the main questions here will be whether (a)
people think it's a good idea and (b) whether these are the best colour choices.
> @@ -1,15 +1,40 @@
OSM.HistoryChangesetsLayer = L.FeatureGroup.extend({
- _changesets: [],
Merged #5926 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5926#event-17238229304
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5920 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5920#event-17238229306
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5921 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5921#event-17238229307
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@hlfan commented on this pull request.
> @@ -30,6 +30,7 @@
"rotary": "roundabout",
"exit roundabout": "exit_roundabout",
"exit rotary": "exit_roundabout",
+"ferry": "continue",
I shot myself in the foot by not testing that, didn't I?
--
Reply to this email d
tomhughes left a comment (openstreetmap/openstreetmap-website#5926)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5926#issuecomment-2799885077
You are receiving this because you are subscribed to this t
@hlfan pushed 1 commit.
912abc7505847aae2e5c236a4b074f7ed46e0862 Add OSRM ferry support
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5925/files/b0a4438d5d5b314bab5b60a0fadd87ca5eec9119..912abc7505847aae2e5c236a4b074f7ed46e0862
You are receiving this because
@tomhughes requested changes on this pull request.
> @@ -30,6 +30,7 @@
"rotary": "roundabout",
"exit roundabout": "exit_roundabout",
"exit rotary": "exit_roundabout",
+"ferry": "continue",
Shouldn't this be:
```suggestion
"ferry": "ferry",
```
As it
tomhughes left a comment (openstreetmap/openstreetmap-website#5921)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5921#issuecomment-2799881263
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5920)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5920#issuecomment-2799881027
You are receiving this because you are subscribed to this t
@mmd-osm commented on this pull request.
> @@ -247,7 +247,7 @@ def respond_to_timeout
# To work round this we call rewind on the body here, which is added
# as a filter, to force it to be fetched from Apache into a file.
def fetch_body
-request.body.rewind
+request.body&.rewind
38 matches
Mail list logo
