@rkoeze commented on this pull request.
> @@ -247,7 +247,7 @@ def respond_to_timeout
# To work round this we call rewind on the body here, which is added
# as a filter, to force it to be fetched from Apache into a file.
def fetch_body
-request.body.rewind
+request.body&.rewind
andrewharvey left a comment (openstreetmap/openstreetmap-website#2629)
> If the tools are external, the means of launching them can also be external.
> Browser extensions for that exist.
JOSM is also external, but openstreetmap.org links to it via "Edit with Remote
Control". A browser extension
@mmd-osm commented on this pull request.
> @@ -247,7 +247,7 @@ def respond_to_timeout
# To work round this we call rewind on the body here, which is added
# as a filter, to force it to be fetched from Apache into a file.
def fetch_body
-request.body.rewind
+request.body&.rewind
I also changed the label for these routes from "cycleway" to
"bike route". "Bike route" is used in [the CyclOSM
lege
@hlfan commented on this pull request.
> @@ -5,16 +5,16 @@ class IndexTest < ApplicationSystemTestCase
node = create(:node)
visit node_path(node)
assert_selector "#content.overlay-right-sidebar"
-find(".icon.share").click
+find(".control-share a").click
Switching the two
@hlfan pushed 3 commits.
171e255a9bc7514504939b223466d2fc07203a59 Click links instead of icons in tests
7bd2b16e9f1a7a958417e0d7a675dd3dec3879bb Unify active control button behaviour
cd7fdc4ee785c25ea2722ed25fb197cbe051b0fb Remove controls sprite
--
View it on GitHub:
https://github.com/opens
### Description
Closes #1000 again
### How has this been tested?
Without the added translation
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5925
-- Commit Summary --
* Add OSRM ferry support
-- File Changes --
@hlfan commented on this pull request.
> +<%= t ".how_to_help.add_a_note.instructions_1_html", :note_icon =>
> tag.a(render(:partial => "layouts/note_icon"),
+
:class => "icon note",
Well, I do think the icons
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5918)
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5918#issuecomment-2798866568
You are receiving this because you are subscribed to this thread.
Merged #5918 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5918#event-17234694350
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@AntonKhorev commented on this pull request.
> +<%= t ".how_to_help.add_a_note.instructions_1_html", :note_icon =>
> tag.a(render(:partial => "layouts/note_icon"),
+
:class => "icon note",
Continuing
https://g
@AntonKhorev commented on this pull request.
> @@ -5,16 +5,16 @@ class IndexTest < ApplicationSystemTestCase
node = create(:node)
visit node_path(node)
assert_selector "#content.overlay-right-sidebar"
-find(".icon.share").click
+find(".control-share a").click
If we want t
@hlfan commented on this pull request.
> YAML.load_file(Rails.root.join(layers_filename))
.reject { |layer| layer["apiKeyId"] && !Settings[layer["apiKeyId"]] }
.map do |layer|
if layer["apiKeyId"]
layer["apikey"] = Settings[layer["apiKeyId"]]
@hlfan pushed 1 commit.
adb1b95de0c67fa53bb5a5a21200e1c1342afd55 Put map key presence in js layer
definitions
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5918/files/6ae05daa1b1d585b07ed833023be1c84f9eb5827..adb1b95de0c67fa53bb5a5a21200e1c1342afd55
You are
@AntonKhorev commented on this pull request.
> YAML.load_file(Rails.root.join(layers_filename))
.reject { |layer| layer["apiKeyId"] && !Settings[layer["apiKeyId"]] }
.map do |layer|
if layer["apiKeyId"]
layer["apikey"] = Settings[layer["apiKeyId"]]
AntonKhorev left a comment (openstreetmap/openstreetmap-website#2629)
If the tools are external, the means of launching them can also be external.
Browser extensions for that exist.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issu
16 matches
Mail list logo
