@hlfan pushed 3 commits.
b95125d0fac50bf6033c445086f68dbeadb916db Add parseGeoURI function and tests
1bd1837e375780cc1148b84398da5e89136628ad Add support for marker radius in map
parameters
389ae576fc33cc3aedfd08ae247bea5971577cf1 Add PWA geo protocol handler
--
View it on GitHub:
https://gi
@rkoeze pushed 10 commits.
f73f18fa94281ab02312b1d90b4a5ececfa42365 Move controller methods to user model
c6c16b81dc413ec548823ed7712fced61db53ee6 Add restful routes
d22011f63cd8867b334575c648011362c0263086 Make controller restful
f39516d9e34b438c4cc5d3818d4bd73a84401386 Update route invocatio
@rkoeze pushed 1 commit.
75d3fed09441b7e7cb8b2cad424ccdea024f92e6 Support interactive debugger
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5851/files/fe0d514d608b4870d8d56a4d80cc3a0a9f956f63..75d3fed09441b7e7cb8b2cad424ccdea024f92e6
You are receiving this b
@rkoeze pushed 3 commits.
19a9f17cb6e8b20e165d2170a1aa1eafcaeb5665 Add new files to .dockerignore
dbd23319cde8b945a76ffa8e1437cba8d8d052be Be explicit about filepaths
3597f2573a99c56f398ba4a3e0a330d40204f328 Remove keeps
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-web
SomeoneElseOSM created an issue (openstreetmap/openstreetmap-website#5909)
At osm.org in the search box there is a "Where is this" link.
Clicking that seems to always give "Error contacting
nominatim.openstreetmap.org: 400". Is this temporary capacity issue, something
local to me, or something
kcne left a comment (openstreetmap/openstreetmap-website#5906)
I was going to look into that next.. I'll let you know if i find a proper
solution. Thanks for the recommendation.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/590
kcne left a comment (openstreetmap/openstreetmap-website#5906)
I initially rounded the starting date to exactly one year ago, as that felt
like the most intuitive approach. But I noticed GitHub uses the first day of
the starting week instead. If we prefer that behavior for OSM, I’m happy to
ref
tomhughes left a comment (openstreetmap/openstreetmap-website#5909)
It seems this is still failing for the "show address" option in the right click
menu...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5909#issuecomment-27919
Much like in the API responses from GraphHopper or Overpass Turbo, this PR adds
the credit information to the returned routes, removing the need to pass the
`chosenEngine` to the `DirectionsRouteOutput`.
You can view, comment on, or merge this pull request online at:
https://github.com/openstr
@hlfan commented on this pull request.
> @@ -93,6 +100,11 @@ OSM = {
mapParams.lon = params.get("mlon");
mapParams.lat = params.get("mlat");
mapParams.zoom = params.get("zoom") || 12;
+} else if (geoURI.has("geo") && geoURI.has("u") && !geoURI.has("z")) {
+ mapParam
@1ec5 commented on this pull request.
> } else {
- return OSM.i18n.t("javascripts.directions.distance_km", { distance:
Math.round(m / 1000) });
+ const ft = m / ftSize;
+ const mi = m / miSize;
+ if (ft < 1000) {
For what it’s worth, the [MapLibre Navigation
SDK](http
tomhughes left a comment (openstreetmap/openstreetmap-website#5906)
Well as far as I know it doesn't if you're using sprockets so it means moving
to a whole new asset toolchain.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/590
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5473)
Squashed comments into the previous commit.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5473#issuecomment-2790648937
You are receiving this because you are
@tomhughes requested changes on this pull request.
> end
end
+ def wrap_lon(lon)
+((lon + 180) % 360) - 180
I don't think this works? If we consider a range from -270 to 270 and apply
this to both then we wind up with 90 to -90 which is clearly nonsense?
Even considering a simp
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5906)
We could move to es modules.
There every file has its own scope.
But I have no idea how ruby works with that :)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pu
tomhughes left a comment (openstreetmap/openstreetmap-website#5909)
It was a very early version of nominatim basically... After I did some initial
prototype work @twain47 took over development which is where the name comes
from and then later it passed to Sarah.
--
Reply to this email directly
I get a `Uncaught TypeError: this.contentWindow is undefined` error every time
I regularly start an iD editing session. Is that expected? Would it not be
better to skip the check if everything is loaded correctly, maybe like this:
```js
if (this.contentWindow &&
!this.contentWindow.location.hre
@AntonKhorev pushed 7 commits.
0decd5c5065a8b87f0e906b866a3848c61de5346 Change empty changeset to be inside
the requested bbox
df37a336d6e47352b3253d4d4f07c359636ab5db Add transient bbox attribute to
changesets factory
f69772d0b6fdfdd03185754bd236b0414360ec16 Support unwrapped bbox values in
Links _key.yml_ to _layers.yml_ in the `MapLayers` module by putting a `hasKey`
flag into the `LAYER_DEFINITIONS`.
This removes the need for `LAYERS_WITH_MAP_KEY` as the key button can now
directly check `layer.options.hasKey`.
You can view, comment on, or merge this pull request online at:
ht
Merged #5917 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5917#event-17211395488
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5917)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5917#issuecomment-2794764880
You are receiving this because you are subscribed to this t
Fixes regression from
https://github.com/openstreetmap/openstreetmap-website/commit/f11b38709b6cdf6b837d822f4c1e04f06d65ca71
where changeset highlights disappear after automatically zooming in, do not
load at all or are incorrectly scaled when manually zooming.
Corrects invalid function name (`
mmd-osm left a comment (openstreetmap/openstreetmap-website#5880)
For additional context: the "icon" in line 137 of `external_svg` refers to an
additional `id="icon"` I had to add to each of the external svgs, like in this
example:
```xml
http://www.w3.org/2000/svg"; id="icon" width="12" heigh
lonvia left a comment (openstreetmap/openstreetmap-website#5908)
That's a misguided attempt to fulfil GSOC requirements. Feel free to just close.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5908#issuecomment-2788502666
You are
Continues #5786 by also sorting comments.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5907
-- Commit Summary --
* Order issue comments by id
-- File Changes --
M app/models/issue.rb (2)
-- Patch Links --
@AntonKhorev pushed 1 commit.
b624e14755cacbef1325e39828bb783fab828983 Attach routing credit to route
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5914/files/62366185509d343cfcf0936dd9635a14259002d8..b624e14755cacbef1325e39828bb783fab828983
You are receiving
@AntonKhorev commented on this pull request.
> } else {
- return OSM.i18n.t("javascripts.directions.distance_km", { distance:
Math.round(m / 1000) });
+ const ft = m / ftSize;
+ const mi = m / miSize;
+ if (ft < 1000) {
It was at 0.2 miles in
https://github.com/openst
@tomhughes commented on this pull request.
> } else {
- return OSM.i18n.t("javascripts.directions.distance_km", { distance:
Math.round(m / 1000) });
+ const ft = m / ftSize;
+ const mi = m / miSize;
+ if (ft < 1000) {
Is 1000 still the right boundary to use in feet/mil
@hlfan pushed 3 commits.
c82546a9394563cadccbc7b185ff526e70fba321 Add parseGeoURI function and tests
91758916ba4bd781df26baf99200e51bf2a51011 Add support for marker radius in map
parameters
88d2ab959e774daa277266c74a457e391ec35406 Add PWA geo protocol handler
--
View it on GitHub:
https://gi
@AntonKhorev pushed 7 commits.
508cf0445893986ba1e852cfc9521568c3dde8d6 Write most of route html using erb
template
d3f9b28fdafc77868d7af2808a1028976b150c34 Move directions template strings out
of javascript
684fbf2fc4d1d3fb2b648be2d15c9d4f9a27fd56 Add km/mi buttons to directions
fefcf64b0160
Closed #5909 as completed via #5916.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5909#event-17209539056
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5832 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5832#event-17209538764
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5916 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5916#event-17209538733
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5916)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5916#issuecomment-2794396829
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5832)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5832#issuecomment-2794392403
You are receiving this because you are subscribed to this t
@tomhughes commented on this pull request.
This is adding a whole load of names to the global namespace and I'm not sure
any of it is necessary...
Is there are reason all the things declared at global scope before the event
listener can't be declared inside it as they were before?
--
Reply
@tomhughes commented on this pull request.
> @@ -2,7 +2,10 @@
<%= render :partial => "diary_entry_heading", :object => diary_entry, :as =>
"diary_entry" %>
-<%= diary_entry.body.to_html %>
+<%= truncated ? diary_entry.body.to_html(2000) : diary_entry.body.to_html
%>
+<% if
Fixes #5909 again.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5916
-- Commit Summary --
* Add zoom parameter to 'Show address' in context menu
-- File Changes --
M app/assets/javascripts/index/contextmenu.
@AntonKhorev pushed 7 commits.
9e908a00b0f7d7c4ffbbf93b8dae80a3d2c3b05f Write most of route html using erb
template
0c87816d6411d3c60d24d00c9dfc78245811f8eb Move directions template strings out
of javascript
9525744b2f5af492b0c13da3b29392225cd0bb43 Add km/mi buttons to directions
0920b5167805
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5915
-- Commit Summary --
* Show/hide directions spinner instead of copying
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5914)
Yes. And I wanted to hotlink to routes like we do with nominatim but I don't
know if the providers are fine with that and if we should keep the current
links intact.
--
Reply to this email directly or view it on GitHub:
http
hlfan left a comment (openstreetmap/openstreetmap-website#5914)
Yep, meant `OSM.FOSSGIS_OSRM_URL + "about.html"` but that's not what I wrote,
is it?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5914#issuecomment-2793216378
You
@nertc pushed 1 commit.
be27c86c5f2c7f7497a9dc59e6d3ab0034099573 Provide a truncated view of recent
diaries
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5121/files/691738c70898082000657ceb8537ea52fa8bf488..be27c86c5f2c7f7497a9dc59e6d3ab0034099573
You are re
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5914)
This PR changed one of the links, I restored it before merging.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5914#issuecomment-2792427555
You are receiving t
Merged #5914 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5914#event-17204523246
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
hlfan left a comment (openstreetmap/openstreetmap-website#5906)
If you'd like to use "the first day of the starting week" for the calendar
start, I'd add a second commit here.
(my personal preference)
If you instead want to place the start "exactly one year ago", it isn't needed
here and co
kcne left a comment (openstreetmap/openstreetmap-website#5906)
I’ve figured out how to get weekStart localization working locally. Since I
used a commit from this PR to get it working, would you prefer that I add a
commit here or open a separate PR for it?
--
Reply to this email directly or vi
Reopened #5909.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5909#event-17201959945
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mail
nertc left a comment (openstreetmap/openstreetmap-website#5121)
PR was updated.
@AntonKhorev `truncate_html` was moved to be done after `linkify` and
`sanitize`.
@tomhughes visual of `See full entry` link was changed. Now it is separate from
other links and easier to see (see screenshots).
Logic
49 matches
Mail list logo
