Fixes #5909.
With a test unlike the other PR.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5911
-- Commit Summary --
* Make reverse geocoding request with zoom using 'Where is this?'
-- File Changes --
M ap
NeatNit left a comment (openstreetmap/openstreetmap-website#3428)
Thought I'd mention:
- Rich plain text (Discussions on changesets, notes; pictured in the
screenshots) fixed in #5835.
- Markdown (User Diaries, elsewhere?) would be fixed by #5840
- Misc things would be fixed by #3429 (which thing
hlfan left a comment (openstreetmap/openstreetmap-website#5832)
The back-and-forth with the directions entry loop made me remember this
simplification.
Dropping the MapLayers integration as it can't be done clean enough.
--
Reply to this email directly or view it on GitHub:
https://github.com/o
@nenad-vujicic approved this pull request.
This looks and works great on my side. Thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5914#pullrequestreview-2754825538
You are receiving this because you are subscribed to thi
Merged #5473 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5473#event-17195057628
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5903 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5903#event-17195370007
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5903)
This looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5903#issuecomment-2790847236
You are receiving this because you are subscribed to t
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5913)
`#directions_content` is not present all of the time.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5913#issuecomment-2790841052
You are receiving this becaus
@hlfan requested changes on this pull request.
I think as an "output", that module should get initialized with
`$("#directions_content")` so we don't need to specify the location of the
output every time.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/
@AntonKhorev pushed 4 commits.
437eb1fa8a518e760d76e51a1ab6ddd20c39ffc9 Add history changesets layer module
9c7c8b938ca0e4718278449e928e94b6222f6226 Rename changesets layer constant
d780c788685bff050c83e236a3a83c299dd3d494 Rename map listeners on history page
f11b38709b6cdf6b837d822f4c1e04f06d6
Closed #3423 as completed via #5473.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3423#event-17195057899
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5913 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5913#event-17195057646
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes approved this pull request.
Thanks. This looks good to me now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5473#pullrequestreview-2754584515
You are receiving this because you are subscribed to this thread.
Messa
@tomhughes approved this pull request.
Thanks. This looks good to me now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5913#pullrequestreview-2754572740
You are receiving this because you are subscribed to this thread.
Messa
@AntonKhorev commented on this pull request.
> + row
+.on("mouseenter", function () {
+ highlight
+.setLatLngs(lineseg)
+.addTo(map);
+})
+.on("mouseleave", function () {
+ map.removeLayer(highlight);
+});
+}
+
+
@AntonKhorev pushed 3 commits.
7196368d6a27f4c3313e60c82ed06c959d60e90b Move directions route output to its
own module
b6bde64152ebce2d6c9eb7d538f04fc61616c2de Replace deprecated hover listener by
mouseenter/leave
4ed266565bf3a6ca7d42b0e02fbd8fd4ae823cff Rename directions close button
listen
@hlfan pushed 1 commit.
67599dc6b2dbbdf3d4adabc05ae51198dc2b4c5b Refactor map base layer initialization
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5832/files/327691eaba98e7248453b19153f3b50d7f034ebb..67599dc6b2dbbdf3d4adabc05ae51198dc2b4c5b
You are receivi
Reopened #5832.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5832#event-17193962870
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailin
@tomhughes commented on this pull request.
Can you squash the final commit into the previous one please, so that the
comments come in along with the code changes given that they're kind of
important in explaining what the code is doing?
--
Reply to this email directly or view it on GitHub:
h
1ec5 left a comment (openstreetmap/openstreetmap-website#5882)
> I'm not sure if it's very useful because you can just share the current page
> url from the browser menu.
In Safari on macOS, a share sheet appears with a variety of options, including
shortcuts to people I’ve chatted with recentl
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5909)
`zoom` was mandatory since "twain geocoder", I don't even know what it was
https://github.com/openstreetmap/openstreetmap-website/commit/639a994c9b851b94d4c65aa96af732eefc8453fb
--
Reply to this email directly or view it on G
Closed #5910.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5910#event-17193427389
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
@tomhughes commented on this pull request.
> + row
+.on("mouseenter", function () {
+ highlight
+.setLatLngs(lineseg)
+.addTo(map);
+})
+.on("mouseleave", function () {
+ map.removeLayer(highlight);
+});
+}
+
+
Reopened #5910.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5910#event-17193400248
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailin
Merged #5911 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5911#event-17193383603
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5912 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5912#event-17193383589
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5911)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5911#issuecomment-2790447990
You are receiving this because you are subscribed to this t
Closed #5909 as completed via #5911.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5909#event-17193383872
You are receiving this because you are subscribed to this thread.
Message ID:
_
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5473)
Added comments to `conditions_bbox` because it might not be obvious why it
works across the antimeridian.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5473#
Closed #5908.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5908#event-17192941623
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
@AntonKhorev pushed 3 commits.
4d3c14b3de0ec78b33e83c21434dfdb78b7eb919 Move directions output to its own
module
a4484a332083666b8072d3e9181d07b35204f3b1 Replace deprecated hover listener by
mouseenter/leave
e7f83edd89a6ebea9b08c3ea5b0bcd54a2891785 Rename directions close button
listener
--
@AntonKhorev pushed 3 commits.
70a74a2bb7c51a1397850f3fafc8445b933ef6d9 Move directions route output to its
own module
8156d8b3ce34902b2abcf0883271c46244873f9e Replace deprecated hover listener by
mouseenter/leave
554ff04f71ddc6d11b4a7113124bab387b8ea0a7 Rename directions close button
listen
Closed #5910.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5910#event-17186411868
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Previously I moved endpoints code out of `directions.js`, but there's still
too much code.
This PR creates a module for valid route output which includes:
- total time/distance
- directions table
- download link
- link to the routing engine
- route geometry drawn on the map with hovers/popups
You
@AntonKhorev commented on this pull request.
> @@ -36,4 +36,10 @@ $(function () {
if (idData.gpx) params.set("gpx", idData.gpx);
id.attr("src", idData.url + "#" + params);
+
+ id.ready(function () {
+if (!this.contentWindow.location.href.startsWith(idData.url)) {
I'm not sure if th
@tyrasd pushed 1 commit.
d10ead2f2fcf26c0d9f36c1d312db761c5ef3cd1 Update to iD v2.33.0
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5912/files/c48123ba70167817fd755622fd996ae7843ce5f5..d10ead2f2fcf26c0d9f36c1d312db761c5ef3cd1
You are receiving this because y
@AntonKhorev pushed 8 commits.
4f6589228788dd3e69de3d957a7bcad36cf175da Change empty changeset to be inside
the requested bbox
3c00c2032afe8112734fc59255aa002b6fb1051e Add transient bbox attribute to
changesets factory
79fc85169c1abf35b272df3e0c428fb03a63ee1f Support unwrapped bbox values in
@tyrasd commented on this pull request.
> @@ -36,4 +36,10 @@ $(function () {
if (idData.gpx) params.set("gpx", idData.gpx);
id.attr("src", idData.url + "#" + params);
+
+ id.ready(function () {
+if (!this.contentWindow.location.href.startsWith(idData.url)) {
I get a `Uncaught TypeE
release notes are available at
https://github.com/openstreetmap/iD/releases/tag/v2.33.0
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5912
-- Commit Summary --
* Update to iD v2.33.0
-- File Changes --
A .Ve
@AntonKhorev pushed 4 commits.
4f6589228788dd3e69de3d957a7bcad36cf175da Change empty changeset to be inside
the requested bbox
3c00c2032afe8112734fc59255aa002b6fb1051e Add transient bbox attribute to
changesets factory
79fc85169c1abf35b272df3e0c428fb03a63ee1f Support unwrapped bbox values in
@tyrasd pushed 1 commit.
c48123ba70167817fd755622fd996ae7843ce5f5 Update to iD v2.33.0
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5912/files/7a9d2af0e09ea4eb2ac9a26b72ba7c6557b3a657..c48123ba70167817fd755622fd996ae7843ce5f5
You are receiving this because y
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#5912)
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Gener
@AntonKhorev commented on this pull request.
> @@ -93,6 +100,11 @@ OSM = {
mapParams.lon = params.get("mlon");
mapParams.lat = params.get("mlat");
mapParams.zoom = params.get("zoom") || 12;
+} else if (geoURI.has("geo") && geoURI.has("u") && !geoURI.has("z")) {
+ ma
hlfan left a comment (openstreetmap/openstreetmap-website#5910)
Closing in favor of #5911.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5910#issuecomment-2789106748
You are receiving this because you are subscribed to this thre
Little patch that attempts to close #5909
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5910
-- Commit Summary --
* Add zoom to describe location query
-- File Changes --
M app/assets/javascripts/index/search
lonvia left a comment (openstreetmap/openstreetmap-website#5909)
I think the restriction appeared on the Nominatim side with the switch to
Python, which was over a year ago. You really should always send the zoom. It
does make a difference for the result.
--
Reply to this email directly or vie
hlfan left a comment (openstreetmap/openstreetmap-website#5909)
#5863 apparently made the zoom parameter mandatory, but doesn't send one in the
query. (maybe in the request body?)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues
1ec5 left a comment (openstreetmap/openstreetmap-website#5777)
> and the `driving_side` is wrong more often.
As noted in
https://github.com/Project-OSRM/osrm-backend/issues/2269#issuecomment-357154269,
a GeoJSON of [left-hand-drive
regions](https://github.com/Project-OSRM/osrm-backend/blob/4ee
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5909)
Did the empty zoom changed recently? I think we were sending it for a while.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5909#issuecomment-2788596283
You
lonvia left a comment (openstreetmap/openstreetmap-website#5909)
The website is sending an empty `zoom` parameter to Nominatim. That is not
allowed. It must be an integer number.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/
50 matches
Mail list logo
