[openstreetmap/openstreetmap-website] Hide future days in user heatmap (Issue #5905)

2025-04-07 Thread Holger Jeromin via rails-dev
HolgerJeromin created an issue (openstreetmap/openstreetmap-website#5905) ### Problem ![Image](https://github.com/user-attachments/assets/baaee4f2-cf21-4c55-9fe8-5a7456f4dbe5) Probably solvable: https://github.com/wa0x6e/cal-heatmap/issues/513 ### Description _No response_ ### Screenshots _No

Re: [openstreetmap/openstreetmap-website] Add user profile heatmap visualization for contributions (PR #5402)

2025-04-07 Thread Holger Jeromin via rails-dev
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5402) > You need to hide days that haven't happened, like GitHub. Every time you open > it, it looks like the user stopped contributing a few weeks ago. Would be nice. But I also did not found a way to do that with the used libra

Re: [openstreetmap/openstreetmap-website] Support unwrapped bbox values in changeset history queries (PR #5473)

2025-04-07 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > end end + def wrap_lon(lon) +((lon + 180) % 360) - 180 > I don't think this works? There are branches for "nonsense" cases. > If we consider a range from -270 to 270 and apply this to both then we wind > up with 90 to -90 which is

Re: [openstreetmap/openstreetmap-website] Adds non-mutable note tags support (PR #5344)

2025-04-07 Thread Nenad Vujicic via rails-dev
Closed #5344. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5344#event-17153629847 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Adds non-mutable note tags support (PR #5344)

2025-04-07 Thread Nenad Vujicic via rails-dev
nenad-vujicic left a comment (openstreetmap/openstreetmap-website#5344) Closed in favor of #5904 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5344#issuecomment-2783315936 You are receiving this because you are subscribed to thi

Re: [openstreetmap/openstreetmap-website] Add message deletion warning (Issue #5891)

2025-04-07 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#5891) I think a better solution would be to add a "Deleted items" folder with an option to recover items. The data is anyway still available (see #5496). Confirmation popups are a good fit for mass deletions only (which we don't suppor

Re: [openstreetmap/openstreetmap-website] Show new/modified/deleted count in place of " 🖊" in changeset card (Issue #5758)

2025-04-07 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#5758) I think i'm mostly done with the cgimap part, including unit tests. For the time being, I have enhanced structure.sql with the following statement: ``` ALTER TABLE public.changesets ADD COLUMN num_created_nodes integer DEFAULT

Re: [openstreetmap/openstreetmap-website] Remove changeset icon redefinitions (PR #5884)

2025-04-07 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 1 commit. 891597169452e0e20c356e361bfbfba94c87d112 Remove changeset icon redefinitions -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5884/files/c8b7a20490395d920dee593656b40a8cfcae99f8..891597169452e0e20c356e361bfbfba94c87d112 You are receiving

Re: [openstreetmap/openstreetmap-website] Remove changeset icon redefinitions (PR #5884)

2025-04-07 Thread Nenad Vujicic via rails-dev
@nenad-vujicic requested changes on this pull request. This works and looks great, but wouldn't be better practice to put definitions of `icon-comment` and `icon-pencil` at the beginning of `_changeset` (before `<%= tag.li ...`) so we don't have to redefine if use `_changeset` on some other pla

Re: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201)

2025-04-07 Thread David Tsiklauri via rails-dev
nertc left a comment (openstreetmap/openstreetmap-website#5201) Thanks for rerunning tests. PR was updated. `master` was merged to avoid previous test errors. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5201#issuecomment-27835

Re: [openstreetmap/openstreetmap-website] Optimize user creation illustrations by reusing elements (PR #5894)

2025-04-07 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5894) > 5195 + 5865 + 4015 bytes There's no way anyone is going to see all three images. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5894#issuecomment-2783352067

Re: [openstreetmap/openstreetmap-website] Optimize user creation illustrations by reusing elements (PR #5894)

2025-04-07 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#5894) Has the sign-up flow changed so users don't see all images when creating a new account? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5894#issuecomment-2783412423

Re: [openstreetmap/openstreetmap-website] Adds note versions and variable note tags (PR #5904)

2025-04-07 Thread github-actions[bot] via rails-dev
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#5904) 1 Warning :warning: Number of updated lines of code is too large to be in one PR. Perhaps it should be separated into two or more? Gener

[openstreetmap/openstreetmap-website] Adds note versions and variable note tags (PR #5904)

2025-04-07 Thread Nenad Vujicic via rails-dev
### Description PR proposes adding support for note versions and variable note tags. Here is a detailed list of changes: 1. Updated and created database tables `notes` and `note_versions` for keeping note versions like it is done for other elements (nodes, ways and relations) 2. Added creating

[openstreetmap/openstreetmap-website] Render changesets on both sides of the antimeridian (PR #5903)

2025-04-07 Thread Anton Khorev via rails-dev
Continues #5473 by fixing the rendering. When anything is added to the map, its longitude could be as well (the original longitude) + n * 360. n is an integer and usually it's 0 but that doesn't work when looking at the map near the antimeridian. Here I'm picking such n for each changeset bbox

Re: [openstreetmap/openstreetmap-website] Support unwrapped bbox values in changeset history queries (PR #5473)

2025-04-07 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. a58af9be38745981060e9c4d37ad315e0344cc59 Support unwrapped bbox values in changeset history queries -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5473/files/768b39e797e87d633c9e95773a5fffdf7a41e0d8..a58af9be38745981060e9c4d37ad3

Re: [openstreetmap/openstreetmap-website] More directions refactoring (PR #5901)

2025-04-07 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5901) I'm going to undo things like https://github.com/openstreetmap/openstreetmap-website/pull/5901/commits/2af72b2e6f4e4c1c0775f16f102f50a59bdeb0c3. -- Reply to this email directly or view it on GitHub: https://github.com/openstr