@nertc pushed 1 commit.
39a0abf336d858c85c09812b70a5378944242ded Add locale selector
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201/files/8a3e211e938dedeafe021d09afb9c66fbf2325a9..39a0abf336d858c85c09812b70a5378944242ded
You are receiving this because you
@rkoeze pushed 1 commit.
98d5774d53c210d805a218fc75dec57bf892977a Remove keeps
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5902/files/25b632337d6a4ed246ea1c70b0f2d21a606a86a6..98d5774d53c210d805a218fc75dec57bf892977a
You are receiving this because you are s
rkoeze left a comment (openstreetmap/openstreetmap-website#5851)
@nenad-vujicic thanks for the review! It occurs to me that it might be useful
to add this to the [Docker
documentation](https://github.com/openstreetmap/openstreetmap-website/blob/master/DOCKER.md).
I will do that in a separate P
@rkoeze commented on this pull request.
> @@ -445,6 +451,55 @@ def deletion_allowed?
deletion_allowed_at <= Time.now.utc
end
+ # Gracefully fallback to looking up users by deprecated new_user and
new_email tokens
+ def self.lookup_by_confirmation_token(account_confirmation_token)
T
@rkoeze commented on this pull request.
>
- def confirm
-if request.post?
- user = User.find_by_token_for(:new_user, params[:confirm_string])
+ def show
+if params[:confirm_string]
+ user = User.lookup_by_confirmation_token(params[:confirm_string])
if !user
This w
hlfan left a comment (openstreetmap/openstreetmap-website#5901)
GraphHopper never had multi-leg support, and it's not like we're on the verge
of adding it.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5901#issuecomment-2781898
### Description
Adds some more files to the `.dockerignore`. In general this brings up closer
to the [Rails
defaults](https://github.com/rails/rails/blob/1dc50194047b6a371dd78b486a247babfaa9f0e0/railties/lib/rails/generators/rails/app/templates/dockerignore.tt).
### How has this been tested?
I a
Merged #5901 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5901#event-17144344711
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5901)
I think the only thing I might question is the removal of multi-leg support but
I guess without waypoints the engines are only going to return one leg and in
general this looks good to me, thanks.
--
Reply to this email direct
### Description
I took another look at the directions engines after #5898. I may have found too
much, but I kept the commit size low this time.
### How has this been tested?
in chrome and firefox
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/
hlfan left a comment (openstreetmap/openstreetmap-website#5898)
Did you intentionally remove the instruction indicies from the popup?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5898#issuecomment-2781530670
You are receiving t
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5121)
> > ... to indicate if an entry has been truncated
>
> What should this look like because I don't seem to be seeing this? I also
> can't see anything in the code that looks like it would do it?
The link to the full entry is d
tomhughes left a comment (openstreetmap/openstreetmap-website#5121)
> ... to indicate if an entry has been truncated
What should this look like because I don't seem to be seeing this? I also can't
see anything in the code that looks like it would do it?
--
Reply to this email directly or view
tomhughes left a comment (openstreetmap/openstreetmap-website#5882)
Can confirm it works nicely in Firefox on Android but not on desktop - there is
an option to enabled it on desktop but (at least on linux) nothing actually
happens when you click it and the console shows that the promise is reso
Merged #5863 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5863#event-17143360242
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5899 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5899#event-17143360237
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5900 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5900#event-17143360239
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5859 as completed via #5863.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5859#event-17143360293
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5898 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5898#event-17143360238
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes approved this pull request.
Looks good to me now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5863#pullrequestreview-2745158401
You are receiving this because you are subscribed to this thread.
Message ID
tomhughes left a comment (openstreetmap/openstreetmap-website#5898)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5898#issuecomment-2781446348
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5900)
This doesn't seem to work in Firefox on Android but it does in Chrome, and
presumably in Safari on iOS, so it looks good to me.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetma
tomhughes left a comment (openstreetmap/openstreetmap-website#5899)
Reading https://github.com/openstreetmap/trac-tickets/issues/5065 it seems the
javascript fallback was for IE so it can definitely go and this looks good to
me.
--
Reply to this email directly or view it on GitHub:
https://git
Another autofocus-related change in addition to #5899.
Normally on map view pages we have the search input autofocused. But on the
*Add a note* page it makes sense to focus on the note description input. Since
it may be loaded in the sidebar after the regular page load, we're focusing
with java
The workaround was added in
https://github.com/openstreetmap/openstreetmap-website/commit/9cc9a0098840363b6497337951b53aa583f4aa44.
It uses [deprecated .focus() jQuery
function](https://api.jquery.com/focus-shorthand/).
It's also not necessary because [browsers supported autofocus on input for
Writing step numbers is currently the responsibility of each routing engine:
But that shouldn't be the case. Writing the numbers outside would later
help to stop constructing html by concatenation.
You can
@hlfan pushed 1 commit.
d0fd248d99f300bd575728c4c3ab23a9f3917c5c Clean OSM.formatHash calls
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5887/files/502ea242112a7b81388be8ac3fc2cfc59dedddf3..d0fd248d99f300bd575728c4c3ab23a9f3917c5c
You are receiving this beca
Merged #5896 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5896#event-17142615587
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5893 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5893#event-17142615584
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5877 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5877#event-17142615589
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5897 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5897#event-17142615585
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5877)
I'm a bit worried that we're going round in circles here but I'll merge this
for now... Hopefully somebody can work on better ways to do updates in the
future.
--
Reply to this email directly or view it on GitHub:
https://gith
tomhughes left a comment (openstreetmap/openstreetmap-website#5896)
If the test fails then the first thing you're going to do is look at the test
and I think it's pretty obvious there what's going on so I think this is
probably fine.
--
Reply to this email directly or view it on GitHub:
https:
tomhughes left a comment (openstreetmap/openstreetmap-website#5893)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5893#issuecomment-2781316685
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5897)
Looks good to me, thanks. The test failures are related to coveralls and can be
ignored.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5897#issuecomment-278131
tomhughes left a comment (openstreetmap/openstreetmap-website#5670)
Second weekend in a row that coveralls has a 24 hour planned outage...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5670#issuecomment-2781315481
You are rece
36 matches
Mail list logo
