@hlfan commented on this pull request.
> + para_2_html: |
+Just click %{note_icon} or the same icon on the map display.
+This will add a marker to the map, which you can move
+by dragging. Add your message, then click save, and other mappers will
investigate.
Then
@AntonKhorev commented on this pull request.
> + para_2_html: |
+Just click %{note_icon} or the same icon on the map display.
+This will add a marker to the map, which you can move
+by dragging. Add your message, then click save, and other mappers will
investigate.
Go to `/welcome` and click *start mapping*:
What's going to happen is that if you didn't give the geolocation
permission yet:
1. the permission dialog pops up
2. if you fail to react to it in four seconds,
@AntonKhorev commented on this pull request.
> @@ -86,8 +86,6 @@
- <%= t ".add_a_note.title" %>
- <%= t ".add_a_note.para_1" %>
- <%= t ".add_a_note.para_2_html", :map_link =>
link_to(t(".add_a_note.the_map"), root_path),
- :note_icon => tag.span(:c
hlfan left a comment (openstreetmap/openstreetmap-website#5872)
Actually, requiring `leaflet.locatecontrol/dist/L.Control.Locate.umd` could be
moved into L.OSM.locate to make the index and user js cleaner.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/op
@hlfan pushed 1 commit.
7f4b6978983412e417160f1a3ee5ee6f313afae4 Fix add a note template render
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5870/files/c39bb4921c29b220a8fc3b3015b635d396b87f1c..7f4b6978983412e417160f1a3ee5ee6f313afae4
You are receiving this
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5850)
We got another linkify in ApplicationHelper. That one only adds
`rel="nofollow"`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5850#issuecomment-2776391285
Makes the changeset icon definitions a bit more compact and doesn't
redefine them in every single history entry.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5884
-- Commit Summary --
* Remove changeset icon rede
@hlfan pushed 1 commit.
c39bb4921c29b220a8fc3b3015b635d396b87f1c Add add a note template
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5870/files/f7be240322f35d2e893001a4b3e453d2e85881ac..c39bb4921c29b220a8fc3b3015b635d396b87f1c
You are receiving this because
NeatNit created an issue (openstreetmap/openstreetmap-website#5883)
I noticed that linkified links only have `rel="nofollow"` instead
of the full `rel="nofollow noopener noreferrer"`. I don't think this is my
browser or extensions doing funky stuff because I see it in the raw respo
@hlfan pushed 1 commit.
f7be240322f35d2e893001a4b3e453d2e85881ac Add add a note template
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5870/files/78ba2ff31134e65562985c962076c7b03a22ec38..f7be240322f35d2e893001a4b3e453d2e85881ac
You are receiving this because
@hlfan pushed 1 commit.
78ba2ff31134e65562985c962076c7b03a22ec38 Add add a note template
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5870/files/09cd6456de59841c3eb8f2375285c57243c6fddd..78ba2ff31134e65562985c962076c7b03a22ec38
You are receiving this because
@hlfan pushed 1 commit.
32647664df4e689780a40084c791b55217511950 Deduplicate note adding instructions
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5870/files/c6da5e2cd097a84c4805c3fa122adc8e4416f556..32647664df4e689780a40084c791b55217511950
You are receiving
NeatNit left a comment (openstreetmap/openstreetmap-website#5878)
> > * nothing instead of "%{count}", probably in languages without indefinite
> > article
>
> That's interesting, do you have examples? I wonder if these languages just
> have a choice between saying "day ago" vs "1 day ago" or w
hlfan left a comment (openstreetmap/openstreetmap-website#5880)
> How do you think I made them?
ctrl + C, ctrl + V
https://github.com/openstreetmap/openstreetmap-website/pull/5775#discussion_r1986100939
> Yes it is possible [to read the path]
Do we also not add accessibility features into the
NeatNit left a comment (openstreetmap/openstreetmap-website#5850)
I see... So when is the Rich Text one used? Seems weird that even rich text
seems to get the ApplicationHelper one.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5870)
There's already one deduplicated section `<%= render "any_questions" %>`. You
could have done the same with *Add a Note!*, except maybe without including
``/`` in the template because they're slightly different. In this case
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5880)
> It makes the icons hard to edit, for example with tools like Inkscape
You don't edit them in Inkscape.
> For some erb templates it can also become a large amount
Because you don't edit them with Inkscape, they won't get unn
hlfan left a comment (openstreetmap/openstreetmap-website#5879)
```css
background-position: bottom right;
```
And crop away the empty space on the left.
Then:
--
Reply to this email directly
NeatNit left a comment (openstreetmap/openstreetmap-website#5850)
I noticed that linkified links only have `rel="nofollow"` instead of the full
`rel="nofollow noopener noreferrer"`. I don't think this is my browser or
extensions doing funky stuff because I see it in the raw response data in the
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5878)
>> probably in languages without indefinite article
> That's interesting, do you have examples?
Russian `{{PLURAL|one=около месяца назад|few=около %{count} месяцев
назад|many=около %{count} месяцев назад|}}`
Polish `około {{PL
@NeatNit pushed 3 commits.
59e6081aed44d88bc37ca7e6603fd82fc1d80983 add dir="auto" to changeset comment
14a0df4bb55b80e9c8142f2feda7f463bea50bf3 make markdown bidirectional with
dir="auto"
f4972db233c2d08a8494086c5ab935ad38685668 add dir="auto" to linkify links
--
View it on GitHub:
https://
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5878)
A lot currently used translations don't follow the mandatory `%{count}` in
every form of `distance_in_words_ago` rule. You can find:
- nothing instead of "%{count}", probably in languages without indefinite
article
- "1" inst
@NeatNit pushed 1 commit.
440e1fe705ad630e55af8007b178f786e036c238 make markdown bidirectional with
dir="auto"
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5840/files/2a24d8abe8bf6b049dfe3e5726884a0f4eec0d5b..440e1fe705ad630e55af8007b178f786e036c238
You are
I wanted to check if
[navigator.share](https://developer.mozilla.org/en-US/docs/Web/API/Navigator/share)
works. This PR adds a hidden button for native share and unhides it if native
share is available. On desktops it may not be available but it worked for me in
Chrome on an Android phone.[^1]
gravitystorm left a comment (openstreetmap/openstreetmap-website#5878)
> * "yesterday" instead of "%{count} day ago"
Those are incorrect, and they should be converted to be "1 day ago" (or "one
day ago" at least). The `x_days` key is used with `:count => 1` [for 24...42
hours
ago](https://git
deevroman left a comment (openstreetmap/openstreetmap-website#5877)
the flicker causes: clearLayers + event loop steps + rebuilding data layer.
Perhaps you could first add new objects to the map and then delete the old
ones. However, it would probably still be noticeable due to the transparency
@nenad-vujicic approved this pull request.
This works great on my side and makes debugging faster. Thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5851#pullrequestreview-2739290741
You are receiving this because you are
28 matches
Mail list logo
