Re: [openstreetmap/openstreetmap-website] Can we avoid inlining svgs into erb templates? (Issue #5880)

2025-04-02 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#5880) Some SVGs could follow a straightforward process: read the file and remove unnecessary attributes, like `xmlns`. Like the magnifying glass in the search bar: https://github.com/openstreetmap/openstreetmap-website/blob/2075eb8329e5e01

Re: [openstreetmap/openstreetmap-website] hyperlink the words "OpenStreetMap Blog". (Issue #5875)

2025-04-02 Thread 積丹尼 Dan Jacobson via rails-dev
jidanni left a comment (openstreetmap/openstreetmap-website#5875) I looked but I cannot find any better repository. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5875#issuecomment-2774434586 You are receiving this because you

Re: [openstreetmap/openstreetmap-website] Support unwrapped bbox values in changeset history queries (PR #5473)

2025-04-02 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. 768b39e797e87d633c9e95773a5fffdf7a41e0d8 Support unwrapped bbox values in changeset history queries -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5473/files/930a8d7ac3ba8f9a5d29921f220b87e533c50252..768b39e797e87d633c9e95773a5ff

Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

2025-04-02 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 4 commits. 94c61af78d1b1c8dba0c483ebcb286ce87e7675e Unify active control button behaviour c6d9a8004661577e31bd0e4919da9cc88971b63f Write fixthemap note link without JS 02bb306dce35b4f9abf6ab980b36b27e9f4a1deb Click links instead of icons in tests b0049cb3f12dbfee06eea1c8fd50f9d669

Re: [openstreetmap/openstreetmap-website] Incorrect translation choice time_ago for 21 hours ago (Issue #5878)

2025-04-02 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5878) > And on the wider topic, perhaps we should enforce the usage of the `%{count}` > interpolation in all translations, to avoid similar things from happening > there? Not all of our translators know about these edge cases. Can

Re: [openstreetmap/openstreetmap-website] Incorrect translation choice time_ago for 21 hours ago (Issue #5878)

2025-04-02 Thread Anton Khorev via rails-dev
Closed #5878 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5878#event-17102455033 You are receiving this because you are subscribed to this thread. Message ID: ___ rai

Re: [openstreetmap/openstreetmap-website] Incorrect translation choice time_ago for 21 hours ago (Issue #5878)

2025-04-02 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5878) [fixed on translatewiki](https://translatewiki.net/w/i.php?title=Osm:Datetime.distance_in_words_ago.about_x_hours/ru&oldid=13015165) -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/opens

Re: [openstreetmap/openstreetmap-website] Deduplicate note adding instructions (PR #5870)

2025-04-02 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 1 commit. c6da5e2cd097a84c4805c3fa122adc8e4416f556 Deduplicate note adding instructions -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5870/files/c7aa5d713bec17445fdff5c98c636536b5828233..c6da5e2cd097a84c4805c3fa122adc8e4416f556 You are receiving

Re: [openstreetmap/openstreetmap-website] Incorrect translation choice time_ago for 24-25 hours ago (Issue #5878)

2025-04-02 Thread Roman Deev via rails-dev
deevroman left a comment (openstreetmap/openstreetmap-website#5878) Wait, but that doesn't seem to be the problem. For 25 hours, a translation that uses days should be applied. In other words, it should be: «1 день назад» (1 day ago) -- Reply to this email directly or view it on GitHub: https:

Re: [openstreetmap/openstreetmap-website] Shorten options of map controls (PR #5873)

2025-04-02 Thread Andy Allan via rails-dev
Merged #5873 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5873#event-17097886509 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] History page links (PR #5876)

2025-04-02 Thread Andy Allan via rails-dev
gravitystorm left a comment (openstreetmap/openstreetmap-website#5876) Looks good! Thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5876#issuecomment-2773244974 You are receiving this because you are subscribed to this thre

Re: [openstreetmap/openstreetmap-website] Fix fixthemap note link (PR #5869)

2025-04-02 Thread Andy Allan via rails-dev
Merged #5869 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5869#event-17098072609 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Shorten options of map controls (PR #5873)

2025-04-02 Thread Andy Allan via rails-dev
gravitystorm left a comment (openstreetmap/openstreetmap-website#5873) Merged, thanks. Thanks also to @hlfan and @HolgerJeromin for your reviews. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5873#issuecomment-2773193183 You are

Re: [openstreetmap/openstreetmap-website] Post-merge UI review for #4455 (Issue #4773)

2025-04-02 Thread Andy Allan via rails-dev
gravitystorm left a comment (openstreetmap/openstreetmap-website#4773) I've reviewed the remaining work on this issue, and aside from https://github.com/openstreetmap/openstreetmap-website/pull/5879 I don't think there's more here that's worth tackling (on an effort/reward basis). So I'm closin

[openstreetmap/openstreetmap-website] Incorrect translation choice time_ago for 24-25 hours ago (Issue #5878)

2025-04-02 Thread Roman Deev via rails-dev
deevroman created an issue (openstreetmap/openstreetmap-website#5878) ### URL _No response_ ### How to reproduce the issue? 0. Enable Russian localization 1. Try searching on https://www.openstreetmap.org/history a 25-hour edit The translation is shown for a string that corresponds to 1 hour a

Re: [openstreetmap/openstreetmap-website] Provide a truncated view of recent diaries (PR #5121)

2025-04-02 Thread David Tsiklauri via rails-dev
nertc left a comment (openstreetmap/openstreetmap-website#5121) > If the truncation was the last step, I'd move to another module/class, which > I'd use only when I need to truncate. But currently html conversion is > followed by sanitize and linkify (why not first linkify then sanitize?). Can

Re: [openstreetmap/openstreetmap-website] Add profile location (PR #5302)

2025-04-02 Thread David Tsiklauri via rails-dev
nertc left a comment (openstreetmap/openstreetmap-website#5302) @tomhughes Thanks for the review. PR was updated accordingly. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5302#issuecomment-2772374827 You are receiving this beca

Re: [openstreetmap/openstreetmap-website] Add profile location (PR #5302)

2025-04-02 Thread David Tsiklauri via rails-dev
@nertc commented on this pull request. > @@ -139,6 +139,16 @@ +<% if @user.home_location_name && @user.home_location_name.strip.present? %> Was changed accordingly. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetma

Re: [openstreetmap/openstreetmap-website] Fix copy-pasting breaking links in shorten_host (PR #5861)

2025-04-02 Thread Marwin Hochfelsner via rails-dev
Closed #5861. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5861#event-17091808717 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Deduplicate note adding instructions (PR #5870)

2025-04-02 Thread Nenad Vujicic via rails-dev
@nenad-vujicic commented on this pull request. > + <%= t "notes.guide.title" %> + <%= t "notes.guide.para_1" %> + <%= t "notes.guide.para_2", :note_icon => tag.a(:href => new_note_path, :class => "icon note bg-dark rounded-1") %> > Ok, I added back the `_html` suffix, but where did the red

Re: [openstreetmap/openstreetmap-website] Changeset history view drafts and plans (PR #5808)

2025-04-02 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. 27f4c62b2b43f5f0aba0190a585ab4f1e86a5a6d WIP date picker -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5808/files/882e4056dc96f7179f5b9064f2b81606f66be137..27f4c62b2b43f5f0aba0190a585ab4f1e86a5a6d You are receiving this because y