Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

2025-03-27 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 1 commit. 75a77bf7c809bb6ddde72935bce9947b30fec18f Fix missing definitions on user dashboard -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5854/files/9bf96bdf3b734cd874ffdf2ec83b7a896436fe29..75a77bf7c809bb6ddde72935bce9947b30fec18f You are rec

Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

2025-03-27 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#5854) So apparently `DivIcon` does not support shadows. (https://github.com/Leaflet/Leaflet/issues/5083#issuecomment-307381003) -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/

[openstreetmap/openstreetmap-website] Link to Nominatim is missing viewbox parameter (Issue #5859)

2025-03-27 Thread Sarah Hoffmann via rails-dev
lonvia created an issue (openstreetmap/openstreetmap-website#5859) ### Problem Follow-up to #3205. The new direct links to Nominatim from #4895 are awesome but it looks like the `viewbox=` parameter doesn't work as intended. It never seems to be included in the URL. You can already see in the s

Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

2025-03-27 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 1 commit. 9bf96bdf3b734cd874ffdf2ec83b7a896436fe29 Fix route marker dragging -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5854/files/d0b107805cfee0d61f3594e3ea4859d476c4890e..9bf96bdf3b734cd874ffdf2ec83b7a896436fe29 You are receiving this becau

[openstreetmap/openstreetmap-website] Remove /wiki prefix from wiki urls in linkify (PR #5858)

2025-03-27 Thread Anton Khorev via rails-dev
#5855 replaces `wiki.openstreetmap.org` with `osm.wiki`, and now wiki link text has `... wiki/wiki ...` which looks redundant. Osm wiki is set up so that prefix is optional in most of the cases, that's why there's a proposal to remove the prefix: https://github.com/openstreetmap/openstreetmap-w

Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

2025-03-27 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 4 commits. e6bcfe554053016eabea9d75a3ac003b2c51a481 Unify active control button behaviour d39ce083554f24c094e569528715fa0efaeb0418 Set fixthemap note link in template 69dc6f0597f4dcb9516065e50958bfa87ea4e445 Click links instead of icons in tests 4533c080ebc6491a182beb30b5eec9cc877

[openstreetmap/openstreetmap-website] Use Date().toLocaleString() to construct month titles (PR #5834)

2025-03-27 Thread Anton Khorev via rails-dev
In some languages month names when used inside dates may differ from month names when used alone as titles. `OSM.i18n.t("date.abbr_month_names")` gives you month names for dates. That doesn't work with calendar month titles. Example in Russian: "May" = "май" "21 May, 2024" = "21 мая 2024" You d

Re: [openstreetmap/openstreetmap-website] Add dir="auto" to Markdown content for bidi (PR #5840)

2025-03-27 Thread Nitai Sasson via rails-dev
NeatNit left a comment (openstreetmap/openstreetmap-website#5840) > This is a version that modifies the document, consisting of replaced > `document` method, assuming we don't need to add `dir` on inline elements: > > ```ruby > def document > return @document if @document > > @d

Re: [openstreetmap/openstreetmap-website] Add dir="auto" to Markdown content for bidi (PR #5840)

2025-03-27 Thread Nitai Sasson via rails-dev
@NeatNit commented on this pull request. > + +"math" # don't know how this ends up, but dir="auto" is probably correct + ].each do |name| +define_method :"convert_#{name}" do |el, indent| + attr_bak = el.attr.dup # can't avoid mutating the attr hash, so make a bac

Re: [openstreetmap/openstreetmap-website] Shorten matching wiki urls in linkify (PR #5855)

2025-03-27 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5855) > Wiki understands Actually Apache understands, using a [config](https://github.com/openstreetmap/chef/blob/0cad06b01638b433858a5be37f87c236084cb743/cookbooks/mediawiki/templates/default/apache.erb#L72) with a bunch of `Rewri

Re: [openstreetmap/openstreetmap-website] Remove extra sanitize after simple_format RichText::HTML (PR #5852)

2025-03-27 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5852) Looks food to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5852#issuecomment-2758877309 You are receiving this because you are subscribed to this t

[openstreetmap/openstreetmap-website] Rephrase strings with the word "followings" (PR #5857)

2025-03-27 Thread Amir E. Aharoni via rails-dev
See issue #5856. I updated these strings to the best of my understanding, but I'm open to better suggestion to rephrase those strings. Thank you! You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5857 -- Commit Summary

[openstreetmap/openstreetmap-website] The word "followings" should probably be replaced in English strings (Issue #5856)

2025-03-27 Thread Amir E. Aharoni via rails-dev
amire80 created an issue (openstreetmap/openstreetmap-website#5856) "Friend" was replaced with "following" in 2b7a48029bff06c190544f91c5969b09aeae552b. I understand the general idea of it, but this created several instances of the word "followings", which sounds weird in this context as a plura

Re: [openstreetmap/openstreetmap-website] Remove TagHelper include from RichText module (PR #5850)

2025-03-27 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5850) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5850#issuecomment-2758899837 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Remove extra sanitize after simple_format RichText::HTML (PR #5852)

2025-03-27 Thread Tom Hughes via rails-dev
Merged #5852 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5852#event-17019034389 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Remove TagHelper include from RichText module (PR #5850)

2025-03-27 Thread Tom Hughes via rails-dev
Merged #5850 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5850#event-17019034382 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Shorten matching wiki urls in linkify (PR #5855)

2025-03-27 Thread Tom Hughes via rails-dev
Merged #5855 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5855#event-17019034403 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Add profile location (PR #5302)

2025-03-27 Thread David Tsiklauri via rails-dev
nertc left a comment (openstreetmap/openstreetmap-website#5302) @AntonKhorev Thanks for the review. PR was updated accordingly. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5302#issuecomment-2736015474 You are receiving this be

Re: [openstreetmap/openstreetmap-website] Shorten matching wiki urls in linkify (PR #5855)

2025-03-27 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5855) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5855#issuecomment-2758892572 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Shorten matching wiki urls in linkify (PR #5855)

2025-03-27 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5855) > Do need to save /wiki? Wiki understands paths without /wiki and makes a > redirect. Maybe later. This won't work for some links. For example `/wiki/w` and `/w` are going to show different pages. -- Reply to this email dir

Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)

2025-03-27 Thread Jean Zahn via rails-dev
jeanozahn left a comment (openstreetmap/openstreetmap-website#5590) Great! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5590#issuecomment-2755261612 You are receiving this because you are subscribed to this thread. Message ID

Re: [openstreetmap/openstreetmap-website] Shorten matching wiki urls in linkify (PR #5855)

2025-03-27 Thread Roman Deev via rails-dev
deevroman left a comment (openstreetmap/openstreetmap-website#5855) Do need to save /wiki? Wiki understands paths without /wiki and makes a redirect. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5855#issuecomment-2758382889 Yo

[openstreetmap/openstreetmap-website] Shorten matching wiki urls in linkify (PR #5855)

2025-03-27 Thread Anton Khorev via rails-dev
Like #5844, but for wiki links that are also common in comments. Before: ![image](https://github.com/user-attachments/assets/06edebe0-b6e0-4f71-bbfe-cbb945bf0d75) After: ![image](https://github.com/user-attachments/assets/9d02dad6-5e44-4269-a8eb-0df472ba6bff) You can view, comment on, or merge t

Re: [openstreetmap/openstreetmap-website] Add dir="auto" to Markdown content for bidi (PR #5840)

2025-03-27 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > + +"math" # don't know how this ends up, but dir="auto" is probably correct + ].each do |name| +define_method :"convert_#{name}" do |el, indent| + attr_bak = el.attr.dup # can't avoid mutating the attr hash, so make a

Re: [openstreetmap/openstreetmap-website] Add hide/show selection for contribution heatmap on edit profile page (PR #5853)

2025-03-27 Thread Emin Kocan via rails-dev
@kcne pushed 4 commits. 7f465ec351c97e81a553e746be57f376d6ad4421 Add show_contribution_heatmap to the table via migration and update the profile controller a1927cf1eed92d0e2a3c58381a5fd89ffef37da7 Add checkbox for contribution heatmap visibility on edit profile d2ba6e56f9323ce9295e0a5b4169e3af

[openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

2025-03-27 Thread Marwin Hochfelsner via rails-dev
### Description This is an attempt at parametrifying marker colors with `currentColor` since it has come up in #5764. Together with optimizing the path geometry, this required rewriting the marker layout to be compatible with partially transparent gradients. While an even simpler path has been pr

Re: [openstreetmap/openstreetmap-website] Fix GitHub badges in readme (PR #5849)

2025-03-27 Thread Andy Allan via rails-dev
Merged #5849 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5849#event-17008459672 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Fix GitHub badges in readme (PR #5849)

2025-03-27 Thread Andy Allan via rails-dev
gravitystorm left a comment (openstreetmap/openstreetmap-website#5849) Merged, thanks! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5849#issuecomment-2757253579 You are receiving this because you are subscribed to this thread.

Re: [openstreetmap/openstreetmap-website] Add hide/show contribution heatmap selection on edit profile section (PR #5853)

2025-03-27 Thread Emin Kocan via rails-dev
@kcne pushed 4 commits. 344700abaabb567055e6ff8fb594f1aaa8adbc3a Add show_contribution_heatmap to the table via migration and update the profile controller 8929fb37a252cac6a12e60a47b3a74f8553ed1ef Add checkbox for contribution heatmap visibility on edit profile fb05eca9ba3b1c95755b3f0e004596b7

[openstreetmap/openstreetmap-website] Add hide/show contribution heatmap selection on edit profile section (PR #5853)

2025-03-27 Thread Emin Kocan via rails-dev
### Description This PR introduces a user preference to toggle the visibility of the contribution heatmap on their profile page. Users can now enable or disable this feature through the edit profile section. Referencing #5804 **Changes include:** - Added `show_contribution_heatmap` boolean

Re: [openstreetmap/openstreetmap-website] dead link in /copyright (Issue #3998)

2025-03-27 Thread Simon Poole via rails-dev
simonpoole left a comment (openstreetmap/openstreetmap-website#3998) Just so that it doesn't get lost: The complication is that AND allowed us to import their data on the terms of a licence that is incompatible with the ODbL. So back in ~2012, that is pre-licence change, the LWG reached out to

Re: [openstreetmap/openstreetmap-website] Error in bundle exec db:create (Issue #5281)

2025-03-27 Thread Emin Kocan via rails-dev
kcne left a comment (openstreetmap/openstreetmap-website#5281) I encountered the same issue on my M4 Mac and found a solution. The problem is that the `gd2-ffij` gem can't find the GD2 library in the Homebrew installation path. Looking at the `gd2-ffij` gem's source code, it searches for the li