@hlfan pushed 4 commits.
731b167714fb6acb520f62602f321ff9cfb77f71 Unify active control button behaviour
07893ac5bbdbf3024131ad353514e9ee36e3c2b3 Set fixthemap note link in template
8d88b38e92943c49d0097010f83e85aa0327b5e7 Click links instead of icons in tests
73afa85266af789fef46f6be934e1eb476e
@hlfan pushed 1 commit.
b73906f4693a7e2e1b07f6352997092a0166bb93 Use icon definitions templates
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5752/files/bb5ce3b03b4c54d39e76d0b67e5c3d0930924922..b73906f4693a7e2e1b07f6352997092a0166bb93
You are receiving this
hlfan left a comment (openstreetmap/openstreetmap-website#5752)
Most aren't needed anywhere other than the map layout, so only the zoom/locate
icons need to be there.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5752#issuecomm
@NeatNit commented on this pull request.
> +"dl",
+# "dd", "dt", # child - since it's similar to a list, it has the same
behavior as a list
+
+"math" # don't know how this ends up, but dir="auto" is probably
correct
+ ].each do |name|
+define_method :"conve
RilusMahmud left a comment (openstreetmap/openstreetmap-website#5845)
@gravitystorm thanks a lot!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5845#issuecomment-2756513265
You are receiving this because you are subscribed to
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5752)
If you put the icons in a erb template and include that template from map
layout and other pages that use the icons, you'll have all the icons in one
place without paths in javascript. Something like this:
https://github.com/
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5840)
This is a version that modifies the document, consisting of replaced `document`
method, assuming we don't need to add `dir` on inline elements:
```ruby
def document
return @document if @document
@document = Kr
@AntonKhorev commented on this pull request.
> +"dl",
+# "dd", "dt", # child - since it's similar to a list, it has the same
behavior as a list
+
+"math" # don't know how this ends up, but dir="auto" is probably
correct
+ ].each do |name|
+define_method :"c
### Description
Configures the `web` service in `docker-compose.yml` file to allow for
interactive debugging. `tty` allocates a pseudo terminal while `stdin_open`
runs the container with stdin. Running `docker attach WEB_CONTAINER_ID`
connects to the running container where the debugger can be
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5121)
If the truncation was the last step, I'd move to another module/class, which
I'd use only when I need to truncate. But currently html conversion is followed
by sanitize and linkify (why not first linkify then sanitize?). Can w
We use TagHelper module to convert `:rel => "nofollow noopener
noreferrer"` into `'rel="nofollow noopener
noreferrer"'`, probably because
[Rinku](https://github.com/vmg/rinku)'s readme says thet we can generate an
attribute string from a hash. And to do that we have to call what is now a
priva
Closed #5329 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5329#event-16994273641
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
Before:
After:
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/op
@NeatNit commented on this pull request.
> +# "li", # child; sometimes container
+
+"table", # similar to Discourse, where the parent of
gets dir="auto" (no parent div in kramdown)
+# "td", # child
+# "th", # child; not actually a thing in kramdown but hypothet
The remainder of #5024 done similarly to #5751, without `Features` namespace.
Moves map key from `site` to its own resource/controller.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5830
-- Commit Summary --
* Cre
Closed #647 as completed via #5826.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/647#event-16945524843
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #5842 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5842#event-16998425853
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
> +# "li", # child; sometimes container
+
+"table", # similar to Discourse, where the parent of
gets dir="auto" (no parent div in kramdown)
+# "td", # child
+# "th", # child; not actually a thing in kramdown but hypoth
@tomhughes commented on this pull request.
> @@ -1,5 +1,45 @@
# frozen_string_literal: true
+module Kramdown
Actually https://kramdown.gettalong.org/rdoc/Kramdown/Converter/Base.html is
the relevant documentation here but yes it does seem that this is intended as
an extension point.
--
R
@tomhughes commented on this pull request.
> @@ -3,6 +3,10 @@ def self.full_definitions(layers_filename)
YAML.load_file(Rails.root.join(layers_filename))
.reject { |layer| layer["apiKeyId"] && !Settings[layer["apiKeyId"]] }
.map do |layer|
+ layer["name"] = I18n.t
tomhughes left a comment (openstreetmap/openstreetmap-website#5842)
I think this is probably fine as it is, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5842#issuecomment-2755391411
You are receiving this because you ar
tomhughes left a comment (openstreetmap/openstreetmap-website#5847)
How can the tests run if the migrations haven't run?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5847#issuecomment-2754928143
You are receiving this because
gravitystorm left a comment (openstreetmap/openstreetmap-website#5848)
Merged, thanks for figuring this out!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5848#issuecomment-2755089600
You are receiving this because you are subsc
Closed #5847 as completed via #5848.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5847#event-16996710379
You are receiving this because you are subscribed to this thread.
Message ID:
_
Closed #5847 as completed via 1d89cee94672ed09ba1733cae76142b69f72b3cc.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5847#event-16996710444
You are receiving this because you are subscribed to this thread.
Message ID:
__
Merged #5848 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5848#event-16996710106
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
gravitystorm left a comment (openstreetmap/openstreetmap-website#5845)
@RilusMahmud Thanks for reporting this problem! We've now fixed it in the
latest commits. If you update your repository, the migrations will now run
properly.
--
Reply to this email directly or view it on GitHub:
https://gi
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5706)
Do we just change the language from "accept" the ToU to "confirm that you
read", or did we go from *mandatory* acceptance to *automatic* acceptance since
https://github.com/openstreetmap/openstreetmap-website/pull/2028#issueco
Fixes #5847 by forcing migrations to run in test, and fixing some noise that
had crept into the structure as a result of them not running.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5848
-- Commit Summary --
*
Merged #5846 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5846#event-16995964534
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5846)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5846#issuecomment-2754953766
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5847)
Oh it's loading `structure.sql` instead of running migrations even though we
explicitly ask it to run migrations? Even removing `db/structure.sql` first
doesn't help - it sill doesn't run the migrations and you get an empty data
tomhughes left a comment (openstreetmap/openstreetmap-website#5847)
Also how does the structure compare equal? It can't possibly so the migrations
must have run, it just doesn't log the output?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-
gravitystorm left a comment (openstreetmap/openstreetmap-website#5329)
If there's any dark-mode inconsistencies or similar in the UI that have been
missed, please open separate issues for them.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-
gravitystorm left a comment (openstreetmap/openstreetmap-website#5328)
I'm closing this issue now, because the dark mode maps are now implemented as
described above.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issueco
gravitystorm created an issue (openstreetmap/openstreetmap-website#5847)
We have code to run the migrations in CI, mostly to make sure that when they
run, they produce the same results as structure.sql
When we upgraded to Rails 8, however, these migrations no longer run. I believe
it's because,
We previously pinned to an old version for ruby 3.1 support, but that's no
longer required since rails needs 3.2 anyway.
Fixes #5845
I'll follow up with the issue about why CI didn't catch this.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/o
Closed #5328 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#event-16994261489
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
NeatNit left a comment (openstreetmap/openstreetmap-website#5835)
Yay! How long do you think until it goes live on osm.org?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5835#issuecomment-2746295538
You are receiving this becaus
@nertc pushed 1 commit.
859d609fb2d519dab4253d9df5b1c718a30015d0 Provide a truncated view of recent
diaries
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5121/files/09f4fb63448798f0698efa82052576005ab6a533..859d609fb2d519dab4253d9df5b1c718a30015d0
You are re
@hlfan pushed 1 commit.
43c9495f2f433264cf279f7cd7e504bb0601dba1 Convert leaflet markers to SVG
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5764/files/5a361fc250b9e47b3f482bdad30b05df2cf6a061..43c9495f2f433264cf279f7cd7e504bb0601dba1
You are receiving this
@hlfan pushed 1 commit.
981b5ff00112153ee46c9363bc67cdb786429d3a Convert leaflet markers to SVG
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5764/files/43c9495f2f433264cf279f7cd7e504bb0601dba1..981b5ff00112153ee46c9363bc67cdb786429d3a
You are receiving this
@hlfan pushed 4 commits.
f915b243a5c8af0859b62820f3759ea3a570fe31 Put layer definitions into map layout
dc23418e768a99ca25c885e68ccb6dd8a857efe3 Translate names in MapLayers lib
f882b7b367f7b8c72e15f4f2974b8a90b96b5bb8 Build attribution in MapLayers lib
327691eaba98e7248453b19153f3b50d7f034ebb
44 matches
Mail list logo
