Merged #5825 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5825#event-16914942287
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5843 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5843#event-16979834608
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@AntonKhorev commented on this pull request.
> +const textarea = content.find("textarea");
+if (textarea.length) {
+ data.set("text", textarea.val());
+}
I guess @hlfan wants to say that the OSM API reacts the same to empty `text`
parameters and missing `text`
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5815)
> If we set an updated_at attribute whenever a new version is created, why
> would sorting by that be problematic? Wouldn't it be sufficient for ordering
> by the latest updates instead of relying on a surrogate id from note_c
@tomhughes commented on this pull request.
> @@ -76,11 +76,13 @@ def sanitize(text)
end
def linkify(text, mode = :urls)
- if text.html_safe?
-Rinku.auto_link(text, mode, tag_builder.tag_options(:rel => "nofollow
noopener noreferrer")).html_safe
- else
-Rink
Merged #5844 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5844#event-16980672003
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5832.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5832#event-16933709037
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Merged #5833 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5833#event-16929751121
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #4872 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4872#event-16980672025
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#4872)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4872#issuecomment-2752290742
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5844)
This looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5844#issuecomment-2752275823
You are receiving this because you are subscribed to t
@AntonKhorev commented on this pull request.
> @@ -97,11 +158,22 @@ OSM.History = function (map) {
.then(response => response.text())
.then(function (html) {
displayFirstChangesets(html);
+enableChangesetIntersectionObserver();
+
+if (params.has("before"))
@tomhughes commented on this pull request.
> +const textarea = content.find("textarea");
+if (textarea.length) {
+ data.set("text", textarea.val());
+}
Which API call are you talking about? Surely we want to avoid any errors?
--
Reply to this email directly or
kcne left a comment (openstreetmap/openstreetmap-website#5815)
@AntonKhorev, just to clarify—are you referring to sorting notes by their
latest updates or reconstructing the full note history for discussions (e.g.,
from note, note_versions, and note_comments)?
If we set an updated_at attribute
@AntonKhorev commented on this pull request.
> - nodes: "Nodes (%{count})"
+ nodes_title: "Nodes"
nodes_paginated: "Nodes (%{x}-%{y} of %{count})"
- ways: "Ways (%{count})"
+ ways_title: "Ways"
ways_paginated: "Ways (%{x}-%{y} of %{count})"
- relations: "Re
NeatNit left a comment (openstreetmap/openstreetmap-website#5840)
In that case, I stand by the current version of this PR.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5840#issuecomment-2751739808
You are receiving this because
tomhughes left a comment (openstreetmap/openstreetmap-website#5840)
I really don't think we want to get into writing and maintaining our own
complicated algorithms for determining direction, especially given the huge
number of elements we would need to apply it to, and a especially before there
NeatNit left a comment (openstreetmap/openstreetmap-website#5840)
I'm considering rewriting this from scratch, with the following changes which
would result in nicer code and better output:
1. Instead of subclassing the HTML converter, I will modify the document upon
its creation. This would me
@AntonKhorev commented on this pull request.
> +<% if pages.page_count == 1 %>
+
+<%= t ".#{type.pluralize}_title" %>
+
+ <%= pages.item_count %>
+
+
+<% elsif pages.page_count > 1 %>
+
+<%= t ".#{type.pluralize}_title" %>
+
+ <%= t ".range", :x => pages.curre
@AntonKhorev commented on this pull request.
> @@ -76,11 +76,13 @@ def sanitize(text)
end
def linkify(text, mode = :urls)
- if text.html_safe?
-Rinku.auto_link(text, mode, tag_builder.tag_options(:rel => "nofollow
noopener noreferrer")).html_safe
- else
-Ri
Closed #5845 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5845#event-16970666145
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
RilusMahmud left a comment (openstreetmap/openstreetmap-website#5845)
https://github.com/user-attachments/assets/e40865e3-5265-4346-be89-26ff4d5ebeab";
/>
here is the full view, here i ran these commands one by one,
first,
docker compose build
then,
docker compose up -d,
then on left pane, i ran
Reopened #5845.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5845#event-16970894205
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mail
RilusMahmud left a comment (openstreetmap/openstreetmap-website#5845)
@tomhughes
i am following the docker instructions,
https://github.com/user-attachments/assets/f6820170-fc52-4bd7-a7eb-744f84052925";
/>
and in migration step,
docker compose run --rm web bundle exec rails db:migrate
this co
RilusMahmud created an issue (openstreetmap/openstreetmap-website#5845)
### URL
_No response_
### How to reproduce the issue?
I'm trying to host on my local server, all was going well, but while running
migration, got this error, To use retry middleware with Faraday v2.0+, install
`faraday-re
tomhughes left a comment (openstreetmap/openstreetmap-website#5845)
Whatever your problem with migrations is I can assure it's nothing to do with
that message.
It doesn't really make much sense for `db:migrate` to complain about pending
migrations because it's job is to run them but I've never
RilusMahmud left a comment (openstreetmap/openstreetmap-website#5845)
@tomhughes
But my migration didn't ran for this issues, how can i do that?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5845#issuecomment-2750612905
You
tomhughes left a comment (openstreetmap/openstreetmap-website#5845)
You don't need to fix it because it's not an error, it's just an informational
message.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5845#issuecomment-27506
hlfan left a comment (openstreetmap/openstreetmap-website#872)
Even with multiple pins this problem remains:
> Otherwise there would be no obvious time when the marker could be removed
> again.
Although I think the closing of the search sidebar or opening another seems a
pretty obvious time to
Merged #5839 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5839#event-16944977271
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
nertc left a comment (openstreetmap/openstreetmap-website#5009)
For `CPU slowdown` I use browser built-in functionality.
Difference between getting data from server and rendering them is that while
getting data, there are no CPU intense tasks and loading icon is shown next to
the `data layer` c
31 matches
Mail list logo
