Closed #933 as completed via #5826.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/933#event-16945524854
You are receiving this because you are subscribed to this thread.
Message ID:
___
Not in use since
https://github.com/openstreetmap/openstreetmap-website/commit/f70edc02f086d97727453e738e9f0083c68ec706.
Whatever it did would only apply to Gravatar images and not to other king of
images.
You can view, comment on, or merge this pull request online at:
https://github.com/open
tomhughes left a comment (openstreetmap/openstreetmap-website#5840)
I thought the previous PR was handling all rich text... If it doesn't handle
markdown then it's of limited use - any HTML content is limited to legacy
material from many years ago so it's really only things that are limited to
@NeatNit commented on this pull request.
> @@ -1,5 +1,45 @@
# frozen_string_literal: true
+module Kramdown
https://kramdown.gettalong.org/rdoc/Kramdown/Parser/Base.html
> Implementing a new parser is rather easy: just derive a new class from this
> class and put it in the
> [Kramdown::Par
NeatNit left a comment (openstreetmap/openstreetmap-website#5840)
> I thought the previous PR was handling all rich text...
I'm sorry I didn't make that clear enough. Changeset comments and notes were
the main (only?) thing affected by the previous PR. Legacy or not, they are
extremely prominen
@NeatNit pushed 1 commit.
8284a308c4bfa880720367e6665e4cb66e48cfba make markdown bidirectional with
dir="auto"
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5840/files/3fd1fd04a82f9fb8b780b7b7f4f717f018da9023..8284a308c4bfa880720367e6665e4cb66e48cfba
You are
hlfan left a comment (openstreetmap/openstreetmap-website#5780)
Pasting a full SHA for a commit makes it get formatted too, like
`1370741ca929d87714934c9cc8c52780291fe0c3` to
1370741ca929d87714934c9cc8c52780291fe0c3, so requiring a few digits could be
all that's necessary.
I'd say at least five
NeatNit left a comment (openstreetmap/openstreetmap-website#5835)
Looks like I missed something important (main changeset comment). I'll lump
that in with my next PR, which handles Markdown.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-web
@NeatNit commented on this pull request.
> @@ -96,7 +136,7 @@ def to_text
class Markdown < Base
def to_html
- linkify(sanitize(document.to_html), :all)
+ linkify(sanitize(document.to_html_bidi), :all)
Oops, wrong link. This is the one:
https://kramdown.gettalong.org/rdoc/Kr
@tomhughes commented on this pull request.
> @@ -1,5 +1,45 @@
# frozen_string_literal: true
+module Kramdown
Injecting code into the `Kramdown` namespace is not ideal as we don't own that.
> @@ -96,7 +136,7 @@ def to_text
class Markdown < Base
def to_html
- linkify(sanitize(d
@NeatNit pushed 1 commit.
618df632c8509e5367ae990494c7418465dd2439 make markdown bidirectional with
dir="auto"
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5840/files/d55aca5d61f7b90702ec161e3ce1860430e655f8..618df632c8509e5367ae990494c7418465dd2439
You are
NeatNit left a comment (openstreetmap/openstreetmap-website#5840)
> I wonder if this would this be better done with a sanitize transformer that
> would work on the HTML regardless of how it was generated?
I don't know. Is there anything wrong with this approach? It seems to be the
cleanest way
Merged #5826 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5826#event-16945524797
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
> @@ -139,6 +139,16 @@
+<% if @user.home_location_name &&
@user.home_location_name.strip.present? %>
This could just be `@user.home_location_name&.strip.present?`?
> @@ -0,0 +1,65 @@
+OSM.HomeLocationNameEndp
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5815)
Se also the last paragraph of
https://github.com/openstreetmap/openstreetmap-website/issues/5294#issuecomment-2541604426,
where I write about keeping `id` from api0.6-comments. Some of those
api0.6-comments will become non-co
tomhughes left a comment (openstreetmap/openstreetmap-website#5835)
In fact this is going to just wind up as a single commit I think so squash
everything together unless you have a good reason not to.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstr
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5780)
There is a difference with changing how things that are already detected as
links look and the rest. You don't expect "I added a note 5 years ago" to link
to note #5 but that's what you'll get with those formats.
--
Reply to
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#5835)
1 Warning
:warning:
Merge commits are found in PR. Please rebase to
get rid of the merge commits in this PR, see CONTRIBUTING.md.
Genera
@NeatNit pushed 1 commit.
50c79d89503194c34f9a325c0aa53140a6d0b65e undo common.scss changes
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5835/files/83575bd9baee1e49d3e3d822d8fd01a423cb1596..50c79d89503194c34f9a325c0aa53140a6d0b65e
You are receiving this beca
NeatNit left a comment (openstreetmap/openstreetmap-website#5835)
> In fact this is going to just wind up as a single commit I think so squash
> everything together unless you have a good reason not to.
That's what I intend to do. Just need to rebase with the new master. Will get
behind a compu
NeatNit left a comment (openstreetmap/openstreetmap-website#5835)
Awesome, I'll do that ASAP :)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5835#issuecomment-2746262433
You are receiving this because you are subscribed to this
tomhughes left a comment (openstreetmap/openstreetmap-website#5835)
Can you also squash the fixup commits into the commit they're fixing please.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5835#issuecomment-2746264423
You are
@tomhughes requested changes on this pull request.
Looks good to me - just one small cosmetic comment.
> @@ -97,11 +158,22 @@ OSM.History = function (map) {
.then(response => response.text())
.then(function (html) {
displayFirstChangesets(html);
+enableChangesetInte
1ec5 left a comment (openstreetmap/openstreetmap-website#5780)
GitHub gets around this problem by requiring a `#` in front of the number, or
the full URL. Even just detecting and linkifying the URL would be a significant
improvement.
By the way, the URL format for elements used to be slightly d
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5835)
With #5837 merged it should be enough to just set `dir=auto` on paragraphs:
You can remove css changes and squash the commits.
--
Repl
tomhughes left a comment (openstreetmap/openstreetmap-website#5837)
Looks good to me, thanks.
I was going to say we should do the same for diary entries, but I see that
already use `article` so there's nothing to do there.
--
Reply to this email directly or view it on GitHub:
https://github.co
Merged #5836 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5836#event-16943964850
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5837 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5837#event-16943964848
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
danieldegroot2 created an issue (openstreetmap/openstreetmap-website#5838)
### URL
_No response_
### How to reproduce the issue?
Minor visual remark
It is possible to get the object highlight stuck when the object detail pane is
closed while it is still loading the relation highlight. (it is s
mmd-osm left a comment (openstreetmap/openstreetmap-website#5758)
The most notable thing I find worth porting over from osmcha is the changeset
visualization. Other projects need to jump through hoops to generate augmented
diffs, and we have direct access to all relevant data and could probably
30 matches
Mail list logo
