Re: [openstreetmap/openstreetmap-website] add dir="auto" to paragraphs in rich_text.rb (PR #5835)

2025-03-22 Thread Nitai Sasson via rails-dev
NeatNit left a comment (openstreetmap/openstreetmap-website#5835) For kramdown, this approach should work: https://codeberg.org/NeatNit/kramdown-bidi/src/branch/main/code.rb (the code works for sure but I haven't tested the results in a browser) I've stayed up too late again... I'll add it to t

Re: [openstreetmap/openstreetmap-website] add dir="auto" to paragraphs of formatted text (PR #5835)

2025-03-22 Thread Nitai Sasson via rails-dev
NeatNit left a comment (openstreetmap/openstreetmap-website#5835) > If you do this, you'd also set `dir=auto` on the entire comment. This would not be useful. Each paragraph needs to have `dir="auto"` separately. Different paragraphs in the same comment can have a different direction. This is w

Re: [openstreetmap/openstreetmap-website] pretty formatting of OSM URLS in notes, changeset comment, and comments (Issue #5780)

2025-03-22 Thread Andrew Welch via rails-dev
andrewtwelch left a comment (openstreetmap/openstreetmap-website#5780) I'd also add openstreetmap.org, osm.org, www.osm.org and wiki.osm.org as variants for the URL links, I've seen people (including myself) shorten links to help with how much space they take up. -- Reply to this email directl

[openstreetmap/openstreetmap-website] Put changeset and note comments in elements (PR #5837)

2025-03-22 Thread Anton Khorev via rails-dev
Our `/changeset/:id` and `/note/:id` pages have comments in the sidebar. Those comments are marked up as list items: ```html
  • ...
  • ...
  • ...
``` Turn out there's a drawback to that: list items redefine text alignment inside them. Normally you would

Re: [openstreetmap/openstreetmap-website] Adds version to notes table and creates note_versions table (PR #5815)

2025-03-22 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5815) I was thinking if we need both redactions and hidden statuses. But looks like we do because redactions can't remove top versions and hides can't remove just one version. -- Reply to this email directly or view it on GitHub:

[openstreetmap/openstreetmap-website] Change heatmap color to linear from 0 to max changes (PR #5833)

2025-03-22 Thread Holger Jeromin via rails-dev
### Description Changed heatmap colors ![Image](https://github.com/user-attachments/assets/dceef394-e18a-48fd-9c8b-b4a06cb90e72) That changes the map to be not comparable from one user to another, but better shows the day to day changes of one user. ### How has this been tested? Runtime change

Re: [openstreetmap/openstreetmap-website] add dir="auto" to paragraphs in rich_text.rb (PR #5835)

2025-03-22 Thread Nitai Sasson via rails-dev
NeatNit left a comment (openstreetmap/openstreetmap-website#5835) > Sidebar comments are in html lists, but should they? This is above my pay grade 😉 and definitely outside the scope of this PR -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-

Re: [openstreetmap/openstreetmap-website] add dir="auto" to paragraphs in rich_text.rb (PR #5835)

2025-03-22 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5835) `text-align: start;` is the default value, unless you're in a ``. Sidebar comments are in html lists, but should they? We don't output diary comments as a list. If you view comments on [this page](https://www.openstreetmap.o

Re: [openstreetmap/openstreetmap-website] dead link in /copyright (Issue #3998)

2025-03-22 Thread Taya via rails-dev
thiskal left a comment (openstreetmap/openstreetmap-website#3998) It appears the domain has now been bought by some NFT crypto domain scalping website https://hilcodigital.com/about/ https://wiki.openstreetmap.org/wiki/AND_data talks a bit about the license details of this dataset. According to

Re: [openstreetmap/openstreetmap-website] Provide a truncated view of recent diaries (PR #5121)

2025-03-22 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5121) > I think this needs some sort of indication when an entry has been truncated - > an ellipsis at the end of the truncated text or something. Do we want another method instead of building truncation into `to_html`? We need it