Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

2025-03-20 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#5752) Ah, now I see what you mean. Fixed that now: ![image](https://github.com/user-attachments/assets/4a04ec1c-5791-4bcd-b03f-41a96bb4d3d9) -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstree

Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

2025-03-20 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5752) > Matching the active button behaviour in > [bc50867](https://github.com/openstreetmap/openstreetmap-website/commit/bc508673e788ce8c00cf2f030261f733184c2177) > was intentional, that's why I split it into a separate commit. I

Re: [openstreetmap/openstreetmap-website] Queries and keys controllers in features namespace (PR #5024)

2025-03-20 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5024) Superseded by https://github.com/openstreetmap/openstreetmap-website/pull/5751 and #5830. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5024#issuecomment-274

Re: [openstreetmap/openstreetmap-website] Queries and keys controllers in features namespace (PR #5024)

2025-03-20 Thread Anton Khorev via rails-dev
Closed #5024. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5024#event-16919567731 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Add PWA geo protocol handler (PR #5736)

2025-03-20 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 1 commit. 69935bd87544958d299f4fa869cd526bfc5fd946 Add PWA geo protocol handler -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5736/files/1819a90efbf8c52ea359c524ea30d6d9fd92734d..69935bd87544958d299f4fa869cd526bfc5fd946 You are receiving this be

Re: [openstreetmap/openstreetmap-website] Show heatmap only to logged in users (PR #5829)

2025-03-20 Thread Grant via rails-dev
Firefishy left a comment (openstreetmap/openstreetmap-website#5829) In addition to this, some users may still prefer to hide their heatmap. Here is what the feature looks like on github: https://github.com/user-attachments/assets/4766559f-0a46-49fd-a580-0d5d4a86d9de"; /> -- Reply to this ema

Re: [openstreetmap/openstreetmap-website] Remove SVG symbol tags (PR #5776)

2025-03-20 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 1 commit. dd4068c8c7638beeb8e39181ded99dfc82dec90f Remove svg symbol tags -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5776/files/1ade2335b9ca186e7b123d728591f8c768ddb6ee..dd4068c8c7638beeb8e39181ded99dfc82dec90f You are receiving this because

Re: [openstreetmap/openstreetmap-website] Overhaul markers (PR #5764)

2025-03-20 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 1 commit. 5a361fc250b9e47b3f482bdad30b05df2cf6a061 Convert leaflet markers to SVG -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5764/files/aa6f26b947e1dcc1e1450ade9f724744e59f17e3..5a361fc250b9e47b3f482bdad30b05df2cf6a061 You are receiving this

Re: [openstreetmap/openstreetmap-website] Reuse mirrored turn icons (PR #5828)

2025-03-20 Thread Tom Hughes via rails-dev
Merged #5828 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5828#event-16914775168 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Remove OSM.params in favor of URLSearchParams (PR #5825)

2025-03-20 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5825) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5825#issuecomment-2741145208 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Issues with the Redesign on Mobile Phones (#557)

2025-03-20 Thread Andy Allan via rails-dev
Closed #557 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/557#event-16907702765 You are receiving this because you are subscribed to this thread. Message ID: ___ rails

Re: [openstreetmap/openstreetmap-website] Update straight routing in tests to use named directions icons (PR #5827)

2025-03-20 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5827) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5827#issuecomment-2741046475 You are receiving this because you are subscribed to this t

[openstreetmap/openstreetmap-website] Update straight routing in tests to use named directions icons (PR #5827)

2025-03-20 Thread Anton Khorev via rails-dev
Routing icons were updated to be referenced by names instead of numbers, but there was test code that still used numbers. This didn't affect the functioning of the tests because the icons weren't checked. This PR updates the *straight routing stub* to use named icons: ![image](https://github.co

Re: [openstreetmap/openstreetmap-website] Issues with the Redesign on Mobile Phones (#557)

2025-03-20 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#557) I wouldn't say that issues with new notes are solved. In fact they are even worse than described here if you get a virtual keyboard popping up and taking a third of your phone screen. -- Reply to this email directly or view i

Re: [openstreetmap/openstreetmap-website] Rewrite history page url when scrolling (PR #5826)

2025-03-20 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5826) > This might also close #568 too. If the goal of #568 is *I want to see "where user X edited in March last year"*, it requires changes to the calendar or some other control that would let you jump to some arbitrary point in t

Re: [openstreetmap/openstreetmap-website] Rewrite history page url when scrolling (PR #5826)

2025-03-20 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > +changesetIntersectionObserver = new IntersectionObserver((entries) => { + if (ignoreIntersectionEvents) { +ignoreIntersectionEvents = false; +return; + } + + let closestTargetToTop, + closestDistanceToTop

Re: [openstreetmap/openstreetmap-website] Set dir="auto" on changeset comment bodies (Issue #5785)

2025-03-20 Thread Andy Allan via rails-dev
gravitystorm left a comment (openstreetmap/openstreetmap-website#5785) Thanks for following up on this. I still stand by it being a duplicate (although I apologise for having missed that part of your description) because changeset comment bodies are just a single example of what the existing iss

Re: [openstreetmap/openstreetmap-website] Set dir="auto" on changeset comment bodies (Issue #5785)

2025-03-20 Thread Nitai Sasson via rails-dev
NeatNit left a comment (openstreetmap/openstreetmap-website#5785) > Duplicate of > [#3428](https://github.com/openstreetmap/openstreetmap-website/issues/3428) The very first sentence I wrote is that it's a sub-issue of that. My issue is basically an almost-PR, saying exactly how I think this ca

Re: [openstreetmap/openstreetmap-website] Update to rails 8 (PR #5430)

2025-03-20 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5430) Looks like they've done a release so I'll update that. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5430#issuecomment-2740122292 You are receiving this because

Re: [openstreetmap/openstreetmap-website] Cannot calculate any directions in Firefox – Uncaught TypeError: OSM.i18n.currentLocale is not a function (Issue #5821)

2025-03-20 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5821) Yes it was caused by that update but updates aren't automatically deployed to production when they're merged here - that happens manually usually every day or two. -- Reply to this email directly or view it on GitHub: https://

Re: [openstreetmap/openstreetmap-website] Switch to dynamic allocation for the Firefox bidi port (PR #5820)

2025-03-20 Thread Openstreetmapler via rails-dev
Openstreetmapler left a comment (openstreetmap/openstreetmap-website#5820) My issue is now fixed … it was caused by the recent i18n update: #5811 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5820#issuecomment-2740300801 You ar

Re: [openstreetmap/openstreetmap-website] Cannot calculate any directions in Firefox – Uncaught TypeError: OSM.i18n.currentLocale is not a function (Issue #5821)

2025-03-20 Thread Openstreetmapler via rails-dev
Openstreetmapler left a comment (openstreetmap/openstreetmap-website#5821) Thank you a lot for the quick fix! I really appreciate your time! 😊 (However, why did it still work one day before reporting the issue? I suspect it was caused by upstream changes to i18n since dependencies were updated

Re: [openstreetmap/openstreetmap-website] Set dir="auto" on changeset comment bodies (Issue #5785)

2025-03-20 Thread Andy Allan via rails-dev
Closed #5785 as duplicate. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5785#event-16907949306 You are receiving this because you are subscribed to this thread. Message ID: ___ rai

Re: [openstreetmap/openstreetmap-website] Set dir="auto" on changeset comment bodies (Issue #5785)

2025-03-20 Thread Andy Allan via rails-dev
gravitystorm left a comment (openstreetmap/openstreetmap-website#5785) Duplicate of #3428 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5785#issuecomment-2740265238 You are receiving this because you are subscribed to this thr

Re: [openstreetmap/openstreetmap-website] Issues with the Redesign on Mobile Phones (#557)

2025-03-20 Thread Andy Allan via rails-dev
gravitystorm left a comment (openstreetmap/openstreetmap-website#557) Fixed by https://github.com/openstreetmap/openstreetmap-website/pull/4133 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/557#issuecomment-2740258100 You are

Re: [openstreetmap/openstreetmap-website] Update to rails 8 (PR #5430)

2025-03-20 Thread Andy Allan via rails-dev
Merged #5430 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5430#event-16907147953 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Update to rails 8 (PR #5430)

2025-03-20 Thread Andy Allan via rails-dev
gravitystorm left a comment (openstreetmap/openstreetmap-website#5430) Thanks! Merged now. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5430#issuecomment-2740190320 You are receiving this because you are subscribed to this thre

Re: [openstreetmap/openstreetmap-website] Update to rails 8 (PR #5430)

2025-03-20 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5430) Ah I had actually re-enabled the gem but forgot to uncomment the config again. Now fixed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5430#issuecomment-27401

Re: [openstreetmap/openstreetmap-website] Update to rails 8 (PR #5430)

2025-03-20 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5430) Oh think I forgot about that... Will have to investigate. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5430#issuecomment-2740119238 You are receiving this beca

Re: [openstreetmap/openstreetmap-website] Update to rails 8 (PR #5430)

2025-03-20 Thread Andy Allan via rails-dev
gravitystorm left a comment (openstreetmap/openstreetmap-website#5430) All looks good to me, just need to clarify what's happening with canonical_rails. This PR has the config completely commented out. Is the config no longer necessary, or is the gem not working? -- Reply to this email directl

Re: [openstreetmap/openstreetmap-website] Map Data checkbox: perhaps use toggle slider instead (PR #5009)

2025-03-20 Thread Roman Deev via rails-dev
deevroman left a comment (openstreetmap/openstreetmap-website#5009) > For CPU slowdown I use browser built-in functionality. Ah, chromium, got it. 20x slowdown is unrealistic. With this value, I can't move the map normally, even without the data layer. But even with 20x slowdown, the layer with