tomhughes left a comment (openstreetmap/openstreetmap-website#5821)
No actually it's specific to graphhopper and valhalla and doesn't happen with
OSRM routes.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5821#issuecomment-27
hlfan left a comment (openstreetmap/openstreetmap-website#5826)
This might also close #568 too.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5826#issuecomment-2738850060
You are receiving this because you are subscribed to this
@hlfan commented on this pull request.
> +changesetIntersectionObserver = new IntersectionObserver((entries) => {
+ if (ignoreIntersectionEvents) {
+ignoreIntersectionEvents = false;
+return;
+ }
+
+ let closestTargetToTop,
+ closestDistanceToTop = Inf
@AntonKhorev commented on this pull request.
> +changesetIntersectionObserver = new IntersectionObserver((entries) => {
+ if (ignoreIntersectionEvents) {
+ignoreIntersectionEvents = false;
+return;
+ }
+
+ let closestTargetToTop,
+ closestDistanceToTop
@hlfan commented on this pull request.
> +changesetIntersectionObserver = new IntersectionObserver((entries) => {
+ if (ignoreIntersectionEvents) {
+ignoreIntersectionEvents = false;
+return;
+ }
+
+ let closestTargetToTop,
+ closestDistanceToTop = Inf
@hlfan pushed 2 commits.
2927f45b41b891cfe86e24da124e8d8eb91155a6 Add default value for parseHash
583cb3e20b70aada20d5ea48b11dfad9634a14ad Use search params without
objectification
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5825/files/e6604e07108a7b4fc47
hlfan left a comment (openstreetmap/openstreetmap-website#557)
I think since the controls wrap it's solved?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/557#issuecomment-2738597661
You are receiving this because you are subsc
@hlfan commented on this pull request.
> +changesetIntersectionObserver = new IntersectionObserver((entries) => {
+ if (ignoreIntersectionEvents) {
+ignoreIntersectionEvents = false;
+return;
+ }
+
+ let closestTargetToTop,
+ closestDistanceToTop = Inf
tomhughes left a comment (openstreetmap/openstreetmap-website#5820)
It also hasn't been deployed yet!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5820#issuecomment-2737465744
You are receiving this because you are subscribed t
The goal here is when viewing history to be able to go back to roughly the same
place after visiting a changeset page. It works like this:
- when the changeset list is scrolled down and some item leaves the viewport,
the current page location gets changed to include a `before=:changeset_id`
para
tomhughes left a comment (openstreetmap/openstreetmap-website#5823)
It's a bit nasty but I don't see a better solution - the ideal would be that
the server forces a full page reload when it needs to redirect the id frame to
the login but that isn't possible for obvious reasons because of the sec
@AntonKhorev pushed 5 commits.
c467653e9b50e522ccd775682e579d76804126d1 Rewrite history page url when
scrolling
794e19db7a23c61768a880332e6fb536e2f09106 Scroll to first/last changeset in
history list if before/after param is given
07e69d3da2c4114b73f7a9dc8eb740a9320d049b Rename changeset load
tomhughes left a comment (openstreetmap/openstreetmap-website#5824)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5824#issuecomment-2737774611
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5824)
I'm not really sure why it's doing that... There an aspiration to separate API
calls onto a separate domain which I guess is the reason but we've never got
anywhere near making it a reality.
--
Reply to this email directly or
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5824)
Why do we have to replace substrings in urls?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5824#issuecomment-2738337547
You are receiving this because you ar
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5825)
How about we remove `OSM.params` instead?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5825#issuecomment-2738114613
You are receiving this because you are su
aceman444 left a comment (openstreetmap/openstreetmap-website#5769)
The future dates are also used in the string 'Osm:Notes.show.disappear date
html' (This resolved note will disappear from the map in %{disappear_in}.), so
this may be more visible to the users than in the user blocks page.
--
Merged #5824 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5824#event-16876456770
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@hlfan pushed 1 commit.
e6604e07108a7b4fc477fae86f7f99af75d8c3b4 Shorten OSM.params and URLSearchParams
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5825/files/9a3f9ea37bbebf5e1e9c0db0e55d4d3c60bd416b..e6604e07108a7b4fc477fae86f7f99af75d8c3b4
You are receivi
@tomhughes pushed 4 commits.
8c4d380e32d05598f0f1e25f6fcec5df5b46c61e Update to rails 8.0.2
590e30caec804b9029c544e6f5c9e374c560fc34 Replace permit/require with expect
for parameter validation
dafdfeceaa50af2b539c8654ae1738abeab4284a Avoid parsing of XML requests with ;
in the body
ab030b54c0
- Replaces `new URLSearchParams(location.search)` with `OSM.params()` when it
yields more concise code.
- All remaining URLSearchParams that aren't initialized empty or with an
object use .toString().
- Adds `location.hash` as a default parameter for `OSM.parseHash`.
- Moves the fallback for
Removes hard-coding of URLs, e.g. not forcing a protocol onto the user.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5824
-- Commit Summary --
* Make URLs more relative
-- File Changes --
M app/assets/javasc
Openstreetmapler left a comment (openstreetmap/openstreetmap-website#5821)
Found a likely culprit:
#5820 includes some Firefox-specific changes which are related to `bidi`
(bidirectionality of text), i.e. a locale-related thing.
--
Reply to this email directly or view it on GitHub:
https://gith
@tomhughes pushed 1 commit.
843f6c492750fe56ec72fa4fbcbb31b2288a760b Allow users to delete their own diary
entries
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4540/files/11a59aadfb8cf32de0808f8f8d98212cf9b21582..843f6c492750fe56ec72fa4fbcbb31b2288a760b
You
Closed #5807 as completed via #5823.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5807#event-16875830029
You are receiving this because you are subscribed to this thread.
Message ID:
_
hlfan left a comment (openstreetmap/openstreetmap-website#5823)
I also considered replacing the already-loaded content, but that would probably
have become more nasty.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5823#issuecom
@hlfan pushed 1 commit.
adb034d26e6f465d07c75a2fcfd3477c38539c4f Add reload on iframe redirect
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5823/files/99e73ddf81496eb2110c64f930d4288776cb45f3..adb034d26e6f465d07c75a2fcfd3477c38539c4f
You are receiving this b
In some cases, an expired session only causes the window in the iframe to
reload on the `/edit` page.
This fixes #5807 (the issue for that bug)
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5823
-- Commit Summary --
@tomhughes pushed 4 commits.
6242c45f3843624fccfaad243652a26c7ba3b39a Update to rails 8.0.1
20afaec9db837ed08bbb01bf8ffd9fc7073ab604 Replace permit/require with expect
for parameter validation
54d3584a2e03fd92cd618733fb7731e0fdeedb08 Avoid parsing of XML requests with ;
in the body
b415250d7e
@tomhughes pushed 1 commit.
da0577a4205305b801ab9e742cad10cd8def842c Filter out invisible nodes and ways
during initial selection
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5589/files/6f887001dec8a31da29ee3a17d64549511d21bff..da0577a4205305b801ab9e742cad1
@tomhughes pushed 1 commit.
c7d04440b62e9bff96eef0b75a3b3d765fa69910 Make account deletion remove the
email address when possible
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3488/files/f7a852942eee4a596578ddd270ec2bc3606dd58c..c7d04440b62e9bff96eef0b75a3b3
tomhughes left a comment (openstreetmap/openstreetmap-website#5821)
Yes and `bidi` there is not about bidirectional text but about the
bidirectional control port used to drive the browser automatically during
testing.
In any case this is clearly something specific to the user's environment or
Merged #5818 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5818#event-16873865923
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5812)
Looks good to me, thanks, and we can always change the labels later if we want.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5812#issuecomment-2737540144
You a
Removes the usage of the `currentLocale` function since the update to I18n v4
in #5811 which fixes #5821
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5822
-- Commit Summary --
* Get current locale without functio
@tomhughes approved this pull request.
Thanks. This looks good to me now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5818#pullrequestreview-2699492936
You are receiving this because you are subscribed to this thread.
Messa
tomhughes left a comment (openstreetmap/openstreetmap-website#5822)
Thanks for the fix, but I just pushed 949c5276091f35e77796d39a4ed024dd2ea9f7da
to fix this.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5822#issuecomment-273
Closed #5822.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5822#event-16873636646
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Openstreetmapler left a comment (openstreetmap/openstreetmap-website#5820)
> I think this pull request completely broke route planning in Firefox, as
> there’s now a missing `currentLocale` function: #5821
Seems to be unlikely, as this is just related to the testing framework …
https://github.c
Openstreetmapler left a comment (openstreetmap/openstreetmap-website#5820)
I think this pull request completely broke route planning in Firefox, as
there’s now a missing `currentLocale` function:
https://github.com/openstreetmap/openstreetmap-website/issues/5821
--
Reply to this email directly
Openstreetmapler created an issue (openstreetmap/openstreetmap-website#5821)
### URL
https://www.openstreetmap.org/directions?engine=fossgis_valhalla_car&route=42.038752%2C13.626598%3B42.038752%2C13.626598#map=19/42.038804/13.627943
### How to reproduce the issue?
Go to the above URL. The route
gravitystorm left a comment (openstreetmap/openstreetmap-website#5820)
Merged, thanks
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5820#issuecomment-2737282084
You are receiving this because you are subscribed to this thread.
Merged #5820 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5820#event-16871421060
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
nenad-vujicic left a comment (openstreetmap/openstreetmap-website#5815)
It would be great if we could get some comments on this. Do we want note
versions architecture like for other elements (`nodes`, `ways`, ..) or
something simpler? After this PR we will add creating new note versions when
no
deevroman left a comment (openstreetmap/openstreetmap-website#5009)
What do you use to test CPU slowdowns? Test rendering >4k features.
Can you give us an example of when the user has time to notice the browser
hanging, while making the user guess that they are waiting for rendering, and
not do
nertc left a comment (openstreetmap/openstreetmap-website#5009)
You are right, I thought, it disabled both asynchronous functionalities.
I pulled `master` and tested turning asynchronous loading off.
1. About flash: it is because data is loaded asynchronously and as everything
is rendered one by
@nertc commented on this pull request.
> +locationInput = {
+ dirty: false,
+ requestController: null,
+ countryName: $("#location_name").val().trim(),
+ deletedText: null,
+ checkLocation: savedLat && savedLon && $("#location_name").val().trim()
+};
I created a
deevroman left a comment (openstreetmap/openstreetmap-website#5009)
@nertc no, https://github.com/openstreetmap/openstreetmap-website/pull/5799
disabled asynchrony not for the Map Data layer, but for the layer that shows
the active object.
--
Reply to this email directly or view it on GitHub:
@nertc commented on this pull request.
> @@ -12,6 +12,7 @@
# home_lat :float
# home_lon :float
# home_zoom:integer default(3)
+# location_name:string
`location_name` was updated and renamed as `home_location_name`.
--
Reply to this e
nertc left a comment (openstreetmap/openstreetmap-website#5009)
@deevroman Thank you for your feedback. #5799 disabled asynchronous layer
loading and, therefore, there shouldn't be any flashes or slow rendering
process anymore.
--
Reply to this email directly or view it on GitHub:
https://gith
@nertc commented on this pull request.
> @@ -176,6 +206,64 @@ $(document).ready(function () {
}
}
+ function updateHomeLocation(updateInput = true, lat =
$("#home_lat").val().trim(), lon = $("#home_lon").val().trim(), successFn) {
`respondToHomeUpdate` was changed with `respondToHom
@k-yle pushed 1 commit.
d2645df847f746aadab8dd13eb4e24ed836b4d28 update-wiki-pages: process
ChangesetKey template
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5818/files/1bd348b1eb852e3f5618be78c4fdd52c887e8db9..d2645df847f746aadab8dd13eb4e24ed836b4d28
You
As pointed out in
https://github.com/mozilla/geckodriver/issues/2218#issuecomment-2735625538 you
can use port zero to ask Firefox to dynamically allocate a port which should
make this more robust as well as much simpler.
You can view, comment on, or merge this pull request online at:
https://
@k-yle commented on this pull request.
> @@ -8,6 +8,7 @@ use Pod::Usage;
use MediaWiki::API;
use Test::More qw(no_plan);
use YAML::XS qw(Dump);
+# NOTE: on macos, LWP::Protocol::https also needs to be installed
thanks for the explaination, I've removed this comment
--
Reply to this email d
@tomhughes commented on this pull request.
> @@ -8,6 +8,7 @@ use Pod::Usage;
use MediaWiki::API;
use Test::More qw(no_plan);
use YAML::XS qw(Dump);
+# NOTE: on macos, LWP::Protocol::https also needs to be installed
There's nothing macos specific about that - the https protocol handler is in
55 matches
Mail list logo
