DavidKarlas left a comment (openstreetmap/openstreetmap-website#5812)
Should existing button be renamed to "Load older" and new button to "Load
newer"? Just idea...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5812#issuecommen
@nenad-vujicic approved this pull request.
This works great on my side! Although most modern websites do not implement
this feature, between usability (mostly for moderators) and keeping stable
visual harmony I vote for usability. Thanks!
--
Reply to this email directly or view it on GitHub:
1ec5 left a comment (openstreetmap/openstreetmap-website#5819)
Right, I’ve definitely found this test useful. I’ll have to look into why it
isn’t running on Translatewiki.net PRs like OpenHistoricalMap/ohm-website#276.
I recall you’ve periodically had to go into osm-community-index to report
is
Closed #5819 as not planned.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5819#event-16852904738
You are receiving this because you are subscribed to this thread.
Message ID:
___
r
emakarov left a comment (openstreetmap/openstreetmap-website#4319)
> ```
> PG::ActiveSqlTransaction: ERROR: ALTER TYPE ... ADD cannot run inside a
> transaction block
> /app/config/initializers/migrate.rb:55:in `add_enumeration_value'
> /app/db/migrate/20231029151516_add_importer_role.rb:3:in `u
tomhughes left a comment (openstreetmap/openstreetmap-website#5819)
Here's an example, with a resource that exists in `fr` but not in `ga`:
```
open-street-map(dev)> I18n.t("redactions.edit.heading", :locale => "fr")
=> "Modifier le masquage"
open-street-map(dev)> I18n.t("redactions.edit.heading"
tomhughes left a comment (openstreetmap/openstreetmap-website#5819)
It's
https://github.com/openstreetmap/openstreetmap-website/blob/9e3f9aa353fc48d994d52b3a17d02be3b81fc7f6/test/lib/i18n_test.rb#L4-L56
which does the check by making sure that each language only uses interpolation
variables whi
1ec5 left a comment (openstreetmap/openstreetmap-website#5819)
Sorry, the title of the issue was misleading; I changed it. This is
specifically about when a string in the YAML file includes a `%{foo}` but `foo`
isn’t one of the arguments passed into `I18n.t`.
--
Reply to this email directly or
tomhughes left a comment (openstreetmap/openstreetmap-website#5819)
Missing translations do fall back to english - what make you think they don't?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5819#issuecomment-2734882038
You
1ec5 created an issue (openstreetmap/openstreetmap-website#5819)
Fall back to English when a string is missing from the localization or the
translation refers to a nonexistent interpolation argument.
## Rationale
Sometimes a localizable string has to get changed to a different ID whenever
the
@hlfan pushed 1 commit.
1819a90efbf8c52ea359c524ea30d6d9fd92734d Add PWA geo protocol handler
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5736/files/37f32c74844eb44c5c8c2fc8ae15c1f8736c2d75..1819a90efbf8c52ea359c524ea30d6d9fd92734d
You are receiving this be
hlfan left a comment (openstreetmap/openstreetmap-website#5736)
I'm now choosing the zoom parameter differently so even if a parameter value
ending with `&z` gets parsed wrong (it couldn't be in the parameter name anyway
and `=` isn't allowed in values) that won't affect the ability to use the l
@hlfan commented on this pull request.
>mapParams = {};
+[geoURI.coordstring, ...geoURI.params] = geoURI.pathname.split(";");
+geoURI.params = Object.fromEntries([...geoURI.searchParams,
...geoURI.params.map(p => p.split("=").map(decodeURIComponent))]);
I'm now using `URL
gravitystorm left a comment (openstreetmap/openstreetmap-website#5797)
Thanks both!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5797#issuecomment-2734350231
You are receiving this because you are subscribed to this thread.
Me
@tomhughes requested changes on this pull request.
I'm not sure why you say union is hard? We have
https://github.com/brianhempel/active_record_union installed already so you can
just use the `union` or `union_all` method on a relation to merge it with
another one?
> + # Common SQL for activi
nenad-vujicic left a comment (openstreetmap/openstreetmap-website#5815)
Merged migration scripts into one (by moving creating foreign key into
`create_table`), added redaction record to `note_versions` and associations to
model files for easier incoming PRs, also removed unnecessary default valu
@nenad-vujicic pushed 1 commit.
b3a6d591b46beb000e8a48d67e9fabe309e955c5 Adds note versioning and adds
note_versions table
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5815/files/f65aea0814006ffd97462d1c08be65542474d6e3..b3a6d591b46beb000e8a48d67e9fabe309e9
gravitystorm left a comment (openstreetmap/openstreetmap-website#5539)
@rkoeze Yes, that one definitely needs some refactoring!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5539#issuecomment-2732628902
You are receiving this
@AntonKhorev commented on this pull request.
> +geoURI.epsg = geoURI.params.crs?.toUpperCase()?.replace(":", "");
+if (geoURI.epsg?.startsWith("EPSG")) {
+ geoURI.coords =
L.CRS.EPSG3857.unproject(L.CRS[geoURI.epsg]?.project(geoURI.coords));
+}
`crs` can't even be `EPSG:someth
@AntonKhorev commented on this pull request.
> @@ -80,6 +80,10 @@ OSM = {
const hash = OSM.parseHash(location.hash);
+const geoURI = Object.fromEntries(new URLSearchParams(
+ params.geouri?.replaceAll(/[?;]/g, "&")?.replaceAll(":", "=")
Looks like the example I copied from Wik
@AntonKhorev commented on this pull request.
> +geoURI.epsg = geoURI.params.crs?.toUpperCase()?.replace(":", "");
+if (geoURI.epsg?.startsWith("EPSG")) {
+ geoURI.coords =
L.CRS.EPSG3857.unproject(L.CRS[geoURI.epsg]?.project(geoURI.coords));
+}
Is it just an excuse to parse al
@AntonKhorev commented on this pull request.
>mapParams = {};
+[geoURI.coordstring, ...geoURI.params] = geoURI.pathname.split(";");
+geoURI.params = Object.fromEntries([...geoURI.searchParams,
...geoURI.params.map(p => p.split("=").map(decodeURIComponent))]);
Why would yo