hlfan left a comment (openstreetmap/openstreetmap-website#5764)
I've decided to reduce this PR to just the conversion of the SVG pins. While
modularizing and parametrizing the markers is a commendable effort, it
shouldn't be part of this PR, but the next step instead.
I've removed from this PR:
rkoeze left a comment (openstreetmap/openstreetmap-website#5539)
Hi @gravitystorm. I think the `ConfirmationsController` is decent candidate for
a RESTful refactor. Unless you're opposed I'll throw up a PR doing that?
--
Reply to this email directly or view it on GitHub:
https://github.com/open
Merged #5811 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5811#event-16817247354
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5811)
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5811#issuecomment-2731362529
You are receiving this because you are subscribed to this thread.
hlfan left a comment (openstreetmap/openstreetmap-website#3123)
> * there is no clue of what the dropdown is for, what OSRM, GraphHopper, and
> Valhallah are
Do you think an `optgroup` with a `label` and a `title` on the `select` would
be enough hints?
> * adding a short message to advertise th
tomhughes left a comment (openstreetmap/openstreetmap-website#5817)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5817#issuecomment-2730340542
You are receiving this because you are subscribed to this t
Merged #5817 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5817#event-16811554114
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5814 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5814#event-16811554092
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
>
// '-' are replaced with '_' in
https://github.com/eemeli/make-plural/tree/main/packages/plurals
const pluralizer = plurals[locale.replace(/\W+/g, "_")] ||
plurals[locale.split("-")[0]];
if (pluralizer) {
-I18n.pluralization[locale] =
tomhughes left a comment (openstreetmap/openstreetmap-website#5814)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5814#issuecomment-2730330356
You are receiving this because you are subscribed to this t
@tomhughes commented on this pull request.
>
// '-' are replaced with '_' in
https://github.com/eemeli/make-plural/tree/main/packages/plurals
const pluralizer = plurals[locale.replace(/\W+/g, "_")] ||
plurals[locale.split("-")[0]];
if (pluralizer) {
-I18n.pluralization[locale] =
@tomhughes pushed 3 commits.
453a28653174616843c651c0bbce4ebfaf90cb90 Add OSM.i18n as an alias for I18n
e2e61692ea04fc156221082aeddc21ea18facdec Replace use of I18n in javascript
with OSM.i18n
d52c7943f24aae4ede55f1ef055af415dcf3da59 Update to i18n-js 4.x
--
View it on GitHub:
https://github
Closed #5352 via #5809.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5352#event-16791863337
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-de
AntonKhorev left a comment (openstreetmap/openstreetmap-website#3123)
> > * there is no clue of what the dropdown is for, what OSRM, GraphHopper, and
> > Valhallah are
>
> Do you think an `optgroup` with a `label` and a `title` on the `select` would
> be enough hints?
`optgroup` is probably a
Before / after:
- Adds more space between Close and Reverse buttons. See "The close button
is a bit too close the r
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5816)
I can see these without any changes:
--
Repl
@AntonKhorev commented on this pull request.
>
// '-' are replaced with '_' in
https://github.com/eemeli/make-plural/tree/main/packages/plurals
const pluralizer = plurals[locale.replace(/\W+/g, "_")] ||
plurals[locale.split("-")[0]];
if (pluralizer) {
-I18n.pluralization[locale]
@nenad-vujicic approved this pull request.
This works great on my side, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5814#pullrequestreview-2691039092
You are receiving this because you are subscribed to this thread.
Add intellisense for calHeatmap
The type annotations of the cal-heatmap file is not very good, but still useful:
You can view, comment on, or merge this pull request online at:
https://github.com/openstr
nenad-vujicic left a comment (openstreetmap/openstreetmap-website#5815)
> The only thing that can actually change over time is the (proposed) tags
> right?
At the moment, yes. But, why not allowing updating description, position, ...,
creating / updating by sending XML / JSON with entire note's
tomhughes left a comment (openstreetmap/openstreetmap-website#5815)
The only thing that can actually change over time is the (proposed) tags right?
So is the OSM data model of copying everything the right approach?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstr
### Description
PR adds `version` column to `notes` table for keeping version number of the
latest note's version and creates `note_versions` table for keeping all
notes versions. This is based on [this
comment](https://github.com/openstreetmap/openstreetmap-website/issues/5294#issuecomment-254
22 matches
Mail list logo
