@AntonKhorev pushed 4 commits.
582b7d6ace2f4e951d9f2a290fd4bd97f454e6bf Add 'after' parameter to history pages
a27790361367772bacc05a70b080b1e47f2274fc Preserve sidebar scroll position when
prepending to history
6075d8fdf592ed185ec779f9d45938a927fecbb5 Rewrite history page url when
scrolling
@tomhughes approved this pull request.
This looks good now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5809#pullrequestreview-2688772612
You are receiving this because you are subscribed to this thread.
Message ID:
#5805 added links to heatmaps, but those weren't real links. Those were
click listeners that rewrite page locations. The browser won't show their
urls and they can't be opened in new tabs.
This PR creates real links by wrapping svg rectangles in `` elements.
Well technically this issue suggests including note comments as well, which are
there, but on a separate link.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/
Dimitar left a comment (openstreetmap/openstreetmap-website#1148)
This issue, along with #842 should be marked as resolved by #5518.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/1148#issuecomment-2727658311
You are receiv
This removes the workaround from #5661 that has become unnecessary with #5750
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5813
-- Commit Summary --
* Remove workaround for iD 2.31
-- File Changes --
M app/a
tomhughes left a comment (openstreetmap/openstreetmap-website#5811)
I've split this as suggested so that the mass renaming can be done first and
then the functional changes.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5811#is
Merged #5809 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5809#event-16791863281
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
> @@ -0,0 +1,19 @@
+module MapLayers
+ def self.full_definitions(layers_filename)
+YAML.load_file(Rails.root.join(layers_filename)).filter_map do |layer|
Err... I guess... Which is why I hate that sort of control flow :-(
--
Reply to this email
@tomhughes pushed 1 commit.
cc525cdf2a47f9807ce71cc4722265d8c344122f Update to i18n-js 4.x
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5811/files/6ea3991de6ee0fc78335663a6a33f611d1304efb..cc525cdf2a47f9807ce71cc4722265d8c344122f
You are receiving this becau
@hlfan pushed 1 commit.
6ecfab90271916c806c91aff51b9e395529fcf4a Put api keys directly in js layer
definitions
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5809/files/07fe4034e95bf14d2b74650420c0c6b9df1141a0..6ecfab90271916c806c91aff51b9e395529fcf4a
You are
@hlfan pushed 1 commit.
37f32c74844eb44c5c8c2fc8ae15c1f8736c2d75 Add PWA geo protocol handler
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5736/files/c1d8ed666a8f81a514a2700d052234753b6a2351..37f32c74844eb44c5c8c2fc8ae15c1f8736c2d75
You are receiving this be
@hlfan pushed 1 commit.
4073971014485b09c0f301267b5043ce24822d53 Remove u-turn side decision
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5777/files/c685d6d38c4bd3d749f5aeaae86386eb0d317e09..4073971014485b09c0f301267b5043ce24822d53
You are receiving this bec
@hlfan pushed 1 commit.
1ade2335b9ca186e7b123d728591f8c768ddb6ee Reuse mirrored turn icons
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5776/files/3b2a19061408101621ce12c81702fd267dba64c7..1ade2335b9ca186e7b123d728591f8c768ddb6ee
You are receiving this becau
@hlfan pushed 2 commits.
1552910828676ea71b27745099f99f5203bf2d88 Name markers uniformly
278a0c41365a3d5e5cb5a124e1f4583ad952d9ca Overhaul markers
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5764/files/9197668276d899726ead8b00802f06fd50e2488e..278a0c41365a
@hlfan pushed 4 commits.
bc508673e788ce8c00cf2f030261f733184c2177 Unify active control button behaviour
bc405e7ca14374523346c2bd25712521b7225192 Set fixthemap note link in template
a84751f1c135ced546f05d53473eb2050db83ea9 Click links instead of icons in tests
5fbbc4801b6c1e0ed258526f55043bfcc69
@AntonKhorev pushed 1 commit.
2ca7a67a4013a8b6da45336ddeaf1288ffb72f38 WIP eslint
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5808/files/cf1a2e7ebe7f3e99781934ad4c8deabd4dd51e6d..2ca7a67a4013a8b6da45336ddeaf1288ffb72f38
You are receiving this because you ar
@hlfan pushed 1 commit.
c1d8ed666a8f81a514a2700d052234753b6a2351 Add PWA geo protocol handler
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5736/files/7fb4fb7663524893340b30710283d605915b508a..c1d8ed666a8f81a514a2700d052234753b6a2351
You are receiving this be
If you get to the user's history page from the heatmap, it will start on a
selected date. You can scroll down, press *Load more* and and load changesets
that were created before the initially visible set. But what if you want to see
changesets created after the date?
This PR adds a *Load more*
@tomhughes pushed 1 commit.
6ea3991de6ee0fc78335663a6a33f611d1304efb Update to i18n-js 4.x
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5811/files/93fab10f6e606e14a867bac1f5a990d22c41cd6d..6ea3991de6ee0fc78335663a6a33f611d1304efb
You are receiving this becau
hlfan left a comment (openstreetmap/openstreetmap-website#5811)
How about instanciating i18n or even just aliasing `OSM.i18n = { t: I18n.t }`
in a separate commit first so the main version upgrade can be a smaller commit?
--
Reply to this email directly or view it on GitHub:
https://github.com/
@hlfan commented on this pull request.
> @@ -0,0 +1,19 @@
+module MapLayers
+ def self.full_definitions(layers_filename)
+YAML.load_file(Rails.root.join(layers_filename)).filter_map do |layer|
I split the filtering and mapping up (from phone, hence no squash).
--
Reply to this email dire
@hlfan pushed 1 commit.
07fe4034e95bf14d2b74650420c0c6b9df1141a0 Fix indentation
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5809/files/a132b837cfce4931a4c4d3b819ddb6f0bdf34493..07fe4034e95bf14d2b74650420c0c6b9df1141a0
You are receiving this because you are
@hlfan pushed 1 commit.
a132b837cfce4931a4c4d3b819ddb6f0bdf34493 Clear up MapLayers control flow
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5809/files/fc878e3c019f7e06ea5e7c811bde6ae2425c5bf1..a132b837cfce4931a4c4d3b819ddb6f0bdf34493
You are receiving this
@AntonKhorev pushed 5 commits.
8a65f551a71e92052107805c03ad687697d375e3 Add 'after' parameter to history pages
9880953e9191777574141adfb4fa340589c5a7a4 Preserve sidebar scroll position when
prepending to history
4caf285c5c346fe70c9f24934ad06916528e92a3 WIP intersect with visible
e4d27dd1c05a9d
@tomhughes pushed 1 commit.
93fab10f6e606e14a867bac1f5a990d22c41cd6d Update to i18n-js 4.x
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5811/files/37dfb402cfe3d8e6429f80ebacbe37ae97fef158..93fab10f6e606e14a867bac1f5a990d22c41cd6d
You are receiving this becau
@tomhughes pushed 1 commit.
37dfb402cfe3d8e6429f80ebacbe37ae97fef158 Update to i18n-js 4.x
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5811/files/aa75a1ec628fe387342bce58f90ca14bc6c3714e..37dfb402cfe3d8e6429f80ebacbe37ae97fef158
You are receiving this becau
This updates i18n-js to the 4.x branch which requires quite a bit of
re-engineering due to upstream API changes.
Although this looks quite large the vast majority of it is just replacement of
`I18n.t` with `OSM.i18n.t` as you now need to instantiate an instance of I18n
instead of just using glo
@hlfan commented on this pull request.
> @@ -0,0 +1,19 @@
+module MapLayers
+ def self.full_definitions(layers_filename)
+YAML.load_file(Rails.root.join(layers_filename)).filter_map do |layer|
I understood it as the `next` in line 5 makes it returns `nil`, and therefore
the `filter_map`.
@tomhughes pushed 1 commit.
6f887001dec8a31da29ee3a17d64549511d21bff Filter out invisible nodes and ways
during initial selection
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5589/files/ff0c1b492a966b183d8a03f47bc4b8c9f598418d..6f887001dec8a31da29ee3a17d645
@tomhughes commented on this pull request.
> @@ -0,0 +1,19 @@
+module MapLayers
+ def self.full_definitions(layers_filename)
+YAML.load_file(Rails.root.join(layers_filename)).filter_map do |layer|
This isn't actually doing any filtering it is? The block always returns a
"truthy" value so
Merged #5805 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5805#event-16791358522
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5802 as completed via #5806.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5802#event-16791358588
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5796 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5796#event-16791358519
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5806 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5806#event-16791358517
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5796)
I don't normally self-merge things but nobody has spotted any problems with
this and it's getting annoying seeing a sea of red in the PR queue so I'm going
to merge and if anybody spots a problem we can fix it later.
--
Reply
tomhughes left a comment (openstreetmap/openstreetmap-website#5805)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5805#issuecomment-2727498726
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5806)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5806#issuecomment-2727479794
You are receiving this because you are subscribed to this t
42 matches
Mail list logo
