[openstreetmap/openstreetmap-website] Add space and headline to user profile heatmap (Issue #5810)

2025-03-15 Thread Tobias via rails-dev
tordans created an issue (openstreetmap/openstreetmap-website#5810) I am very happy to see https://github.com/openstreetmap/openstreetmap-website/pull/5402 merged and live. Congratulations! I want to suggest to add a bit of space, a headline and maybe a subheadline above the new element to gi

Re: [openstreetmap/openstreetmap-website] Duplicate header displayed after resuming browser session (Issue #5807)

2025-03-15 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#5807) If the browser caches only /edit but not /id in the iframe, having a check in the js of /edit if the iframe got redirected (like [this](https://stackoverflow.com/a/10301551)) and if so reloading the page would be a relatively simpl

[openstreetmap/openstreetmap-website] Put api keys directly in js layer definitions (PR #5809)

2025-03-15 Thread Marwin Hochfelsner via rails-dev
### Description This PR expands on and closes #5352, building onto the `MapLayers` library and also reusing the keys for the embed layer selection (`leafletOsmId` instead of `layer`). ### How has this been tested? Only the difference to #5352 You can view, comment on, or merge this pull request

[openstreetmap/openstreetmap-website] Add 'Load more' button that loads newer changesets to history pages (PR #5808)

2025-03-15 Thread Anton Khorev via rails-dev
Going to be useful if #5805 is merged. ![image](https://github.com/user-attachments/assets/433f9fd4-3ca1-49ef-ada5-930854f46e0b) You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5808 -- Commit Summary -- * Switch fr

Re: [openstreetmap/openstreetmap-website] Add links to days in user history from heatmap (PR #5805)

2025-03-15 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 3 commits. 02f5b0a81893dc8b1a63e7e0f134ac10905a992e Add 'before' parameter to history pages 788bcf41b33e3966aa3843914a94c911aa2b9af2 Add links to days in user history from heatmap bc88c730e212700ecef7e4589d451de975410b25 Change cursor to pointer on nonempty calendar cells

Re: [openstreetmap/openstreetmap-website] Add links to days in user history from heatmap (PR #5805)

2025-03-15 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 4 commits. dddb6eba3cee47e14cbafa75048f157f16a27682 Switch from 'max_id' to 'before' parameter in history lists 1f274481b28a2a6e72f45761e9863c3164c21f38 Add 'before' parameter to history pages f09ae6685a28e1a99eeaa5a05c0484626dd045ea Add links to days in user history from

Re: [openstreetmap/openstreetmap-website] Overhaul markers (PR #5764)

2025-03-15 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#5764) > Still haven't done gradients. I've also fiddled around a bit, trying to make a marker-based solution [here](https://codepen.io/hlfan/pen/OPJOGxg). Still trying to get rid of the mask as a gradient workaround. -- Reply to this em

[openstreetmap/openstreetmap-website] Duplicate header displayed after resuming browser session (Issue #5807)

2025-03-15 Thread danieldegroot2 via rails-dev
danieldegroot2 created an issue (openstreetmap/openstreetmap-website#5807) ### URL https://www.openstreetmap.org/edit?editor=id&relation=3121668#map=8/50.469/5.884 ### How to reproduce the issue? Minor visual bug. If my PC has been in sleep mode for long enough it has to revive the active appl

[openstreetmap/openstreetmap-website] Fix heatmap month titles in Western Hemisphere (PR #5806)

2025-03-15 Thread Anton Khorev via rails-dev
Fixes #5802 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5806 -- Commit Summary -- * Fix heatmap month titles in Western Hemisphere -- File Changes -- M app/assets/javascripts/heatmap.js (2) -- Patch Links

Re: [openstreetmap/openstreetmap-website] Write directions sidebar header using .erb template (PR #5754)

2025-03-15 Thread Tom Hughes via rails-dev
Merged #5754 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5754#event-16620261499 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Add links to days in user history from heatmap (PR #5805)

2025-03-15 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 2 commits. bcdaff68affd1e98857f6f107560e28d4e807159 Add links to days in user history from heatmap 02d29fa43ff122b19f906ccdecefce83a20da641 Change cursor to pointer on nonempty calendar cells -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pul

Re: [openstreetmap/openstreetmap-website] Sign-in > Sign in (Issue #5772)

2025-03-15 Thread Andy Allan via rails-dev
Closed #5772 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5772#event-16733951896 You are receiving this because you are subscribed to this thread. Message ID: ___ rai

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

2025-03-15 Thread Minh Nguyễn via rails-dev
@1ec5 commented on this pull request. > + +class SocialLink < ApplicationRecord + belongs_to :user + + validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :message => :http_parse_error } + + URL_PATTERNS = { +:bluesky => %r{\Ahttps?://(?:www\.)?bsky\.app/profile/([a-zA-Z0-9\._-]+)

Re: [openstreetmap/openstreetmap-website] opening https://www.openstreetmap.org/way/12432594/ link does not center map where way is (Issue #5798)

2025-03-15 Thread Tom Hughes via rails-dev
Closed #5798 as completed via #5799. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5798#event-16777680654 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [openstreetmap/openstreetmap-website] Add links to days in user history from heatmap (PR #5805)

2025-03-15 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. def7b3e049c297bfbe6ab3508b52a725799e755f Change cursor to pointer on nonempty calendar cells -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5805/files/3412ff3724da7a70c874d3e8267f5219480806c5..def7b3e049c297bfbe6ab3508b52a725799e

Re: [openstreetmap/openstreetmap-website] Add links to days in user history from heatmap (PR #5805)

2025-03-15 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. 3412ff3724da7a70c874d3e8267f5219480806c5 Add links to days in user history from heatmap -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5805/files/3a1c3b83874dd773e7da751ea6a71caffa699d6f..3412ff3724da7a70c874d3e8267f5219480806c5

Re: [openstreetmap/openstreetmap-website] Contribution heatmap is off by a month (Issue #5802)

2025-03-15 Thread Minh Nguyễn via rails-dev
1ec5 left a comment (openstreetmap/openstreetmap-website#5802) > Not sure if timezone would affect this, but I'm in UTC -4. Ah, that’s a good insight. I’m in UTC−7. Changing my system clock to UTC works around the issue: https://github.com/user-attachments/assets/ea4c16eb-c893-48d8-b085-4a2c72

[openstreetmap/openstreetmap-website] Add links to days in user history from heatmap (PR #5805)

2025-03-15 Thread Anton Khorev via rails-dev
Because navigating through user history is difficult, I wanted this: https://github.com/openstreetmap/openstreetmap-website/issues/5804#issuecomment-2726693156 This PR makes it that clicking on a nonempty calendar cell takes you to the corresponding day in the user's changeset history. You can

Re: [openstreetmap/openstreetmap-website] Remove u-turn side decision (PR #5777)

2025-03-15 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 1 commit. c685d6d38c4bd3d749f5aeaae86386eb0d317e09 Remove u-turn side decision -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5777/files/2db8892dc5f1b3fd2248265c9a06e472b825db23..c685d6d38c4bd3d749f5aeaae86386eb0d317e09 You are receiving this bec

Re: [openstreetmap/openstreetmap-website] Contribution heatmap is off by a month (Issue #5802)

2025-03-15 Thread Zeke Farwell via rails-dev
zekefarwell left a comment (openstreetmap/openstreetmap-website#5802) I can also reproduce the issue on every browser I've tried. So far I've tested the latest versions of: - Firefox on MacOS - Chrome on MacOS - Edge on MacOS - Safari on MacOS - Chrome on Android - Firefox on Android `I18n

[openstreetmap/openstreetmap-website] Order issue reports by id (PR #5786)

2025-03-15 Thread Anton Khorev via rails-dev
Reports on `/issue/:id` weren't sorted in any particular order. This is usually unnoticeable because typically they come in the creation order from the db. But that doesn't always happen. ![image](https://github.com/user-attachments/assets/6222ec71-9e42-4b63-89fc-2f4da6690c7e) This PR sorts the

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

2025-03-15 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5439) That seems to have been some glitch with the tests. I forced a rerun and they passed fine. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5439#issuecomment-2711

Re: [openstreetmap/openstreetmap-website] Use svg symbols for routing icons (PR #5753)

2025-03-15 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 4 commits. 18f03fe59b71d9eb08d7864b3d5b5a86c56e4972 Write directions sidebar header using .erb template 09b9108e7af5d45bac4904f7c8bafe468b33f345 Hide loader spinner when sidebar content is not displayed 929b499222ef905d7d67ee39e8ff96d7e6b6651e Move directions title out of

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

2025-03-15 Thread David Tsiklauri via rails-dev
nertc left a comment (openstreetmap/openstreetmap-website#5439) `master` was rebased. Conflicts were resolved. Tests have these errors: `Selenium::WebDriver::Error::UnknownError: Failed to decode response from marionette` `Selenium::WebDriver::Error::NoSuchWindowError: Browsing context has been

Re: [openstreetmap/openstreetmap-website] Dark Mode bugs/improvements for the UI (Issue #5329)

2025-03-15 Thread mp747474 via rails-dev
mp747474 left a comment (openstreetmap/openstreetmap-website#5329) Changesets with comments on them are too subtle in the changeset list: ![Image](https://github.com/user-attachments/assets/d8df9511-39f8-416d-b29b-70396b8f5851) The recent change which also added the amount of map changes for eac

Re: [openstreetmap/openstreetmap-website] Contribution heatmap is off by a month (Issue #5802)

2025-03-15 Thread Minh Nguyễn via rails-dev
1ec5 left a comment (openstreetmap/openstreetmap-website#5802) I can reliably reproduce this issue: * In Firefox 137.0b6 and Safari 18.3.1 on macOS 15.3.2, and Safari on iOS 16.7 * With `I18n.locale` evaluating to `en` or `vi` * With a screen 1,728 pixels wide or 375 pixels wide -- Reply to thi

Re: [openstreetmap/openstreetmap-website] Revise search forms (PR #5765)

2025-03-15 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5765) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5765#issuecomment-2725254119 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Omit changeset "💬" from changeset list where there are no comments (Issue #5757)

2025-03-15 Thread Roman Deev via rails-dev
deevroman left a comment (openstreetmap/openstreetmap-website#5757) Previously, to separate changesets without comments, you used to change the brightness of the icon, not fill it. And before, it was the only icon with a fill that you could get used to. > just to you for some reason For what r

Re: [openstreetmap/openstreetmap-website] Align bottoms of date-username-changeset_id and counters in history (PR #5800)

2025-03-15 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5800) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5800#issuecomment-2725228239 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Disable asynchronous object layer loading (PR #5799)

2025-03-15 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. e4a092ff361e50a16bf22f9e67c3a969c3f4d303 Test map centering on a node -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5799/files/ce63209f326d90ae07367008a78a7af9b812021c..e4a092ff361e50a16bf22f9e67c3a969c3f4d303 You are receiving t

Re: [openstreetmap/openstreetmap-website] Allow home location marker on main map to be hidden (#670)

2025-03-15 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#670) Was fixed in #4926. The marker is shown on `/account/home` page and removed when visiting any other page. Like https://github.com/openstreetmap/openstreetmap-website/issues/670#issuecomment-31867047, but there's no sidebar, an

[openstreetmap/openstreetmap-website] opening https://www.openstreetmap.org/way/12432594/ link does not center map where way is (Issue #5798)

2025-03-15 Thread Mateusz Konieczny via rails-dev
matkoniecz created an issue (openstreetmap/openstreetmap-website#5798) ### URL https://www.openstreetmap.org/way/12432594/ ### How to reproduce the issue? 1) open https://www.openstreetmap.org/way/12432594/ 2) note that map is not moving to way location it used to work very recently ### Scree

Re: [openstreetmap/openstreetmap-website] Not straightforward to see previous position of a node (#576)

2025-03-15 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#576) Should be straightforward with #5278. You just click at the version. Node version pages show previous locations on the map. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-w

Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

2025-03-15 Thread Marwin Hochfelsner via rails-dev
@hlfan commented on this pull request. > +$(L.SVG.create("svg")) + .append( +$(L.SVG.create("path")).attr("d", "M3 1s9 7 9 7c-1.056.587-2.112 1.173-3.168 1.76l3.031 6.615c.346.753.015 1.643-.738 1.989-.753.345-1.643.014-1.989-.739L6.201 11.221C5.134 11.814 4.067 12.407 3 13V1

Re: [openstreetmap/openstreetmap-website] My user experience with number of changes on a changeset list (Issue #5770)

2025-03-15 Thread Andrew Harvey via rails-dev
andrewharvey left a comment (openstreetmap/openstreetmap-website#5770) > For me, the numbers that tell how many objects someone has added or removed > are meaningless, and only make it harder to see which changeset has a comment. I find the current combined number a bit meaningless, but split in

Re: [openstreetmap/openstreetmap-website] Disable asynchronous object layer loading (PR #5799)

2025-03-15 Thread Tom Hughes via rails-dev
Merged #5799 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5799#event-16777680267 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Add profile location (PR #5302)

2025-03-15 Thread David Tsiklauri via rails-dev
@nertc commented on this pull request. > +if (updateLocationName) { + if (locationInput.checkLocation) { +updateHomeLocation(false, savedLat, savedLon, updateHomeLocation); + } else { +updateHomeLocation(); + } +} It shouldn't t

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

2025-03-15 Thread Tom Hughes via rails-dev
@tomhughes commented on this pull request. > + +class SocialLink < ApplicationRecord + belongs_to :user + + validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :message => :http_parse_error } + + URL_PATTERNS = { +:bluesky => %r{\Ahttps?://(?:www\.)?bsky\.app/profile/([a-zA-Z0-9\.

Re: [openstreetmap/openstreetmap-website] Make contribution heat map opt in (Issue #5804)

2025-03-15 Thread Minh Nguyễn via rails-dev
1ec5 left a comment (openstreetmap/openstreetmap-website#5804) Who is this widget’s intended audience and what’s its purpose? https://github.com/openstreetmap/openstreetmap-website/issues/5373#issue-2714677416 frames it this way: > The current user profile page provides a detailed summary of co

Re: [openstreetmap/openstreetmap-website] Contribution heatmap is off by a month (Issue #5802)

2025-03-15 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5802) Agreed - it looks right to me to. As well as browser the other thing that might possible affect it is what locale you're using - can you see what `I18n.locale` evaluates to in the console? -- Reply to this email directly or vi

Re: [openstreetmap/openstreetmap-website] Contribution heatmap is off by a month (Issue #5802)

2025-03-15 Thread Emin Kocan via rails-dev
kcne left a comment (openstreetmap/openstreetmap-website#5802) What browser do you use? I can't reproduce this. I'm using firefox and safari, but everything looks alright on account you provided so far. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/open

Re: [openstreetmap/openstreetmap-website] Make contribution heat map opt in (Issue #5804)

2025-03-15 Thread Simon Poole via rails-dev
simonpoole left a comment (openstreetmap/openstreetmap-website#5804) > And this page says that metadata should be shown only to those who accepted > the terms of use: The discrepancy is due to you still being able to login even though you haven't agreed to the ToS if you have an account pre-dat

Re: [openstreetmap/openstreetmap-website] Make contribution heat map opt in (Issue #5804)

2025-03-15 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5804) > I think we should make it optional. That's what users say about many changes. I wanted the heatmap to be collapsed by default, which would probably have removed some of "this is *my* page" complaints. And I also wanted it a

Re: [openstreetmap/openstreetmap-website] Make contribution heat map opt in (Issue #5804)

2025-03-15 Thread Héctor Ochoa Ortiz via rails-dev
Robot8A left a comment (openstreetmap/openstreetmap-website#5804) After reading this discussion, my two cents on this is that a settings option so registered users can show their heatmap (or other relevant metadata that can have privacy concerns) to all users / registered users / no one can be a

Re: [openstreetmap/openstreetmap-website] Make contribution heat map opt in (Issue #5804)

2025-03-15 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5804) > The OSMF privacy policy guarantees that contribution meta data will only be > shown to logged in users > https://osmfoundation.org/wiki/Privacy_Policy#Who_has_access_to_the_data And this page says that metadata should be sh

Re: [openstreetmap/openstreetmap-website] Make contribution heat map opt in (Issue #5804)

2025-03-15 Thread Simon Poole via rails-dev
simonpoole left a comment (openstreetmap/openstreetmap-website#5804) As this issue is likely to attract a lot of traffic, here's the link to the wiki page with a number of resources on the topic https://wiki.openstreetmap.org/wiki/GDPR , the paper linked there goes over the arguments for the so

Re: [openstreetmap/openstreetmap-website] Make contribution heat map opt in (Issue #5804)

2025-03-15 Thread Simon Poole via rails-dev
simonpoole left a comment (openstreetmap/openstreetmap-website#5804) > I would argue that by signing up to the project it's your intent to make your > edits public - building a public data set is the entire point of the project > after all but what do I know. It is rather pointless to try to re

Re: [openstreetmap/openstreetmap-website] Make contribution heat map opt in (Issue #5804)

2025-03-15 Thread Michael via rails-dev
Discostu36 left a comment (openstreetmap/openstreetmap-website#5804) I would suggest to try to limit the discussion of this ticket to my specific feature request. The heat map is a newly added feature that is kind of a gadget: It doesn't directly benefit the OSM project. But it does have privacy

Re: [openstreetmap/openstreetmap-website] Add OSRM support for right u-turn (PR #5777)

2025-03-15 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5777) What was [this change](https://github.com/openstreetmap/openstreetmap-website/pull/5777/files/e7db3420dc6fa8a1d34e45a99c12c6f9255e6a89..2db8892dc5f1b3fd2248265c9a06e472b825db23) supposed to achieve? How about making no decisi

Re: [openstreetmap/openstreetmap-website] Make contribution heat map opt in (Issue #5804)

2025-03-15 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5804) I would argue that by signing up to the project it's your intent to make your edits public - building a public data set is the entire point of the project after all but what do I know. I certainly don't see any point in showing

Re: [openstreetmap/openstreetmap-website] Make contribution heat map opt in (Issue #5804)

2025-03-15 Thread Simon Poole via rails-dev
simonpoole left a comment (openstreetmap/openstreetmap-website#5804) See https://wiki.openstreetmap.org/wiki/GDPR/Affected_Services iirc at the time it was assumed that the the the user page would only contain content that the user had added with the intent of making it public, see https://osmf

Re: [openstreetmap/openstreetmap-website] Make contribution heat map opt in (Issue #5804)

2025-03-15 Thread Roman Deev via rails-dev
deevroman left a comment (openstreetmap/openstreetmap-website#5804) How about hiding pages `osm.org/user/username` from not registered users by default? And after that, you can add a setting of the visibility of the profile data. Yes there is more `osm.org/user/username/*`, but at least it will

Re: [openstreetmap/openstreetmap-website] Make contribution heat map opt in (Issue #5804)

2025-03-15 Thread Simon Poole via rails-dev
simonpoole left a comment (openstreetmap/openstreetmap-website#5804) The OSMF privacy policy guarantees that contribution meta data will only be shown to logged in users https://osmfoundation.org/wiki/Privacy_Policy#Who_has_access_to_the_data (yes, the OSMF violates this all over the place, but

Re: [openstreetmap/openstreetmap-website] Contribution heatmap is off by a month (Issue #5802)

2025-03-15 Thread Minh Nguyễn via rails-dev
1ec5 left a comment (openstreetmap/openstreetmap-website#5802) Ah sorry, I’m [Minh Nguyen](https://www.openstreetmap.org/user/Minh%20Nguyen) on OSM, though I’m seeing this on everyone’s heatmap, such as [Steve](https://www.openstreetmap.org/user/Steve) and [Mateusz Konieczny - bot account](http

Re: [openstreetmap/openstreetmap-website] Search forms redesign (#3123)

2025-03-15 Thread mjourdan via rails-dev
mjourdan left a comment (openstreetmap/openstreetmap-website#3123) Thanks for the changes! It's great to see markers are in the input form, the reverse direction button is well placed, and the mode is finally separate from the routing engines. Did a quick informal user review with a panel of 1

[openstreetmap/openstreetmap-website] Make contribution heat map opt in (Issue #5804)

2025-03-15 Thread Michael via rails-dev
Discostu36 created an issue (openstreetmap/openstreetmap-website#5804) ### Problem There have been several critical comments about the new contribution heat map feature. Some users see the publication of their contribution patterns as a violation of their privacy or even a breach of GDPR. Some