aceman444 left a comment (openstreetmap/openstreetmap-website#5769)
I have a suspicion German language also has this problem with future time
intervals. The OSM blocks page writes "in 10 Jahre", instead of "in 10 Jahren",
also "in etwa ein Jahr" instead of "in etwa einem Jahr". Intervals in past
matkoniecz left a comment (openstreetmap/openstreetmap-website#5733)
if installing mini racer fails due to bug that they fixed (
https://github.com/rubyjs/mini_racer/issues/305 ) then it can be closed, right?
Especially given that mini racer cannot be installed at all, without osm.org
code comi
matkoniecz left a comment (openstreetmap/openstreetmap-website#5757)
you still have quite a lot of unnecessary clutter, and my first though on
seeing this is that it marks unread changeset messages
I still think that removing message icon when there are no messages is a good
idea
--
Reply to
matkoniecz left a comment (openstreetmap/openstreetmap-website#5618)
> "Details" there is a link to the current version
oh, that is actually confusing
why not have it say "Current version" or "Last version" ?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetma
matkoniecz left a comment (openstreetmap/openstreetmap-website#5496)
I noticed that you can also open them on website using link with message id (at
least for some time? not sure is it going to stop working at some point)
So deleting them simply hides them from inbox/outbox, it does not even app
matkoniecz left a comment (openstreetmap/openstreetmap-website#5758)
> If OSMCha has it, why copy the same thing to osm.org? If someone needs
> accurate data, that's what OSMCha is for.
By that logic we should also remove map display, as there are already sites
displaying osm-based maps.
And e
matkoniecz left a comment (openstreetmap/openstreetmap-website#5770)
> I think it is too much information to show the number of changes in the
> changeset list. For people like me who have been using OSM for years, this is
> unreadable and it makes impossible to see which changesets have comment
matkoniecz left a comment (openstreetmap/openstreetmap-website#5616)
Would #4335 be reviewed if it would be updated so it works again?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5616#issuecomment-2723479533
You are receivi
matkoniecz left a comment (openstreetmap/openstreetmap-website#5670)
Can we close this one? It is based on misunderstanding of my comment
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5670#issuecomment-2723474781
You are recei
@tomhughes commented on this pull request.
> @@ -63,7 +63,7 @@ class User < ApplicationRecord
has_many :preferences, :class_name => "UserPreference"
has_many :changesets, -> { order(:created_at => :desc) }, :inverse_of =>
:user
has_many :changeset_comments, :foreign_key => :author_id,
@hlfan pushed 1 commit.
de43fe58a2f19da24f83a8f400267a21e899a9d3 Overhaul markers
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5764/files/fb1f9ed28f03b080d6ce90a7e74a4667c34c9d18..de43fe58a2f19da24f83a8f400267a21e899a9d3
You are receiving this because you ar
@hlfan pushed 1 commit.
fb1f9ed28f03b080d6ce90a7e74a4667c34c9d18 Overhaul markers
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5764/files/c01ecb1178eb33f9a04d6e8dba42d54185e00f4f..fb1f9ed28f03b080d6ce90a7e74a4667c34c9d18
You are receiving this because you ar
@hlfan pushed 1 commit.
c01ecb1178eb33f9a04d6e8dba42d54185e00f4f Overhaul markers
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5764/files/59dcd82eb9ccce11286081a43f2a5e47f6b5caed..c01ecb1178eb33f9a04d6e8dba42d54185e00f4f
You are receiving this because you ar
@tomhughes commented on this pull request.
> @@ -63,7 +63,7 @@ class User < ApplicationRecord
has_many :preferences, :class_name => "UserPreference"
has_many :changesets, -> { order(:created_at => :desc) }, :inverse_of =>
:user
has_many :changeset_comments, :foreign_key => :author_id,
1ec5 left a comment (openstreetmap/openstreetmap-website#5769)
CLDR has string formats for [future/past relative
years/months/etc.](https://www.unicode.org/cldr/charts/47/summary/sk.html#38e7d288d00bc475)
However, it doesn’t have any provisions for “about”. As far as I know, “about”
timestamps
deevroman left a comment (openstreetmap/openstreetmap-website#5009)
This PR brought two problems:
1. When moving the map, a white flash occurs and all objects on the map are
redrawn:
https://github.com/user-attachments/assets/3c87c769-174c-4513-a5be-115eb9517bb8
2. Rendering slowed down. What
tomhughes left a comment (openstreetmap/openstreetmap-website#5769)
Well rails-i18n does draw on some CLDR concepts but I don't believe that CLDR
has translations for all the different relative dates that we're talking about
here does it?
--
Reply to this email directly or view it on GitHub:
h
1ec5 left a comment (openstreetmap/openstreetmap-website#5769)
Are rails-i18n and homegrown translation strings the only options for
formatting dates? On the client side, JavaScript has [a robust API for
formatting relative
dates](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Referenc
1ec5 left a comment (openstreetmap/openstreetmap-website#5373)
This landed in #5402. This issue didn’t close automatically because “addresses”
isn’t one of [GitHub’s closing
keywords](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issu
aceman444 left a comment (openstreetmap/openstreetmap-website#5769)
Maybe other translators are not aware and do not check how the strings are
really used on the webpage. Some of the strings have very good context
descriptions of their usage directly at the weblate interface (thanks!). But
some
@1ec5 commented on this pull request.
> +
+class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :message =>
:http_parse_error }
+
+ URL_PATTERNS = {
+:bluesky => %r{\Ahttps?://(?:www\.)?bsky\.app/profile/([a-zA-Z0-9\._-]+)
Closed #5373 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5373#event-16750577757
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
Merged #5797 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5797#event-16748624496
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5540 as completed via #5797.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5540#event-16748624825
You are receiving this because you are subscribed to this thread.
Message ID:
_
Closed #4931 as completed via #5009.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/4931#event-16748319414
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5009 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5009#event-16748319112
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5009)
Thanks for the fix. I think this looks good now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5009#issuecomment-2722447755
You are receiving this because you a
tomhughes left a comment (openstreetmap/openstreetmap-website#5796)
So it seems that the process ID based solution doesn't work very well in
actions so I've updated to a more robust solution based on the worker number
and also incrementing to handle cases where a worker process starts more than
@tomhughes pushed 1 commit.
d5f462f7d01299cdf79d4acced54ff57a6cad027 Monkey patch Selenium to allocate
unique bidi ports
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5796/files/cfaa09911e2716c54588c81728ce71fcb423cc87..d5f462f7d01299cdf79d4acced54ff57a6cad0
Merged #5795 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5795#event-16745864302
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5794 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5794#event-16745864296
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@AntonKhorev pushed 6 commits.
9d2342a41ab1eb6a6c2bba747bd29ff58f246258 Create changeset subscription model
9c002d5c711dee6035179c7d2b15327652dcbae2 Remove subscription methods from
changeset model
7ffd4c2b68b0231abcc59125b2c8574587ed16f2 Create api changeset subscription
resource
f7b06880169
tomhughes left a comment (openstreetmap/openstreetmap-website#5794)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5794#issuecomment-2722063889
You are receiving this because you are subscribed to this t
@AntonKhorev pushed 2 commits.
9d2342a41ab1eb6a6c2bba747bd29ff58f246258 Create changeset subscription model
9c002d5c711dee6035179c7d2b15327652dcbae2 Remove subscription methods from
changeset model
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5797/files/e6
Fixes #5540.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5797
-- Commit Summary --
* Create changeset subscription model
* Remove subscription methods from changeset model
-- File Changes --
M app/control
Jimmykhangnguyen left a comment (openstreetmap/openstreetmap-website#5784)
Sorry if my commit history has been a tad untidy as I am pretty new to
contributing to OSM. I have just removed my change in the en-GB.yml file as it
is not needed.
I am also open to any suggestions on how to tidy up thi
@AntonKhorev pushed 4 commits.
9c3697a1798caf99ccaa81d41c09b9ea0d2c14df Create api changeset subscription
resource
ed7d3b519fcc9791b34c2e60c12a4a4f4032b126 WIP split cset sub tests
08faecfe23328d2c48d43900e5043569984f1b29 Test legacy api changeset
subscribe/unsubscribe paths
77e965bb2c8ca7c56
nertc left a comment (openstreetmap/openstreetmap-website#5439)
PR was updated. `master` was rebased. Conflicts were resolved.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439#issuecomment-2721275936
You are receiving this bec
@nertc pushed 1 commit.
4c88ed958a347124a4068568944e1ae422cf5b17 Add social profile links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/26406e204ea25ef6ff42a2f5e6ff54c7ea9d468b..4c88ed958a347124a4068568944e1ae422cf5b17
You are receiving this becaus
@AntonKhorev pushed 1 commit.
fd77783997a1bde85e40bbf21b8a91eae576b82f Create api changeset comment
subscription resource
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5590/files/f915a03596508205a8ac0da7a27be72d6ef53a15..fd77783997a1bde85e40bbf21b8a91eae576b
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#5590)
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Gener
@AntonKhorev pushed 1 commit.
b7ddcf9b7e1180f97562a44c9f00edbeeefb6145 Make api close changeset path
resourceful
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5590/files/fd77783997a1bde85e40bbf21b8a91eae576b82f..b7ddcf9b7e1180f97562a44c9f00edbeeefb6145
You a
gravitystorm left a comment (openstreetmap/openstreetmap-website#5789)
Hi @Artyom10-Pt thanks for your PR. It looks like you've removed lots of gems
that we rely on, like bootstrap. You can see more information in the output of
the CI checks.
If you'd like to tell us a bit more about what you a
gravitystorm left a comment (openstreetmap/openstreetmap-website#5772)
Closed by #5792
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5772#issuecomment-2720893378
You are receiving this because you are subscribed to this thread
44 matches
Mail list logo
