Re: [openstreetmap/openstreetmap-website] Add UserActivities module for structured user activity history (PR #5761)
kcne left a comment (openstreetmap/openstreetmap-website#5761) > Did you try doing this via normal ActiveModel queries before resorting to raw > SQL queries? > > I certainly don't like the idea of interpolating arguments into the queries - > the fact that you called the argument `quoted_user_id
Re: [openstreetmap/openstreetmap-website] Add UserActivities module for structured user activity history (PR #5761)
@kcne pushed 2 commits. b566bd65f0b0ff5eb7adcad77516b24b756b194b Add UserActivities module for structured user activity history 4927b1d62cebaa247e0708f5d708c8b99dddc353 Add tests for UserActivities module -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5761/f
Re: [openstreetmap/openstreetmap-website] Add UserActivities module for structured user activity history (PR #5761)
@kcne pushed 2 commits. bdfc3cfb953c65181365c005460c89f3daba7d85 Add UserActivities module for structured user activity history 7f06966ce61fe2f4718f79f5d1745f8b41548a9c Add tests for UserActivities module -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5761/f
Re: [openstreetmap/openstreetmap-website] Monkey patch Selenium to allocate unique bidi ports (PR #5796)
tomhughes left a comment (openstreetmap/openstreetmap-website#5796) I don't even know for sure that GHA has 136 yet. I'm just assuming that is the problem given when it started happening but in any case as far as I know there's no way to control the firefox version in the GHA images. -- Reply
Re: [openstreetmap/openstreetmap-website] Source of translations of future dates (Issue #5769)
gravitystorm left a comment (openstreetmap/openstreetmap-website#5769) @aceman444 Thanks for the additional details. It would be helpful if you can share the exact slovakian translations of: - A duration of time: "about 10 years" - A time in the future: "in about 10 years" - Describing somet
Re: [openstreetmap/openstreetmap-website] Monkey patch Selenium to allocate unique bidi ports (PR #5796)
hlfan left a comment (openstreetmap/openstreetmap-website#5796) Could Firefox be fixed to v135 in the meantime? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5796#issuecomment-2719194835 You are receiving this because you are su
Re: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201)
@nertc pushed 1 commit. a0478eab9484280aa1be6c4b15a2e96b2ced14ca Add locale selector -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5201/files/d4f0011abe0f02421d3657aab38abdfddee89704..a0478eab9484280aa1be6c4b15a2e96b2ced14ca You are receiving this because you
Re: [openstreetmap/openstreetmap-website] Source of translations of future dates (Issue #5769)
maro-21 left a comment (openstreetmap/openstreetmap-website#5769) > But that may not be true for all languages. But if no one has reported so far that they are needed, I think we should not change anything now. Because if we change, and no language needs such a change, it will add work to the
Re: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201)
nertc left a comment (openstreetmap/openstreetmap-website#5201) PR was updated. `master` was rebased as a base for this PR. @tomhughes Code was changed according to comments. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5201#is
[openstreetmap/openstreetmap-website] Monkey patch Selenium to allocate unique bidi ports (PR #5796)
Firefox 136 has started binding an extra port at startup when running via selenium but unfortunately it always uses port 9222 which causes problems running tests in parallel as discussed in https://github.com/mozilla/geckodriver/issues/2218. This monkey patches things to try and allocate unique
Re: [openstreetmap/openstreetmap-website] Monkey patch Selenium to allocate unique bidi ports (PR #5796)
tomhughes left a comment (openstreetmap/openstreetmap-website#5796) Well that doesn't seem to have worked very well... Will switch this to draft for now. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5796#issuecomment-271889771
Re: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201)
@nertc commented on this pull request. > @@ -52,6 +52,13 @@ time[title] { color: $blue; } +/* Utility for transparent color */ + +.text-transparent{ Space was added. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5201#di
Re: [openstreetmap/openstreetmap-website] Add PWA geo protocol handler (PR #5736)
@hlfan pushed 1 commit. cb64248095588834fdf419f7ebe7ee3dc8be0ba6 Add PWA geo protocol handler -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5736/files/77b1c8015fb0eeba3297e238ef447a494937fa45..cb64248095588834fdf419f7ebe7ee3dc8be0ba6 You are receiving this be
Re: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201)
@nertc commented on this pull request. > @@ -0,0 +1,15 @@ + + + + + <% unless disabled %> + For now, I haven't changed anything related to this comment. If you prefer any of these or other solutions, I'll update PR accordingly. -- Reply to this email directly or view it on GitHu
Re: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201)
@nertc commented on this pull request. > @@ -1984,6 +1984,8 @@ en: users: older: Older Users newer: Newer Users +language_selector: + language: English Language codes were added in `en.yml`. Now even before translation of these new keys, all languages will app
Re: [openstreetmap/openstreetmap-website] Source of translations of future dates (Issue #5769)
aceman444 left a comment (openstreetmap/openstreetmap-website#5769) That is exactly what I propose in comment https://github.com/openstreetmap/openstreetmap-website/issues/5769#issuecomment-2715697075 . The 3 different contexts. It is true that in Slovak distance_in_words_duration and distance_
Re: [openstreetmap/openstreetmap-website] Add PWA geo protocol handler (PR #5736)
@hlfan commented on this pull request. > @@ -100,6 +106,9 @@ OSM = { mapParams.lon = params.mlon; mapParams.lat = params.mlat; mapParams.zoom = params.zoom || 12; +} else if (geoURI.pathname) { + [mapParams.lat, mapParams.lon] = geoURI.pathname.split(","); + ma
Re: [openstreetmap/openstreetmap-website] Add PWA geo protocol handler (PR #5736)
@hlfan pushed 1 commit. 77b1c8015fb0eeba3297e238ef447a494937fa45 Add basic PWA geo protocol handler -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5736/files/a28f78c69a19c9c41dc96dcaad9f87cf5b530f96..77b1c8015fb0eeba3297e238ef447a494937fa45 You are receiving t
Re: [openstreetmap/openstreetmap-website] Add PWA geo protocol handler (PR #5736)
@hlfan commented on this pull request. > + mapParams.mlon = parseFloat(geoURI.lon); + mapParams.mlat = parseFloat(geoURI.lat); I'd say show a marker so later when uncertainty support is implemented in an approved way, changing L.marker to L.circle when a radius is specified in https
Re: [openstreetmap/openstreetmap-website] Add PWA geo protocol handler (PR #5736)
@hlfan commented on this pull request. > @@ -100,6 +106,9 @@ OSM = { mapParams.lon = params.mlon; mapParams.lat = params.mlat; mapParams.zoom = params.zoom || 12; +} else if (geoURI.pathname) { + [mapParams.lat, mapParams.lon] = geoURI.pathname.split(","); I though
[openstreetmap/openstreetmap-website] Bump json from 2.10.1 to 2.10.2 (PR #5795)
Bumps [json](https://github.com/ruby/json) from 2.10.1 to 2.10.2.
Re: [openstreetmap/openstreetmap-website] Add PWA geo protocol handler (PR #5736)
@AntonKhorev commented on this pull request. > @@ -100,6 +106,9 @@ OSM = { mapParams.lon = params.mlon; mapParams.lat = params.mlat; mapParams.zoom = params.zoom || 12; +} else if (geoURI.pathname) { + [mapParams.lat, mapParams.lon] = geoURI.pathname.split(","); +
Re: [openstreetmap/openstreetmap-website] Add PWA geo protocol handler (PR #5736)
@AntonKhorev commented on this pull request. > @@ -100,6 +106,9 @@ OSM = { mapParams.lon = params.mlon; mapParams.lat = params.mlat; mapParams.zoom = params.zoom || 12; +} else if (geoURI.pathname) { + [mapParams.lat, mapParams.lon] = geoURI.pathname.split(","); Yo
Re: [openstreetmap/openstreetmap-website] Add PWA geo protocol handler (PR #5736)
@AntonKhorev commented on this pull request. > + mapParams.mlon = parseFloat(geoURI.lon); + mapParams.mlat = parseFloat(geoURI.lat); Is the geouri parameter supposed to show a marker? If yes, don't you need to parse lat/lon first? -- Reply to this email directly or view it on GitHu
Re: [openstreetmap/openstreetmap-website] User list fixes (PR #5793)
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5793) Merged, thanks. It's probably worth having some kind of flash messages on bulk updates. Currently you can click "Confirm Selected Users" and it says nothing in response. -- Reply to this email directly or view it on GitHub:
Re: [openstreetmap/openstreetmap-website] User list fixes (PR #5793)
Merged #5793 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5793#event-16714714182 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Don't crop coordinates when replacing directions url (PR #5794)
@hlfan approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5794#pullrequestreview-2678368667 You are receiving this because you are subscribed to this thread. Message ID: __
Re: [openstreetmap/openstreetmap-website] Source of translations of future dates (Issue #5769)
gravitystorm left a comment (openstreetmap/openstreetmap-website#5769) As far as I can see so far, we have a few issues here. * We can't translate every sentence that contains a duration, future time or past time separately. We have [13 different types of time](https://github.com/openstreetmap/
Re: [openstreetmap/openstreetmap-website] Map Data checkbox: perhaps use toggle slider instead (PR #5009)
nertc left a comment (openstreetmap/openstreetmap-website#5009) PR was updated. `master` was rebased. @tomhughes Thank you for the review. Spinner issue on page refresh was fixed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5
Re: [openstreetmap/openstreetmap-website] Map Data checkbox: perhaps use toggle slider instead (PR #5009)
@nertc pushed 1 commit. 3b26551122cd26f48f43b6e7ff05e2eded6d0bf8 Map Data asynchronous checkbox -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5009/files/4b1e8f2eae6fd51988a2604ad74f7ca07267fe8b..3b26551122cd26f48f43b6e7ff05e2eded6d0bf8 You are receiving this
Re: [openstreetmap/openstreetmap-website] User list fixes (PR #5793)
tomhughes left a comment (openstreetmap/openstreetmap-website#5793) > What does "X" mean? > [d715f5b](https://github.com/openstreetmap/openstreetmap-website/commit/d715f5b7bbc9d27951006322462bab0b05a2daa4) Sorry, that was meant to be squashed into the previous commit but it seems I forgot to ch
Re: [openstreetmap/openstreetmap-website] Source of translations of future dates (Issue #5769)
aceman444 left a comment (openstreetmap/openstreetmap-website#5769) Well, that is mostly correct, but it is a coincidence. Some other language may need all 3 forms. And the bug is that even if OSM has that "almost 5 years" string, it only uses it for duration and not for the future form of "in 5
