maro-21 left a comment (openstreetmap/openstreetmap-website#5784)
> There are still two texts containing "log-in" left in `setup_user_auth` that
> should be dehyphenated as well.
You're right.
https://translatewiki.net/wiki/Osm:Application.setup_user_auth.need_to_see_terms/en
https://translatewi
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5783)
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5783#issuecomment-2713099449
You are receiving this because you are subscribed to this thread.
maro-21 left a comment (openstreetmap/openstreetmap-website#5769)
Google Translate translates these into Slovak as:
```
almost 1 year -> takmer 1 rok
almost 2 years -> Takmer 2 roky
almost 5 years -> Takmer 5 rokov
in almost 1 year -> takmer za 1 rok
in almost 2 years -> Za takmer 2 roky
in almos
@hlfan commented on this pull request.
> @@ -80,6 +80,11 @@ OSM = {
const hash = OSM.parseHash(location.hash);
+const geoURI = Object.fromEntries(new URLSearchParams(
+ params.geouri?.replaceAll(/[?;]/g, "&")?.replace(":", "=")
So do you want me to follow RFC 5870 or not?
http
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5793)
What does "X" mean? d715f5b7bbc9d27951006322462bab0b05a2daa4
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5793#issuecomment-2716065681
You are receiving this
Here's some strange behavior:
1. Zoom in close enough.
2. Build a route, like [this
one](https://www.openstreetmap.org/directions?engine=fossgis_osrm_car&route=48.861246%2C2.345002%3B48.862012%2C2.341391#map=18/48.861833/2.343210).
3. Look at the browser location bar. It's going to contain the co
@hlfan pushed 1 commit.
a28f78c69a19c9c41dc96dcaad9f87cf5b530f96 Add basic PWA geo protocol handler
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5736/files/cc5b2d654f83d70c51af2814373a988969caceb1..a28f78c69a19c9c41dc96dcaad9f87cf5b530f96
You are receiving t
Some fixes for the user list view:
* Fix a server error if the user hits confirm or hide without selecting any
users
* Preserve the user and edit filters across a confirm or hide action
* Drop redundant parameters from a form URL that duplicate hidden fields
You can view, comment on, or merge thi
@hlfan pushed 1 commit.
3b2a19061408101621ce12c81702fd267dba64c7 Reuse mirrored turn icons
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5776/files/d31c1fda46ac8d121a092dddf7833afc976b39c1..3b2a19061408101621ce12c81702fd267dba64c7
You are receiving this becau
Typically we don't color visited links differently, but I think it would
make sense for *history* pages. Most of the changeset links you'll see
there are not going to be visited, but you'd like to be able to see those
few that were visited.
Looks like there's no Bootstrap class for visited link
aceman444 left a comment (openstreetmap/openstreetmap-website#5769)
Yes, in English all the 3 phrases contain the same "almost 10 years", but in
Slovak they should be different.
The phrase "takmer 10 rokmi" is correct when it talks about the past ('X
time-length ago').
But when it is in the futu
tomhughes left a comment (openstreetmap/openstreetmap-website#5761)
Did you try doing this via normal ActiveModel queries before resorting to raw
SQL queries?
I certainly don't like the idea of interpolating arguments into the queries -
the fact that you called the argument `quoted_user_id` imm
@Jimmykhangnguyen pushed 1 commit.
ae999db12fd14f444a82e43145b3fdd5e36c5460 Revert grammatical changes to
"log-in" in en-GB.yml
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5784/files/cefda7e5db50dd9084703c37c9712c9f0b52aa83..ae999db12fd14f444a82e43145b3fdd
@AntonKhorev commented on this pull request.
> @@ -80,6 +80,11 @@ OSM = {
const hash = OSM.parseHash(location.hash);
+const geoURI = Object.fromEntries(new URLSearchParams(
+ params.geouri?.replaceAll(/[?;]/g, "&")?.replace(":", "=")
`new URL()` is going to help you to get `z`
Merged #5786 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5786#event-16658802706
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes approved this pull request.
I might still have added a local stylesheet with a require just so there was
consistency between the javascript and the styles but it doesn't really matter
so I think this is good to go now - thanks for your work on it!
--
Reply to this email directly o
Merged #5402 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5402#event-16695447398
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5756 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5756#event-16621262042
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5790 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5790#event-16695206583
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5792 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5792#event-16695206567
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5791 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5791#event-16695206566
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5792)
Looks good to me, thanks.
One piece of advice for future PRs - try and keep the subject of the commit
(the first line) a bit shorter and use additional lines for extra details like
the number of a bug you're fixing.
--
Reply
tomhughes left a comment (openstreetmap/openstreetmap-website#5791)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5791#issuecomment-2715348895
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5790)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5790#issuecomment-2715338213
You are receiving this because you are subscribed to this t
Merged #5788 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5788#event-16694896781
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Reopened #5769.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5769#event-16694291283
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mail
@tomhughes requested changes on this pull request.
This mostly works great - the only issue I can see is that if you enable the
data layer and then reload the page then it doesn't enable the spinner while it
does the initial page load though it does appear on subsequent map drags.
--
Reply t
@kcne pushed 2 commits.
9a23dfc07cdc90f1eebbc876312b6b5f82ef508a Add heatmap data caching and query
for user contributions
9be4b0f8b38141631bc1fd82552c341d90ec8b52 Add tests for heatmap data in
UsersController
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/
@kcne commented on this pull request.
> @@ -0,0 +1,7 @@
+class AddGpxFilesUserIdTimestampIndex < ActiveRecord::Migration[7.2]
+ disable_ddl_transaction!
+
+ def change
+add_index :gpx_files, [:user_id, :timestamp], :algorithm => :concurrently
Very smart work around to be honest, would nev
@tomhughes pushed 1 commit.
c8b23418f09764e6f0b963ef0e9205d0c1828380 Allow user list to be filtered for
the presence of edits
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5783/files/3a79eab8aef9e01f0eadbfd73bf9199463712a89..c8b23418f09764e6f0b963ef0e9205d0c
tomhughes left a comment (openstreetmap/openstreetmap-website#5786)
Looks good to me, thanks. As you say, we probably don't need to worry about an
index for now given the small number of records involved.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/ope
Allows to see if the reported item wasn't created/changed recently. For
reported users shows only the account creation date.
Before:
After:
At this point, I'll just close this Pull Request and send up a cleaner one!
Sorry for the untidy PR!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5784#
Closed #5784.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5784#event-16687052635
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
@AntonKhorev commented on this pull request.
> @@ -31,6 +31,13 @@
:autocomplete => "on",
:class => "form-control" %>
+
+ <%= select_tag :edits,
+ options_for_select([["Has Edits", "yes"], ["No Edits",
"no"]],
gravitystorm left a comment (openstreetmap/openstreetmap-website#5784)
> I am also open to any suggestions on how to tidy up this PR of mine if that's
> possible! Thank you!
Yes it's possible, using something like `git rebase -i`. This allows you to
rearrange commits, squash two commits togethe
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5752)
Is this an intentional change to how active "Show my location" looks?
->
Yes, I know those. I guess you need to keep bugging folks over at OSMUS:
https://openstreetmap.us/our-work/charter-projects/osmcha/
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreet
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5776)
> I also run the path data through svgo.
Why? Paths here are hand-written, you're not going to save much but you'll make
them less readable.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreet
In #5787 I appended `created on %{datetime_created} ...` to the reported item
in the heading. That can't be translated correctly because I'm
constructing a sentence and "created"/"updated" need to
agree with the subject in grammatical gender etc. The entire subheading needs
to be translated tog
mmd-osm left a comment (openstreetmap/openstreetmap-website#5758)
> OSMCha is very painful to use, 18 seconds load time for each changeset to
> review, 40 seconds to load the list of changesets
If there's a performance issue with OSMCha, why not report it in their repo in
the first place? https
Closed #5789.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5789#event-16675688684
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
tomhughes left a comment (openstreetmap/openstreetmap-website#5789)
Thanks, but this is something we do routinely and we don't really need people
filing PRs for it.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5789#issuecommen
Reopened #5789.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5789#event-16675821053
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailin
tomhughes left a comment (openstreetmap/openstreetmap-website#5789)
Oh sorry I thought you mean updating the gems in the lock, but even so this
looks like you're just reorganising it in line with your personal preferences.
If you want to do something like that you need to provide more of a ratio
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#5789)
1 Warning
:warning:
Gemfile was updated, but Gemfile.lock wasn't
updated. Usually, when Gemfile is updated, you should run bundle
install to update
Merged #5783 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5783#event-16674921818
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5757)
How does it look now with #5775 deployed?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5757#issuecomment-2713112562
You are receiving this because you are
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5784#pullrequestreview-2671903412
You are receiving this because you are subscribed to this thread.
Message ID:
__
@tomhughes commented on this pull request.
> @@ -31,6 +31,13 @@
:autocomplete => "on",
:class => "form-control" %>
+
+ <%= select_tag :edits,
+ options_for_select([["Has Edits", "yes"], ["No Edits",
"no"]], p
74 matches
Mail list logo
