andrewharvey left a comment (openstreetmap/openstreetmap-website#4975)
> I didn't know that such language exists :)
`en_OSM` OpenStreetMaplish
https://wiki.openstreetmap.org/wiki/Tag:shop%3Dalcohol#Localized_variants
Where en_US it's Liquor Store, en_AU it's Bottle Shop, en_GB it's Off-license
andrewharvey left a comment (openstreetmap/openstreetmap-website#5770)
Some issue as I reported in #5757
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5770#issuecomment-2709318451
You are receiving this because you are subscri
andrewharvey left a comment (openstreetmap/openstreetmap-website#5780)
> Also n12639964186, w1249366504 and r7876483 could have links added as well;
> or be converted to the {object}/{id} format.
Thanks, I've added these to the table, along with "way 1249366504" which are
all in common use.
--
maro-21 left a comment (openstreetmap/openstreetmap-website#4975)
> I'm more inclined to make the source neutral and close to OSM tags
I didn't know that such language exists :)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/4
tomhughes left a comment (openstreetmap/openstreetmap-website#5772)
As I thought there's nothing in Fowler or Longman for this.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5772#issuecomment-2709102076
You are receiving this
tomhughes left a comment (openstreetmap/openstreetmap-website#5772)
I mean I'm only a native english speaker and this is the first I've heard of
any distinction... It's probably too new a term to appear in any of the normal
sources I would use to check such things.
--
Reply to this email direc
@tomhughes commented on this pull request.
> @@ -0,0 +1,102 @@
+//= link cal-heatmap/dist/cal-heatmap.css
I think the best solution is probably to create `app/assets/heatmap.scss` which
can require that, and also include the heap rule you added to `common.scss` and
then have the view load `he
Jimmykhangnguyen left a comment (openstreetmap/openstreetmap-website#5772)
I've just sent a PR to fix this grammatical mistake. I believe the citations
are sufficient and that this is indeed a grammatical mistake.
Pull Request: #5784
--
Reply to this email directly or view it on GitHub:
https:
### Description
This Pull Request is to tackle the grammatical mistake mentioned in Issue
#5772. In particular, the use of "sign-in" as a noun in this context
is incorrect, as it is inconsistent with the other verbs within the permission
list.
**Fix:** "Sign-in" has been changed to "sign in" (w
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5777)
Comment about `driving_side` for reference:
https://github.com/Project-OSRM/osrm-backend/issues/3077#issuecomment-348926341
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-
@kcne commented on this pull request.
> +
+ let cal = new CalHeatmap();
+ let currentTheme = getTheme();
+
+ function renderHeatmap() {
+cal.destroy();
+cal = new CalHeatmap();
+
+cal.paint({
+ itemSelector: "#cal-heatmap",
+ theme: currentTheme,
+ domain: {
+
@kcne commented on this pull request.
> @@ -0,0 +1,102 @@
+//= link cal-heatmap/dist/cal-heatmap.css
I’m not sure if we changed anything in the assets pipeline recently, but when I
ran the code today, I kept getting errors about the missing `.css` file, even
after compiling the assets. I got
@HolgerJeromin commented on this pull request.
> +$(L.SVG.create("svg"))
+ .append(
+$(L.SVG.create("path")).attr("d", "M3 1s9 7 9 7c-1.056.587-2.112
1.173-3.168 1.76l3.031 6.615c.346.753.015 1.643-.738
1.989-.753.345-1.643.014-1.989-.739L6.201 11.221C5.134 11.814 4.067 12.407
@kcne pushed 2 commits.
affa5257d62fef356828f0cd27ac3de5ccca9ac1 Add heatmap data caching and query
for user contributions
356192f445bb253e60908292ba87f8abe3db96ff Add tests for heatmap data in
UsersController
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/
This allows the user list that administrators use to be filtered by whether a
user does, or does not, have edits as requested by @Firefishy.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5783
-- Commit Summary --
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5777)
https://github.com/Project-OSRM/osrm-backend/issues/3077#issuecomment-348926341
suggests looking at `driving_side`, but looks like it's set to `right` even in
the UK.
--
Reply to this email directly or view it on GitHub:
htt
Closed #5782.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5782#event-16645217531
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5745)
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5745#issuecomment-2708912683
You are receiving this because you are subscribed to this thread.
Merged #5745 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5745#event-16645205676
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
> @@ -4,24 +4,24 @@
"@aashutoshrathi/word-wrap@^1.2.3":
version "1.2.6"
- resolved
"https://registry.yarnpkg.com/@aashutoshrathi/word-wrap/-/word-wrap-1.2.6.tgz#bd9154aec9983f77b3a034ecaa015c2e4201f6cf";
+ resolved
"https://registry.npmjs.org/
@tomhughes pushed 3 commits.
f4009e32da4b2379c64f42e1dbe1dbfa372bcd62 Fix sorting of package names in
package.json
295046838063539ad1864aa4f1236595362dd30a Add support for linting of JSON files
aeb356aa90e5a09e4460b9227905d82d6d33204a Enforce sorting of keys in
package.json
--
View it on Gi
tomhughes left a comment (openstreetmap/openstreetmap-website#5781)
I was in two minds about those changes when I reviewed #5633 so this looks good
to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5781#issuecomment-
Merged #5781 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5781#event-16645153581
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@AntonKhorev commented on this pull request.
> @@ -4,24 +4,24 @@
"@aashutoshrathi/word-wrap@^1.2.3":
version "1.2.6"
- resolved
"https://registry.yarnpkg.com/@aashutoshrathi/word-wrap/-/word-wrap-1.2.6.tgz#bd9154aec9983f77b3a034ecaa015c2e4201f6cf";
+ resolved
"https://registry.npmjs.or
This enables linting for JSON files, and enforces ordering for package names in
`package.json`.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5782
-- Commit Summary --
* Fix sorting of package names in package.jso
@tomhughes pushed 1 commit.
46d7e9fe8d16ec3370bb75aa9690abe2b8a77e7e Drop locale fallback from no to nb
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5745/files/183ddb93b32e9b684f13c2137ccc0816501fccea..46d7e9fe8d16ec3370bb75aa9690abe2b8a77e7e
You are receivi
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5745)
How does the Norwegian fallback work? I can see it's working if I replace the
locale selection logic with `I18n.locale = 'no'` in `set_locale`
https://github.com/openstreetmap/openstreetmap-website/blob/95b8297955268874bbc4dc6
@AntonKhorev pushed 6 commits.
53243a347f15f01181c0cfab5e034f9e2695831c Disable no-else-return eslint rule
06ac13de3c9e024befc7964cd0aad3d3d2f7a608 Remove unitTemplate from
formatDistance
0925d30b5c1885ab2a00b2d0dde083bce57cf2c3 Move getDistText next to other
formatting functions
35581deab486
tomhughes left a comment (openstreetmap/openstreetmap-website#5745)
There are two written forms of Norwegian - Bokmål (code `nb`) and Nynorsk (code
`nn`) but older clients would sometimes send `no` as a preferred language (see
aa90ace7b4d1250e2bf4986e9510ef127cebc4ae,
d5561dd27a3affe7f395febf48
There was an issue #3888 that asked to make directions distances translatable.
It was done, but not entirely. Step distances were still untranslatable after
the issue was closed.
Before in Russian:
Notice
tomhughes left a comment (openstreetmap/openstreetmap-website#5745)
I've dropped that fallback now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5745#issuecomment-2708838549
You are receiving this because you are subscribed to
@kcne commented on this pull request.
> @@ -0,0 +1,7 @@
+class AddNotesUserIdCreatedAtIndex < ActiveRecord::Migration[7.2]
+ disable_ddl_transaction!
+
+ def change
+add_index :notes, [:user_id, :created_at], :algorithm => :concurrently
I agree. Fixed.
--
Reply to this email directly or
@tomhughes requested changes on this pull request.
> +
+ let cal = new CalHeatmap();
+ let currentTheme = getTheme();
+
+ function renderHeatmap() {
+cal.destroy();
+cal = new CalHeatmap();
+
+cal.paint({
+ itemSelector: "#cal-heatmap",
+ theme: currentTheme,
+ doma
Closed #670 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/670#event-16644605487
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails
34 matches
Mail list logo
