1ec5 left a comment (openstreetmap/openstreetmap-website#4975)
> Isn't Canadian English similar to US English?
For the kinds of strings being translated in this repository, Canadian English
spelling is closer to Australian English than American English, for example,
“cancelled”, “centre”, and “
Lonkmapp left a comment (openstreetmap/openstreetmap-website#1747)
Please please please p
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1747#issuecomment-2708532535
You are receiving this because you are subscribed to this thre
andrewharvey left a comment (openstreetmap/openstreetmap-website#4975)
> Why not fair? There should be one source file in one language. It will simply
> be a source for translations, not a translation.
Exactly. @1ec5 suggested that the source file is not in one language, but a mix
of UK and US
hlfan left a comment (openstreetmap/openstreetmap-website#5780)
Also n12639964186, w1249366504 and r7876483 could have links added as well; or
be converted to the {object}/{id} format.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/i
maro-21 left a comment (openstreetmap/openstreetmap-website#5772)
https://www.oxfordlearnersdictionaries.com/definition/english/sign-in?q=sign-in
https://en.wiktionary.org/wiki/sign-in "Misspelling of sign in"
https://www.dictionary.com/browse/sign-in
https://www.oed.com/dictionary/sign-in_adj?tl=
Jimmykhangnguyen left a comment (openstreetmap/openstreetmap-website#5772)
Hey! If the citation is appropriate and "Sign-in" is indeed misspelt here, I
would love to be assigned this issue and send up a PR to fix it!
--
Reply to this email directly or view it on GitHub:
https://github.com/opens
maro-21 left a comment (openstreetmap/openstreetmap-website#4975)
> it's not fair on the Americans to not allow them to have their own
> translations. Could you imagine not allowing Germans to have their own
> translations?
Why not fair? There should be one source file in one language. It will
andrewharvey left a comment (openstreetmap/openstreetmap-website#844)
> Many websites that accept Markdown end up pretty-printing raw URLs. For
> example, GitHub turns
> https://github.com/openstreetmap/openstreetmap-website/issues/844#issuecomment-2705479356
> into
> https://github.com/openst
andrewharvey created an issue (openstreetmap/openstreetmap-website#5780)
### Problem
Full URLs pasted within changeset comments and notes makes them harder to read,
especially since they only have limited screen real estate.
### Description
As suggested by @1ec5 at
https://github.com/openstre
1ec5 left a comment (openstreetmap/openstreetmap-website#844)
Many websites that accept Markdown end up pretty-printing raw URLs. For
example, GitHub turns
`https://github.com/openstreetmap/openstreetmap-website/issues/844#issuecomment-2705479356`
into
https://github.com/openstreetmap/openstre
1ec5 left a comment (openstreetmap/openstreetmap-website#5261)
I just noticed this renaming as I went to update translations over on
Translatewiki.net. Like others here, I was also struck by the oddity of
describing an individual as “a following” and a set of individuals as
“followings”. It’s b
@hlfan requested changes on this pull request.
You re-requested a review before acting upon the previous one. Your
contribution will most probably not get merged unless you:
- clean your commit history with rebasing,
- create a PR with a clean commit history, or
- find a maintainer who is willing
Lonkmapp left a comment (openstreetmap/openstreetmap-website#1747)
Please add this poropsal to the website ! It’s so needed ! Many people use
miles instead of kilometers , I love openstreetmaps and really would be so
thrilled to see this ! Please support this idea ! It would be great
--
Reply
Closed #4825.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4825#event-16642760101
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
ArunaHulakoti left a comment (openstreetmap/openstreetmap-website#5114)
"I'd like to contribute by adjusting the scale bar size for better visibility.
I'll test different maxWidth values and explore Leaflet options to improve
usability without affecting the UI. Let me know if this works.
--
Re
Satya900 left a comment (openstreetmap/openstreetmap-website#5646)
> Thanks for looking into this [@Satya900](https://github.com/Satya900)! You
> can link the issue from the PR as well to automatically close this issue when
> the PR is merged (by adding a comment on the PR main message with "res
Closed #2174 as completed via #5778.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2174#event-16642759842
You are receiving this because you are subscribed to this thread.
Message ID:
_
tomhughes left a comment (openstreetmap/openstreetmap-website#5778)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5778#issuecomment-2708411263
You are receiving this because you are subscribed to this t
Merged #5778 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5778#event-16642759810
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#4825)
Superseded by #5778.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4825#issuecomment-2708411421
You are receiving this because you are subscribed to this thread
@tomhughes requested changes on this pull request.
Please get rid of the merge commit - if you want to update then please rebase
on current master instead of merging.
I don't think we can really add this without also doing the non-user scoped
version - this should work in the same way as the XM
HarelM left a comment (openstreetmap/openstreetmap-website#5646)
Thanks for looking into this @Satya900!
You can link the issue from the PR as well to automatically close this issue
when the PR is merged (by adding a comment on the PR main message with
"resolves #xxx"
--
Reply to this email di
@AntonKhorev pushed 4 commits.
e6edca07dd626e5efa889bfdad9e105ef4445f27 Move close button out of left sidebar
content
0b207537de88852d05ddeb950695a7b2c9cc4871 Move close button out of right
sidebar content
9224f825b5c0ce185fba62e37b3b6502e5f5e1b5 Create template for sidebar close
controls
c3
Satya900 left a comment (openstreetmap/openstreetmap-website#5646)
i have generated a pr for this issue [LINK for
PR](https://github.com/openstreetmap/openstreetmap-website/pull/5779)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#5779)
1 Warning
:warning:
Merge commits are found in PR. Please rebase to
get rid of the merge commits in this PR, see CONTRIBUTING.md.
Genera
This PR adds JSON format support to the user's GPX files API endpoint,
enhancing the API's flexibility and consistency with other endpoints that
already support JSON responses. The implementation:
- Adds JSON format handling to the traces controller
- Creates a JSON view template matching the XM
Previous version: #4825
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5778
-- Commit Summary --
* Stop using sidebar header template in welcome banner
* Move close button out of left sidebar content
* Move clo
hlfan left a comment (openstreetmap/openstreetmap-website#5777)
The bearing after is on the crossing road. Otherwise it wouldn't work.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5777#issuecomment-2708355188
You are receiving
tomhughes left a comment (openstreetmap/openstreetmap-website#5774)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5774#issuecomment-2708353288
You are receiving this because you are subscribed to this t
Merged #5774 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5774#event-16642495073
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5775 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5775#event-16642495075
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5777)
Does this really work? The difference between the bearings tells you how close
to parallel the two lanes are, not which way you turned?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/open
@tomhughes commented on this pull request.
> + <% if changeset.comments.empty? %>
+
+ <% else %>
+
+ <% end %>
True, but I think I prefer @AntonKhorev's version, especially as they're just
copied from bootstrap icons.
--
Reply to this email
tomhughes left a comment (openstreetmap/openstreetmap-website#5775)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5775#issuecomment-2708351062
You are receiving this because you are subscribed to this t
@tomhughes commented on this pull request.
> @@ -21,7 +21,6 @@
I18n.default_locale = OSM.DEFAULT_LOCALE;
I18n.locale = locale;
- I18n.fallbacks = true;
Actually there is still a good reason to have it - to provide fallback when the
client side determined language code is not one we su
@tomhughes pushed 3 commits.
84fc41716298c24e7ed2ce5d96d4abe9c75fe94b Disable client side I18n fallbacks
50f9fa6113c75dee6cddd7178daba9d17841b5c8 Drop monkey patch that no longer
seems to be needed
183ddb93b32e9b684f13c2137ccc0816501fccea Wait until rails has initialised to
update I18n fallba
@tomhughes pushed 3 commits.
16d68e23ae7cf019f1d7768f82fe80af71708767 Disable client side I18n fallbacks
82e7c172eace60507d801b97363ba0a4bef57496 Drop monkey patch that no longer
seems to be needed
ec32c75072ec4b882a7dd3579c68b7168e741ea4 Wait until rails has initialised to
update I18n fallba
@tomhughes commented on this pull request.
> @@ -21,7 +21,6 @@
I18n.default_locale = OSM.DEFAULT_LOCALE;
I18n.locale = locale;
- I18n.fallbacks = true;
I've removed fallback for the embed case now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap
@tomhughes commented on this pull request.
> @@ -21,7 +21,6 @@
I18n.default_locale = OSM.DEFAULT_LOCALE;
I18n.locale = locale;
- I18n.fallbacks = true;
As I explained when I opened this PR the embed case is different - there we
load `embed.js` which contains only a single string but d
@hlfan commented on this pull request.
> + <% if changeset.comments.empty? %>
+
+ <% else %>
+
+ <% end %>
There's actually no need to define the same path twice
```suggestion
```
--
Reply to this email directly or view it on GitHu
#4900 v2
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5754
-- Commit Summary --
* Separate setting/clearing listeners/values on directions endpoints
* Move directions params init code to its own function
* Mov
@AntonKhorev pushed 1 commit.
9a1ba12c81f7c79c362e36f14ed7955f5765e833 Use filled chat icon for nonzero
comment counts in history
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5775/files/5f1b43ee8841b584fe89d4f15b1bfb8d65f1e28d..9a1ba12c81f7c79c362e36f14ed79
### Description
This does #5768 for OSRM.
### How has this been tested?
Testing with the API revealed that using the "driving_side"
doesn't work as it's always "right", so a manual calculation
with the bearings is required.
You can view, comment on, or merge this pull request online at:
https
### Description
I replaced the definitions of the turn icons twice for left and right with a
single definition and a mirroring.
I also run the path data through svgo.
### How has this been tested?
ctrl+c ctrl+v in browser
You can view, comment on, or merge this pull request online at:
https:/
Addresses "hard to spot changesets with comments" #5757 #5770.
We had a filled icon, which was actually *add new note icon*. When I was
replacing it, I first tried the filled chat icon from Bootstrap, but it stood
out too much and I went with unfilled. Now if people want changesets with
comment
@hiddewie pushed 1 commit.
492919f7a266c8dfe6268fed5de2d3a44f3053bc Compress SVG more
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4792/files/3e660c78e40b9aec0640e7c73dded3b6989b1f3b..492919f7a266c8dfe6268fed5de2d3a44f3053bc
You are receiving this because yo
hlfan left a comment (openstreetmap/openstreetmap-website#5596)
Yeah, fixed in #5679 and test added in #5693
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5596#issuecomment-2708291406
You are receiving this because you are sub
@hiddewie commented on this pull request.
> +
+
+
+
+
+
+
+
+
+
+
+
+
+
Thanks, I committed the suggestion to compress the SVG to less decimal places
and less SVG elements. :+1:
--
Reply to this email directly or view it on GitHub:
http
Before:
After:
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/op
@hlfan commented on this pull request.
> @@ -21,7 +21,6 @@
I18n.default_locale = OSM.DEFAULT_LOCALE;
I18n.locale = locale;
- I18n.fallbacks = true;
Why only remove it here and not in the embed?
https://github.com/openstreetmap/openstreetmap-website/blob/998ef40d19762fc879c9607941890b05
@hlfan pushed 1 commit.
1f182c673bc66404934fce5692561befa17c19b4 Remove controls sprite
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5752/files/19f498e6e76682841234c643fca168951db4c6a3..1f182c673bc66404934fce5692561befa17c19b4
You are receiving this because
Merged #5747 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5747#event-16641917871
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5596)
There was some other pull request for changeset comment links, I think.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5596#issuecomment-2708268029
You are r
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5770)
> In addition, the previous font ... was larger,
No, it wasn't:
OHM with the previous (actually the same) font:
OSM with the new (actua
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5770)
Opposite of "let's have more numbers" #5758.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5770#issuecomment-2708243936
You are receiving this because you a
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5757)
> I think putting the green, orange red boxes like OSMCha in the top right
> corner
We can't do this right now, we don't have these numbers calculated.
--
Reply to this email directly or view it on GitHub:
https://github.com
@tomhughes pushed 3 commits.
e954a67884fb6038f63d4961e61fbf78917774da Disable client side I18n fallbacks
bbaf208d2d6115e3a2d91e86e6d5cb803bd43e9c Drop monkey patch that no longer
seems to be needed
bf4450dbbad23378b2332f2c894662fb123c3198 Wait until rails has initialised to
update I18n fallba
Closed #5771 as completed via 998ef40d19762fc879c9607941890b058c9014b2.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5771#event-16641976667
You are receiving this because you are subscribed to this thread.
Message ID:
__
Merged #5493 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5493#event-16641970837
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5450 as completed via #5493.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5450#event-16641971142
You are receiving this because you are subscribed to this thread.
Message ID:
_
@tomhughes approved this pull request.
Other than the question of the length of the new `admin_level` based levels
this looks fine to me, and in practice I have yet to see them appear in testing
as `border_type` takes priority.
I think this is good to go and we can revisit those labels later if
tomhughes left a comment (openstreetmap/openstreetmap-website#5763)
I'm not completely sure about "managed" but I don't have any better ideas for
how to describe it, so this looks good to me.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-we
Merged #5763 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5763#event-16641917870
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5773 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5773#event-16641917873
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5747)
Thanks for the changes - this looks good to me now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5747#issuecomment-2708201023
You are receiving this because yo
@kcne pushed 1 commit.
227894193df8916aeda13038cae97a529eef1ad3 Add index on gpx_files table on
user_id, id
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5747/files/06a30d59a8c970186c8ec23496bed46a21295460..227894193df8916aeda13038cae97a529eef1ad3
You are re
andrewharvey left a comment (openstreetmap/openstreetmap-website#4975)
Reading the prior responses here it sounds like we should make `en` exclusively
US English, it's not fair on the Americans to not allow them to have their own
translations. Could you imagine not allowing Germans to have their
andrewharvey left a comment (openstreetmap/openstreetmap-website#844)
> But will those writing comments be bothered to paste the correct
> urls/templates?
Good point, then perhaps as you suggest parsing key=value would be okay and/or
reducing a pasted full wiki link.
Although the more we do th
andrewharvey left a comment (openstreetmap/openstreetmap-website#5757)
To be honest I don't know what it was previously, but whatever it was it was
easy to scan through a list of changesets and find those with comments. Now
it's next to impossible, but it also could be because of the edit count
69 matches
Mail list logo
