Re: [openstreetmap/openstreetmap-website] Show new/modified/deleted count in place of " πŸ–Š" in changeset card (Issue #5758)

2025-03-06 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5758) We can start storing these counts for new changesets. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5758#issuecomment-2705742794 You are receiving this beca

Re: [openstreetmap/openstreetmap-website] Show new/modified/deleted count in place of " πŸ–Š" in changeset card (Issue #5758)

2025-03-06 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#5758) I suppose this will be rather slow, because we don’t store this information on changeset level. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5758#issuecomment

Re: [openstreetmap/openstreetmap-website] Directions on open street maps website only in Kilometers (Issue #5760)

2025-03-06 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#5760) Duplicate of #5759 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5760#issuecomment-2705722791 You are receiving this because you are subscribed to this thread.

[openstreetmap/openstreetmap-website] User activity queries (PR #5761)

2025-03-06 Thread Emin Kocan via rails-dev
### Description Adds a new UserActivities module that provides structured access to a user's activity history as part of #5298. The module fetches and organizes activities (changesets, diary entries, comments, GPX uploads) by day and type using SQL queries. Key features: - Groups activities hi

[openstreetmap/openstreetmap-website] Directions on open street maps website only in Kilometers (Issue #5760)

2025-03-06 Thread Lonkmapp via rails-dev
Lonkmapp created an issue (openstreetmap/openstreetmap-website#5760) ### URL _No response_ ### How to reproduce the issue? Is there a way to add an option for miles so you can choose either kilometers or miles when looking up driving directions on openstreetmaps.org Would love this to be

Re: [openstreetmap/openstreetmap-website] Add user profile heatmap visualization for contributions (PR #5402)

2025-03-06 Thread Emin Kocan via rails-dev
kcne left a comment (openstreetmap/openstreetmap-website#5402) Now that #5654 was merged, I think current implementation is already setup to support this. Please let me know if i need to add anything else to support it. Thank you. -- Reply to this email directly or view it on GitHub: https://g

Re: [openstreetmap/openstreetmap-website] Directions on open street maps website only in Kilometers (Issue #5759)

2025-03-06 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#5759) Duplicate of #1747 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5759#issuecomment-2705667755 You are receiving this because you are subscribed to this thread.

Re: [openstreetmap/openstreetmap-website] Add date indexes on gpx_files and notes tables (PR #5747)

2025-03-06 Thread Emin Kocan via rails-dev
@kcne pushed 2 commits. f447f2c5c483435e7e48f1df02eb930982b343fd Add index on gpx_files table on user_id, id b3336668b755d59c6ac04a2b063abde822fc547e Add index on notes.user_id and created_at for non-anonymus notes -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/

Re: [openstreetmap/openstreetmap-website] Add date indexes on gpx_files and notes tables (PR #5747)

2025-03-06 Thread Emin Kocan via rails-dev
@kcne pushed 2 commits. 1a52600d4059bf5d0d16b26fc52affc1288d9c2e Add index on gpx_files table on user_id, id 06a30d59a8c970186c8ec23496bed46a21295460 Add index on note table user,id, created_at for non-anonymus notes -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-websit

Re: [openstreetmap/openstreetmap-website] Add date indexes on gpx_files and notes tables (PR #5747)

2025-03-06 Thread Emin Kocan via rails-dev
@kcne pushed 1 commit. 039c8db13c8ed0dac50ded6dfb7ae478a4ff7ba1 add note table user_id, created_at index for non-anonymus notes -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5747/files/227894193df8916aeda13038cae97a529eef1ad3..039c8db13c8ed0dac50ded6dfb7ae47

Re: [openstreetmap/openstreetmap-website] Use svg symbols for routing icons (PR #5753)

2025-03-06 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 4 commits. f9caa1adc0bd76f39e8da886bef8a0d1d9934b5e Write directions sidebar header using .erb template bede9d28f1fc887010f937d08f00ec5178d9d481 Hide loader spinner when sidebar content is not displayed 0dc63081681c0a2a6ff69c4b8d22626e4bb34f00 Move directions title out of

[openstreetmap/openstreetmap-website] Directions on open street maps website only in Kilometers (Issue #5759)

2025-03-06 Thread Lonkmapp via rails-dev
Lonkmapp created an issue (openstreetmap/openstreetmap-website#5759) ### Problem Is there a way to add an option for miles so you can choose either kilometers or miles when looking up driving directions on openstreetmaps.org Would love this to be possible ! Let me know . Thank you ### De

Re: [openstreetmap/openstreetmap-website] allow markdown in changeset comments (#844)

2025-03-06 Thread Andrew Harvey via rails-dev
andrewharvey left a comment (openstreetmap/openstreetmap-website#844) would be nice to use selected wikitext templates like `{{tag|informal|yes}}` or alternatively just parse out a pasted URL like `https://wiki.openstreetmap.org/wiki/Tag:informal%3Dyes` and display it as [`informal`](https://wi

Re: [openstreetmap/openstreetmap-website] Add date indexes on gpx_files and notes tables (PR #5747)

2025-03-06 Thread Emin Kocan via rails-dev
@kcne pushed 1 commit. a6766cff7ae04aeaca1c42e4b98745c555a2c0b5 Add index on gpx_files table on user_id, id -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5747/files/c151b2d5ad2c0d2985be419a2c594996915cc356..a6766cff7ae04aeaca1c42e4b98745c555a2c0b5 You are re

Re: [openstreetmap/openstreetmap-website] Add date indexes on gpx_files and notes tables (PR #5747)

2025-03-06 Thread Emin Kocan via rails-dev
@kcne pushed 2 commits. a9bc9c2bf1c426ed14a9480c052be95ed5fed741 Add index on gpx_files table on user_id, id b3783b8569ee1405cf8565e2df5691c460a4fd8a Add index on notes.user_id and created_at for non-anonymus notes -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/

Re: [openstreetmap/openstreetmap-website] Add date indexes on gpx_files and notes tables (PR #5747)

2025-03-06 Thread Emin Kocan via rails-dev
@kcne pushed 2 commits. f63abe0406a092946dcb99ccb346eee00e6408ab Add index on gpx_files table on user_id, id c151b2d5ad2c0d2985be419a2c594996915cc356 Add index on notes.user_id and created_at for non-anonymus notes -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/

[openstreetmap/openstreetmap-website] Show new/modified/deleted count in place of " πŸ–Š" in changeset card (Issue #5758)

2025-03-06 Thread Andrew Harvey via rails-dev
andrewharvey created an issue (openstreetmap/openstreetmap-website#5758) ### Problem The current " πŸ–Š" count in the changesets cards makes it hard to know exactly what type of edits were made. ### Description In OSMCha it shows added/modified/deleted feature counts as ![Image](https://github.c

[openstreetmap/openstreetmap-website] Omit changeset "πŸ’¬" from changeset list where there are no comments (Issue #5757)

2025-03-06 Thread Andrew Harvey via rails-dev
andrewharvey created an issue (openstreetmap/openstreetmap-website#5757) ### Problem A common use case of mine is to scan through a list of changesets to see what has comments. However perhaps due to recent changes? I find it hard to spot changesets with comments vs those without. Perhaps even

Re: [openstreetmap/openstreetmap-website] Searching for resolved issues last updated by me finds none (#1936)

2025-03-06 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#1936) The search didn't change since this was opened, but the logic recording who last updated the issue did. #3217 should have fixed this bug, except for earlier issues where the information about updating user was lost. -- Reply

Re: [openstreetmap/openstreetmap-website] Use svg symbols for routing icons (PR #5753)

2025-03-06 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5753) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5753#issuecomment-2704556961 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

2025-03-06 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 1 commit. 19f498e6e76682841234c643fca168951db4c6a3 Remove controls sprite -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5752/files/d043a08822d57501e959c8fabae6fcdcd90d1b34..19f498e6e76682841234c643fca168951db4c6a3 You are receiving this because

Re: [openstreetmap/openstreetmap-website] Use svg symbols for routing icons (PR #5753)

2025-03-06 Thread Tom Hughes via rails-dev
Merged #5753 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5753#event-16621262040 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Increase contrast of comments/changes counters in history (PR #5756)

2025-03-06 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5756) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5756#issuecomment-2704564536 You are receiving this because you are subscribed to this t

[openstreetmap/openstreetmap-website] Increase contrast of comments/changes counters in history (PR #5756)

2025-03-06 Thread Anton Khorev via rails-dev
Addresses https://github.com/openstreetmap/openstreetmap-website/issues/5329#issuecomment-2704353857, although it's not a dark mode issue and not a recent change issue. Contrast was low all along. Before: ![image](https://github.com/user-attachments/assets/83dfdd3a-4c57-450c-9e37-1a75543380b2)

Re: [openstreetmap/openstreetmap-website] Add date indexes on gpx_files and notes tables (PR #5747)

2025-03-06 Thread Tom Hughes via rails-dev
@tomhughes commented on this pull request. > @@ -0,0 +1,7 @@ +class AddNotesUserIdCreatedAtIndex < ActiveRecord::Migration[7.2] + disable_ddl_transaction! + + def change +add_index :notes, [:user_id, :created_at], :algorithm => :concurrently I'd suggest adding `:where => "user_id IS NOT N

Re: [openstreetmap/openstreetmap-website] Write directions sidebar header using .erb template (PR #5754)

2025-03-06 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5754) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5754#issuecomment-2704367045 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

2025-03-06 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > +$(L.SVG.create("svg")) + .append( +$(L.SVG.create("path")).attr("d", "M3 1s9 7 9 7c-1.056.587-2.112 1.173-3.168 1.76l3.031 6.615c.346.753.015 1.643-.738 1.989-.753.345-1.643.014-1.989-.739L6.201 11.221C5.134 11.814 4.067 12.407 3

Re: [openstreetmap/openstreetmap-website] Searching for resolved issues last updated by me finds none (#1936)

2025-03-06 Thread Anton Khorev via rails-dev
Closed #1936 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1936#event-16618532370 You are receiving this because you are subscribed to this thread. Message ID: ___ rai

Re: [openstreetmap/openstreetmap-website] Use svg symbols for routing icons (PR #4901)

2025-03-06 Thread Anton Khorev via rails-dev
Closed #4901. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4901#event-16614809305 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Not straightforward to see previous position of a node (#576)

2025-03-06 Thread Anton Khorev via rails-dev
Closed #576 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/576#event-16617603018 You are receiving this because you are subscribed to this thread. Message ID: ___ rails

Re: [openstreetmap/openstreetmap-website] Add user profile heatmap visualization for contributions (PR #5402)

2025-03-06 Thread Anton Khorev via rails-dev
@AntonKhorev approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5402#pullrequestreview-2664178796 You are receiving this because you are subscribed to this thread. Message ID:

Re: [openstreetmap/openstreetmap-website] Use svg symbols for routing icons (PR #4901)

2025-03-06 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#4901) Superseded by #5753 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4901#issuecomment-2703424721 You are receiving this because you are subscribed to this threa

Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

2025-03-06 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > +$(L.SVG.create("svg")) + .append( +$(L.SVG.create("path")).attr("d", "M3 1s9 7 9 7c-1.056.587-2.112 1.173-3.168 1.76l3.031 6.615c.346.753.015 1.643-.738 1.989-.753.345-1.643.014-1.989-.739L6.201 11.221C5.134 11.814 4.067 12.407 3

Re: [openstreetmap/openstreetmap-website] Write directions sidebar header using .erb template (PR #5754)

2025-03-06 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 3 commits. 18f03fe59b71d9eb08d7864b3d5b5a86c56e4972 Write directions sidebar header using .erb template 09b9108e7af5d45bac4904f7c8bafe468b33f345 Hide loader spinner when sidebar content is not displayed 929b499222ef905d7d67ee39e8ff96d7e6b6651e Move directions title out of

Re: [openstreetmap/openstreetmap-website] Write directions sidebar header using .erb template (PR #4900)

2025-03-06 Thread Anton Khorev via rails-dev
Closed #4900. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4900#event-16614562872 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Write directions sidebar header using .erb template (PR #4900)

2025-03-06 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#4900) Superseded by #5754 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4900#issuecomment-2703383291 You are receiving this because you are subscribed to this threa

Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

2025-03-06 Thread Holger Jeromin via rails-dev
@HolgerJeromin commented on this pull request. > +$(L.SVG.create("svg")) + .append( +$(L.SVG.create("path")).attr("d", "M3 1s9 7 9 7c-1.056.587-2.112 1.173-3.168 1.76l3.031 6.615c.346.753.015 1.643-.738 1.989-.753.345-1.643.014-1.989-.739L6.201 11.221C5.134 11.814 4.067 12.407

Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

2025-03-06 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#5752) So where should I put the `defs` then? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5752#issuecomment-2703126353 You are receiving this because you are subscribed

Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

2025-03-06 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5752) The sprite existed mainly because of Leaflet controls. They are created with javascript. You'll start putting more stuff in javascript to avoid using the sprite, and then @gravitystorm will tell you this: #5616. My plan was t

Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

2025-03-06 Thread Marwin Hochfelsner via rails-dev
@hlfan commented on this pull request. > +$(L.SVG.create("svg")) + .append( +$(L.SVG.create("path")).attr("d", "M3 1s9 7 9 7c-1.056.587-2.112 1.173-3.168 1.76l3.031 6.615c.346.753.015 1.643-.738 1.989-.753.345-1.643.014-1.989-.739L6.201 11.221C5.134 11.814 4.067 12.407 3 13V1

Re: [openstreetmap/openstreetmap-website] Rename browse controller to queries controller (PR #4616)

2025-03-06 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#4616) Superseded by #5751 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4616#issuecomment-2703095640 You are receiving this because you are subscribed to this threa