Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-02 Thread Holger Jeromin via rails-dev
@HolgerJeromin approved this pull request. But I did not tested this. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4789#pullrequestreview-2653141690 You are receiving this because you are subscribed to this thread. Message I

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-02 Thread Máté Gyöngyösi via rails-dev
@gy-mate pushed 1 commit. 56c38f7466728951ca021e83c90340fe29e9e997 Add button instead of hyperlinking time_ago -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4789/files/976f0616d699fcd8632723a751aa26cca51d2f17..56c38f7466728951ca021e83c90340fe29e9e997 You are

[openstreetmap/openstreetmap-website] Remove obsolete element from docker-compose.yml (PR #5743)

2025-03-02 Thread Máté Gyöngyösi via rails-dev
### Description The 'version' top-level Docker Compose element is deprecated since April 2024: https://github.com/docker/docs/commit/007ac90154c05f34045f607631b93a95c81d4807#diff-948ba582fe1c0dd6e8a5446ed8d8831e8ff65d0df7552f0eaa22b9ff7945b3e3R7 ### How has this been tested? On my Mac using th

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-02 Thread Máté Gyöngyösi via rails-dev
gy-mate left a comment (openstreetmap/openstreetmap-website#4789) > There was a previous attempt #4134. It had the advantage of NOT adding link > to the time, in case clicking the time is supposed to do something else like > #4361. @AntonKhorev You're right—I've tried to go this way. Does it se

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-02 Thread github-actions[bot] via rails-dev
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#4789) 1 Warning :warning: Merge commits are found in PR. Please rebase to get rid of the merge commits in this PR, see CONTRIBUTING.md. Genera

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-02 Thread Máté Gyöngyösi via rails-dev
gy-mate left a comment (openstreetmap/openstreetmap-website#4789) I'm sorry for the merge commits—I'll pay attention to this next time! 🤞 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4789#issuecomment-2693018101 You are receivi

Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)

2025-03-02 Thread Máté Gyöngyösi via rails-dev
@gy-mate pushed 1 commit. 976f0616d699fcd8632723a751aa26cca51d2f17 Correct link_to() destination parameter -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4789/files/f892c072040601ee3b0d38b65fd2f68378fa997a..976f0616d699fcd8632723a751aa26cca51d2f17 You are rec

Re: [openstreetmap/openstreetmap-website] Add user profile heatmap visualization for contributions (PR #5402)

2025-03-02 Thread Tom Hughes via rails-dev
@tomhughes commented on this pull request. > @@ -0,0 +1,100 @@ +//= require d3/dist/d3 +//= require cal-heatmap/dist/cal-heatmap +//= require popper I don't understand how this works? Shouldn't it be `@popperjs/core` or something here? How is it finding `popper` and is it actually finding the

Re: [openstreetmap/openstreetmap-website] Split the combined directions engines translations into routers and modes (Issue #5629)

2025-03-02 Thread Marwin Hochfelsner via rails-dev
Closed #5629 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5629#event-16519070404 You are receiving this because you are subscribed to this thread. Message ID: ___ rai

Re: [openstreetmap/openstreetmap-website] Move jquery .load() to fetch (PR #5731)

2025-03-02 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 1 commit. d9f4559bd3304b2206a53d2ff9292c1e9813ff46 Cache csrf properties -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5731/files/a67b8afc9470e68855e92215078f971737705cae..d9f4559bd3304b2206a53d2ff9292c1e9813ff46 You are receiving this because y

Re: [openstreetmap/openstreetmap-website] Copies notes details from first comments to notes table (PR #5667)

2025-03-02 Thread Tom Hughes via rails-dev
Merged #5667 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5667#event-16524749317 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Copies notes details from first comments to notes table (PR #5667)

2025-03-02 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5667) I think this is fine in this case, so I'm going to go ahead and merge it. Thanks for all the work. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5667#issuecomm