Reopened #5639.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5639#event-16523674681
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mail
HarelM left a comment (openstreetmap/openstreetmap-website#5639)
Should I be opening a different issue or should this issue be reopened?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5639#issuecomment-2692427652
You are receiv
@1ec5 commented on this pull request.
> +
+ var copyright = I18n.t("javascripts.map.copyright_text", {
copyright_link: copyright_link });
+
+ var openmaptiles_link = I18n.t("javascripts.map.openmaptiles", {
+openmaptiles_url: "https://openmaptiles.org/";,
+maptiler_url
@AntonKhorev commented on this pull request.
> @@ -1,6 +1,7 @@
<%= tag.head :data => application_data do %>
<%= render :partial => "layouts/meta" %>
<%= javascript_include_tag "turbo", :type => "module" %>
+ <%= javascript_include_tag "make-plural/cardinals" %>
Name collisions. They hav
@AntonKhorev commented on this pull request.
> +
+ var copyright = I18n.t("javascripts.map.copyright_text", {
copyright_link: copyright_link });
+
+ var openmaptiles_link = I18n.t("javascripts.map.openmaptiles", {
+openmaptiles_url: "https://openmaptiles.org/";,
+mapti
Merged #5742 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5742#event-16522552350
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
> @@ -1,6 +1,7 @@
<%= tag.head :data => application_data do %>
<%= render :partial => "layouts/meta" %>
<%= javascript_include_tag "turbo", :type => "module" %>
+ <%= javascript_include_tag "make-plural/cardinals" %>
What's the reason for loadi
tomhughes left a comment (openstreetmap/openstreetmap-website#5742)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5742#issuecomment-2692274664
You are receiving this because you are subscribed to this t
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5737#pullrequestreview-2652403439
You are receiving this because you are subscribed to this thread.
Message ID:
__
tomhughes left a comment (openstreetmap/openstreetmap-website#5733)
I guess the question is does `gem install mini_racer` work on it's own? If it
does then this must be something to do with the combination of modules we
install or something and if it doesn't then it seems it's an issue specific
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5742#pullrequestreview-2652491651
You are receiving this because you are subscribed to this thread.
Message ID:
__
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5402)
With #5654 it's possible to translate the tooltips with language-specific
pluralizations:
```
heatmap:
tooltip:
contributions:
one: "%{count} правка %{date}"
few: "%{count} правки %{date}"
@hlfan pushed 1 commit.
b020b8741f962ab7b63d2e8a663662686a74b4c4 Parse geouri search param with URL
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5736/files/576b394229c54f2c0d4352e7c91e31700abd4c51..b020b8741f962ab7b63d2e8a663662686a74b4c4
You are receiving t
@AntonKhorev pushed 1 commit.
c08111f0b8859b769a1b8e00e9df1afc97caebfd Load pluralizers
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5654/files/77222b03f46ac4782756a08701e46d3232b8f9c3..c08111f0b8859b769a1b8e00e9df1afc97caebfd
You are receiving this because
@AntonKhorev pushed 1 commit.
b6c8ff05c19ce6f6135846dfb256e038e6b38363 Load pluralizers
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5654/files/cfef0e3e8ec02bb59ae522bb7e523ae95644aaf7..b6c8ff05c19ce6f6135846dfb256e038e6b38363
You are receiving this because
@AntonKhorev pushed 1 commit.
cfef0e3e8ec02bb59ae522bb7e523ae95644aaf7 Load pluralizers
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5654/files/c08111f0b8859b769a1b8e00e9df1afc97caebfd..cfef0e3e8ec02bb59ae522bb7e523ae95644aaf7
You are receiving this because
`$(document).ready(...)` is deprecated since jQuery 3.0, see
https://api.jquery.com/ready/
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5742
-- Commit Summary --
* Replace $(document).ready(...) with $(...)
-- F
@hlfan commented on this pull request.
> @@ -80,6 +80,11 @@ OSM = {
const hash = OSM.parseHash(location.hash);
+const geoURI = Object.fromEntries(new URLSearchParams(
+ params.geouri?.replaceAll(/[?;]/g, "&")?.replace(":", "=")
Also, the URL constructor throws a TypeError when
@hlfan pushed 1 commit.
576b394229c54f2c0d4352e7c91e31700abd4c51 Add PWA geo protocol handler
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5736/files/c291b7c625f25e0efae1f1f2f89bbdfe0c87bd75..576b394229c54f2c0d4352e7c91e31700abd4c51
You are receiving this be
Merged #5731 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5731#event-16522152473
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@hlfan commented on this pull request.
> @@ -80,6 +80,11 @@ OSM = {
const hash = OSM.parseHash(location.hash);
+const geoURI = Object.fromEntries(new URLSearchParams(
+ params.geouri?.replaceAll(/[?;]/g, "&")?.replace(":", "=")
How does that help me with parsing semicolon-sepa
@hlfan pushed 1 commit.
c291b7c625f25e0efae1f1f2f89bbdfe0c87bd75 Add PWA geo protocol handler
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5736/files/576b394229c54f2c0d4352e7c91e31700abd4c51..c291b7c625f25e0efae1f1f2f89bbdfe0c87bd75
You are receiving this be
Merged #5740 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5740#event-16522152476
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes pushed 4 commits.
4035e5c05358123fec0e74f109066a6a332e7150 Update to rails 8.0.1
57ee01bfbb396d3e44feec77399a01dac9e0bc5f Replace permit/require with expect
for parameter validation
91735282c6184c816eb4636924d33bda2edc15d1 Avoid parsing of XML requests with ;
in the body
1e84a4e34a
@AntonKhorev commented on this pull request.
> @@ -80,6 +80,11 @@ OSM = {
const hash = OSM.parseHash(location.hash);
+const geoURI = Object.fromEntries(new URLSearchParams(
+ params.geouri?.replaceAll(/[?;]/g, "&")?.replace(":", "=")
What you want to do requires zero regexes a
Merged #5741 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5741#event-16522152472
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5735 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5735#event-16522152485
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5737 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5737#event-16522152475
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5739 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5739#event-16522152465
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5740)
Looks good to me, thanks, though I really want to figure out how to make it
happen automatically but so far my attempts have failed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstr
tomhughes left a comment (openstreetmap/openstreetmap-website#5731)
Thanks. This looks good to me now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5731#issuecomment-2692181404
You are receiving this because you are subscribed
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5738)
> no button is clickable , The whole div should have it from search text to
> search icon
How should it look when the button is focused? You want the outline to include
the button even when the button is not focused, what if
tomhughes left a comment (openstreetmap/openstreetmap-website#5741)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5741#issuecomment-2692180878
You are receiving this because you are subscribed to this t
@hlfan pushed 1 commit.
576b394229c54f2c0d4352e7c91e31700abd4c51 Add PWA geo protocol handler
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5736/files/87c8eab4f80acee6e853cad8a440cd97c46b..576b394229c54f2c0d4352e7c91e31700abd4c51
You are receiving this be
tomhughes left a comment (openstreetmap/openstreetmap-website#5739)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5739#issuecomment-2692179509
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5737)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5737#issuecomment-2692178802
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#5735)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5735#issuecomment-2692177331
You are receiving this because you are subscribed to this t
@tomhughes commented on this pull request.
It would be better to swap the order of the commits I think, so that we don't
wind up implementing CSRF one way and then immediately changing it.
Other than that it looks good to me.
--
Reply to this email directly or view it on GitHub:
https://gith
@hlfan pushed 1 commit.
87c8eab4f80acee6e853cad8a440cd97c46b Add PWA geo protocol handler
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5736/files/fad0df121f6d337760e61e7f895f905686ea5006..87c8eab4f80acee6e853cad8a440cd97c46b
You are receiving this be
@AntonKhorev pushed 1 commit.
614542ad7fe896e158384c7b3cf580e1b6fc4435 Register startinglocation listener as
a named function
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5737/files/cf4537af7762f31a4a7ff75ce833df8ebd9bd6e8..614542ad7fe896e158384c7b3cf580e1b
zydnet left a comment (openstreetmap/openstreetmap-website#5738)
no button is clickable , The whole div should have it from search text to
search icon
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5738#issuecomment-2692133192
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5738)
If you want the outline to include the button when the input is in focus, how
is it supposed to look when the button is in focus?
--
R
@hlfan pushed 1 commit.
fad0df121f6d337760e61e7f895f905686ea5006 Remove replacement of later colons
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5736/files/be85e8a6ed6ea7160672e0684dbb837eb5ab39a2..fad0df121f6d337760e61e7f895f905686ea5006
You are receiving t
@hlfan pushed 1 commit.
be85e8a6ed6ea7160672e0684dbb837eb5ab39a2 Use absolute domain path shorthand
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5736/files/d0d6deffc4197535a99d43fea27e1d1d72c52c4d..be85e8a6ed6ea7160672e0684dbb837eb5ab39a2
You are receiving t
mmd-osm left a comment (openstreetmap/openstreetmap-website#5733)
@jessequinn : it would be good if you could post error messages as text rather
than screenshot. Search here on Github doesn't work that well with images.
--
Reply to this email directly or view it on GitHub:
https://github.com/op
We're supporting WebP format for map downloads now. The change is a left
over from
https://github.com/openstreetmap/openstreetmap-website/pull/5607#issuecomment-2660979843
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/p
See #5672.
It didn't take me long to forget how to run teaspoon, go to the docs, copy
the command and see it fail.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5740
-- Commit Summary --
* Set the environment va
Merged #5734 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5734#event-16521134338
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Currently we have in use:
- `location`
- `window.location`
- `document.location`
The only one that's missing is `window.document.location`. These are
[mostly the
same](https://stackoverflow.com/questions/2430936/whats-the-difference-between-window-location-and-document-location).
We can just us
zydnet created an issue (openstreetmap/openstreetmap-website#5738)
### URL
https://www.openstreetmap.org/#map=16/28.59325/77.25938
### How to reproduce the issue?
1. Click on the Search Bar on the website .
2. you will notice the blue color shadow not fitting near the search bar
completely.
#
The listener is not going to be run once if it's constructed inside the
`locateactivate` listener. It's going to be run however many times
`locateactivate` happens.
Actually neither this custom event nor `locateactivate` is required, but
that's for the next pull request.
You can view, comment o
51 matches
Mail list logo
