@AntonKhorev commented on this pull request.
> @@ -10,5 +10,11 @@
"start_url": "/",
"theme_color": "#7ebc6f",
"background_color": "#fff",
- "display": "minimal-ui"
+ "display": "minimal-ui",
+ "protocol_handlers": [
+ {
+
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5736)
`test/javascripts/osm_test.js` has tests for `mapParams`. If new parameters are
added, you should test them.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/57
@AntonKhorev commented on this pull request.
> @@ -80,6 +80,10 @@ OSM = {
const hash = OSM.parseHash(location.hash);
+const geoURI = Object.fromEntries(new URLSearchParams(
+ params.geouri?.replaceAll(/[?;]/g, "&")?.replaceAll(":", "=")
Are you sure you want `replaceAll(":", "
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5734)
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5734#issuecomment-2692004196
You are receiving this because you are subscribed to this thread.
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5716)
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5716#issuecomment-2691989704
You are receiving this because you are subscribed to this thread.
Merged #5716 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5716#event-16521095742
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@hlfan pushed 1 commit.
d0d6deffc4197535a99d43fea27e1d1d72c52c4d Add PWA geo protocol handler
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5736/files/3613d40b70b40e8222c5066499bea2fb92f840f7..d0d6deffc4197535a99d43fea27e1d1d72c52c4d
You are receiving this be
### Description
This PR adds a geo protocol handler in the web manifest and the functionality
for parsing in mapParams.
We can't directly parse it as it arrives wrapped in `encodeURIComponent`,
`geo:48.410,12.060?z=9` would be handled as
https://www.openstreetmap.org/?geouri=geo%3A48.410%2C12.060
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5734#pullrequestreview-2651664369
You are receiving this because you are subscribed to this thread.
Message ID:
__
@hlfan commented on this pull request.
>engines:
-fossgis_osrm_bike: "Bicycle (OSRM)"
-fossgis_osrm_car: "Car (OSRM)"
-fossgis_osrm_foot: "Foot (OSRM)"
-graphhopper_bicycle: "Bicycle (GraphHopper)"
-graphhopper_car: "Car (GraphHopper)"
-gra
I broke the webmanifest icon list by not removing gsub.
But I'm making up for it by adding an SVG icon.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5735
-- Commit Summary --
* Fix icon list
-- File Changes --
gravitystorm left a comment (openstreetmap/openstreetmap-website#5733)
Re-opening, since we try to support developers with fresh installs, up to the
point that they can get the tests running.
@jessequinn I'm sorry to see that it's not working for you. Can you confirm for
me (and everyone else w
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5734
-- Commit Summary --
* Delete mismatched ul close tag
-- File Changes --
M app/views/accounts/terms/_terms.html.erb (1)
-- Patch Links --
https://github.c
jessequinn left a comment (openstreetmap/openstreetmap-website#5733)
amd64 image on gcp, natively on 24.04 ubuntu, as per your own install.md,
nothing stands out here, typical linux compute engine we have on gcp.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstree
tomhughes left a comment (openstreetmap/openstreetmap-website#5733)
This is https://github.com/rubyjs/mini_racer/issues/305 /
https://github.com/rubyjs/libv8-node/pull/36 which has already been mentioned
in #5070 here.
--
Reply to this email directly or view it on GitHub:
https://github.com/op
@kcne commented on this pull request.
> @@ -0,0 +1,100 @@
+//= require d3/dist/d3
+//= require cal-heatmap/dist/cal-heatmap
+//= require popper
This import is the same as the one inside `application.js` and was not
introduced in this PR. It's provided by the [popper_js
gem](https://github.com
Reopened #5733.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5733#event-16516312905
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mail
tomhughes left a comment (openstreetmap/openstreetmap-website#5733)
There was discussion of a similar issue in #5010 that might help, but in
general we can't help with problems with third party components - it's
something you need to take up with mini_racer.
--
Reply to this email directly or
Closed #5733 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5733#event-16516147849
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
jessequinn created an issue (openstreetmap/openstreetmap-website#5733)
### URL
_No response_
### How to reproduce the issue?
bundle install fails on mini racer
https://github.com/user-attachments/assets/911d21c9-16b2-4187-9b6c-206c20fa7a0a";
/>
### Screenshot(s) or anything else?
_No respon
tomhughes left a comment (openstreetmap/openstreetmap-website#5716)
Yes looks like `annotaterb` must do something differently that means we need to
setup storage.
I've fixed that nopw, and tested a broken annotation in
https://github.com/tomhughes/openstreetmap-website/actions/runs/13593200376/
tomhughes left a comment (openstreetmap/openstreetmap-website#5732)
Looks good to me, thanks.
To make `preferred_color_scheme` work we'd need to generate two versions of
`manifest.json` and then have `app/views/layouts/_meta.html.erb` decide which
one to link to in the meta headers, as `app/vie
Merged #5732 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5732#event-16515642844
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5731)
I don't understand why jQuery was adding the csrf token automatically here when
we always seem to have added it manually in other places. Very odd...
Other places actually add it as a parameter using the `csrf-param` meta value
@AntonKhorev commented on this pull request.
> @@ -24,7 +26,15 @@
<% @notes.each do |note| -%>
- class="table-primary"<% end %>>
+<% opened_by_user = note.author == @user %>
+<% closed_by_user = note.comments.last&.author == @user &&
note.comments.last&.event == "cl
@AntonKhorev pushed 1 commit.
78c2752670aef4d799150b06c7af7e1d5bd869db Replace submitted note table color
with created/resolved
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5269/files/837aeea405129719503141350d8b669c03cbd4a3..78c2752670aef4d799150b06c7af7e1
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5716)
Is the github workflow working correctly? I see a bunch of messages like
```
Unable to process app/models/changeset.rb: Couldn't find Active Storage
configuration in
/home/runner/work/openstreetmap-website/openstreetmap-websi
hlfan left a comment (openstreetmap/openstreetmap-website#5732)
So how can I not flash-bang users without `preferred_color_scheme`?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5732#issuecomment-2690442287
You are receiving thi
@hlfan pushed 1 commit.
a67b8afc9470e68855e92215078f971737705cae Move jquery .load() to fetch
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5731/files/5741dfd50c9ffbdfcbf11eafac5f0981acfaed5d..a67b8afc9470e68855e92215078f971737705cae
You are receiving this be
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5731#pullrequestreview-2650507505
You are receiving this because you are subscribed to this thread.
Message ID:
__
@hlfan pushed 1 commit.
4059b961ecb29194a88efd6a8352be19cd7a759a Add colors and abbreviation to web
manifest
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5732/files/6ce0a13f599dbe4db657092d1e4f24bb15a5ef43..4059b961ecb29194a88efd6a8352be19cd7a759a
You are r
@hlfan pushed 1 commit.
6ce0a13f599dbe4db657092d1e4f24bb15a5ef43 Generate icon entries dynamically
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5732/files/d96f8a0b48e133fda1bf0d06010b44f00670181d..6ce0a13f599dbe4db657092d1e4f24bb15a5ef43
You are receiving th
Looping through icon resolutions and adding a few parameters.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5732
-- Commit Summary --
* Improve the web manifest
-- File Changes --
M app/assets/favicons/manife
33 matches
Mail list logo
