@HolgerJeromin commented on this pull request.
> +.then(html => $section.html(html))
+.then(update);
Right now `update` will get the html from the `.html(html)` [jquery
call](https://api.jquery.com/html/#html2).
This would prevent "leaking" the data into the next promise chain:
@HolgerJeromin commented on this pull request.
> +.then(html => $section.html(html))
+.then(update);
Same in app/assets/javascripts/user.js file
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5731#discussion_r1
tomhughes left a comment (openstreetmap/openstreetmap-website#5652)
I had already merged this before that last change - can you open a new PR for
it?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5652#issuecomment-2689061779
Yo
Continuing the move away from XHR.
There's probably a nice method to include the CSRF tokens under the hood,
but at least this makes the need obvious.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5731
-- Commit Summ
Merged #5729 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5729#event-16503832850
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5730)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5730#issuecomment-2689212512
You are receiving this because you are subscribed to this t
Merged #5730 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5730#event-16503832864
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5729)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5729#issuecomment-2689209543
You are receiving this because you are subscribed to this t
Moving even more requests away from XHR and jquery.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5730
-- Commit Summary --
* Replace jquery's getJSON with fetch
-- File Changes --
M app/assets/javascripts/in
tomhughes left a comment (openstreetmap/openstreetmap-website#5727)
This is throwing an exception for me if I activate it with routing already open:
--
Reply to this email directly or view it on GitHub:
h
The unmerged remnants of #5652
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5729
-- Commit Summary --
* Clean up new direction form
-- File Changes --
M app/assets/javascripts/index/directions.js (2)
M a
hlfan left a comment (openstreetmap/openstreetmap-website#5652)
See #5729
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5652#issuecomment-2689083414
You are receiving this because you are subscribed to this thread.
Message ID:
tomhughes left a comment (openstreetmap/openstreetmap-website#5727)
Thanks. This look good to me now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5727#issuecomment-2689054426
You are receiving this because you are subscribed t
Closed #5635 via #5727.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5635#event-16502908731
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-de
Closed #5652.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5652#event-16502934472
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Closed #5671 via #5727.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5671#event-16502908823
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-de
Merged #5727 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5727#event-16502908447
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5671)
Thanks for this, but I think I prefer @hlfan's version in #5727.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5671#issuecomment-2689056506
You are receiving th
@hlfan pushed 1 commit.
e41492ad0a9420980982d186ee022335dc6131de Split directions engine select into
modes and providers
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5652/files/459d3b314a900b3fb83eb88502bb29e1c961082e..e41492ad0a9420980982d186ee022335dc6131
hlfan left a comment (openstreetmap/openstreetmap-website#5652)
I just found a couple things to remove, hold on
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5652#issuecomment-2689050574
You are receiving this because you are su
tomhughes left a comment (openstreetmap/openstreetmap-website#5652)
Thanks. I think this looks good now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5652#issuecomment-2689048220
You are receiving this because you are subscribe
hlfan left a comment (openstreetmap/openstreetmap-website#5727)
The destructuring looks a bit more silly now but it works.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5727#issuecomment-2688979325
You are receiving this because
@hlfan pushed 1 commit.
370fe0855e8eef97bbe58dc559957ac303decc33 Set directions departure to location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5727/files/728279eac41e740f1fce56a33688641ae83b59d6..370fe0855e8eef97bbe58dc559957ac303decc33
You are receiving
hlfan left a comment (openstreetmap/openstreetmap-website#5652)
Squashed. Just wanted to have
https://github.com/openstreetmap/openstreetmap-website/commit/0a0835dbfa38bef1c1e19d852e349e13a6753e7c
not yet mixed in in case of a revision.
--
Reply to this email directly or view it on GitHub:
htt
tomhughes left a comment (openstreetmap/openstreetmap-website#5727)
Because the `latlng` that arrives in the `startinglocation` event handler is an
object with the `0` and `1` keys from the array but also a bunch of other keys.
--
Reply to this email directly or view it on GitHub:
https://githu
@tomhughes requested changes on this pull request.
> @@ -52,6 +52,13 @@ time[title] {
color: $blue;
}
+/* Utility for transparent color */
+
+.text-transparent{
Space before the brace please.
> @@ -0,0 +1,15 @@
+
+
+
+
+ <% unless disabled %>
+
I don't really like the whole
Merged #5728 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5728#event-16501455873
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5652)
Thanks for the ordering change - can we just squash those last two commits
together? There doesn't seem to be any point doing it one way and then fixing
it to do it a different way.
--
Reply to this email directly or view it o
kcne left a comment (openstreetmap/openstreetmap-website#5298)
I've successfully implemented this locally and plan to start opening PRs for
this soon. The implementation will be completed in stages, with the following
plan:
1. Add new indexes to activity-related tables to optimize query perfo
29 matches
Mail list logo
