Closed #5720.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5720#event-16470970823
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
@hlfan pushed 1 commit.
3ce4387967f7ba522ede2c71d252c510af4f5d7b Hard-code order
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5652/files/0a0835dbfa38bef1c1e19d852e349e13a6753e7c..3ce4387967f7ba522ede2c71d252c510af4f5d7b
You are receiving this because you are
@hlfan commented on this pull request.
> -});
- }
-
- function setEngine(index) {
-chosenEngine = engines[index];
-select.val(index);
+ function setEngine(id) {
+const engines = OSM.Directions.engines;
+const desired = engines.find(engine => engine.id() === id);
+if (!
@tomhughes commented on this pull request.
> +
+
+
+
+ <% %w[car bicycle foot]
+ .map { |id| { :id => id, :title => t("site.search.modes.#{id}")
} }
+ .sort_by { |mode| mode[:title] }
+ .each do |mode| %>
+
@tomhughes commented on this pull request.
> -});
- }
-
- function setEngine(index) {
-chosenEngine = engines[index];
-select.val(index);
+ function setEngine(id) {
+const engines = OSM.Directions.engines;
+const desired = engines.find(engine => engine.id() === id);
+i
@tomhughes pushed 4 commits.
2fd03f9e258e52e44a1bdfc086fa7517241e7528 Update to rails 8.0.1
3d3ae8a059589b2a556ce87ab94e1cea0edef07e Avoid parsing of XML requests with ;
in the body
c95d9165bddb36a23ec9177a914ad10c8d0dd90a Use rails 8 compatible
active_record_union
a3f512999a097b0c550fc42a9ff
@tomhughes commented on this pull request.
> @@ -148,7 +148,11 @@ def search_osm_nominatim_reverse
:type => object_type, :id => object_id)
end
-render :action => "results"
+if params[:format] == "json"
+ render :json => @results
+else
+ render :a
@tomhughes pushed 3 commits.
c17ecd788fa8922a2a888998689dcd1d0a1c1ace Switch to using annotaterb for
annotations
dacd4716ca5bc2a4b7ca02fa72298ea572bf4f2f Update model annotations
866747c49dafd8ff783eb117e3980897ca3be977 Drop explicit lengths from bigint
columns
--
View it on GitHub:
https:/
tomhughes left a comment (openstreetmap/openstreetmap-website#5667)
Well we don't currently have the infrastructure in place for that method, and
I'm not sure this change is large enough to really need it.
The big problem with that approach is that it doesn't force the migration to
happen, so y
nenad-vujicic left a comment (openstreetmap/openstreetmap-website#5667)
@tomhughes do you think we can continue with current version of this PR or we
should try with more robust data-migration proposed
[here](https://github.com/openstreetmap/openstreetmap-website/pull/5667#issuecomment-265989844
10 matches
Mail list logo
