AntonKhorev left a comment (openstreetmap/openstreetmap-website#5715)
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5715#issuecomment-2677185706
You are receiving this because you are subscribed to this thread.
Merged #5715 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5715#event-16423376227
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#5726)
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Gener
Previously there were `hide` and `unhide` actions on changeset comments and an
attempt to change them into standard actions which didn't quite work. It
went like this: hiding a comment is like deleting, let's map `hide` path to
`destroy` action; unhiding is like... there's no standard
undelete/
HarelM left a comment (openstreetmap/openstreetmap-website#5639)
Thanks for looking into this!
I'm still getting the same error message as above though.
I'm testing this from the browser console when the site
https://israelhiking.osm.org.il and I'm running the following fetch (using my
OAuth2 he
Merged #5725 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5725#event-16422414356
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5725)
The name of that helper is unfortunate as you say but there's not a lot we can
do by the sounds of it, so I think this looks good, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/o
@AntonKhorev pushed 1 commit.
b25f3fe9bc367c7d59c48ea0961ab4bbc058975f Create api changeset comment
subscription resource
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5590/files/ef7c509866378668b0995396307c0c9fbccde5d1..b25f3fe9bc367c7d59c48ea0961ab4bbc0589
Paths are not changed because there was no `PUT .../create` for creating
changeset comments.
The only thing that's going to look a little strange is the path helper.
It's named `api_changeset_changeset_comments_path` with
"changeset" twice. That's how rails normally names it because we
have `C
tomhughes left a comment (openstreetmap/openstreetmap-website#5639)
I've made a change to allow access to the active storage endpoints and that is
now live which will hopefully have fixed this - certainly it seems to work
locally for me.
--
Reply to this email directly or view it on GitHub:
ht
Closed #5639 as completed via 753b948029aa82e28b94ccbc927218d0d5716510.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5639#event-16422314003
You are receiving this because you are subscribed to this thread.
Message ID:
__
tomhughes left a comment (openstreetmap/openstreetmap-website#5639)
Having now setup a test and tried this locally I think we may all have been
misunderstanding the exact problem here, mainly due to the somewhat confusing
error from the browser.
What confused me was the "redirect is not allowed
@AntonKhorev pushed 8 commits.
631e233280eb6f4f12578e458757b36d66cfb18d Make changeset comment create action
resourceful
4cb8ccca01e43c5007b716d16d8cd408eb15f068 Test response body of changeset
comment hide/unhide
941be513287078c8add818978a77a1e558b0acbf Create api changeset comment
visibili
tomhughes left a comment (openstreetmap/openstreetmap-website#5724)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5724#issuecomment-2677066990
You are receiving this because you are subscribed to this t
Merged #5724 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5724#event-16422156329
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5720)
Right but as you yourself said there's no actual change to what is displayed at
the moment, unless I've misunderstood something? So that's because the engines
only return multiple legs with via points?
--
Reply to this email d
@AntonKhorev pushed 1 commit.
316ce7b4e94cf92ee4e231417f5ef741a1619119 Add show_redactions param to
changeset downloads
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5724/files/41ebc3cb6ff6a29701f4014e2113552b031c6665..316ce7b4e94cf92ee4e231417f5ef741a161911
This PR adds a missing feature in osm-website as compared to cgimap.
There's a `show_redactions` parameter which lets moderators see redacted
element versions. In osm-website it works with element versions and histories.
In cgimap it also works with changeset downloads. Without this parameter
i
@tomhughes commented on this pull request.
> +openmaptiles_url: "https://openmaptiles.org/";,
+maptiler_url: "https://www.maptiler.com/";
+ });
+
+ var terms = $("", {
+href: "https://wiki.osmfoundation.org/wiki/Terms_of_Use";,
+text: I18n.t("javascripts
@1ec5 commented on this pull request.
> @@ -9,6 +14,43 @@ L.extend(L.LatLngBounds.prototype, {
}
});
+if (OSM.MAPTILER_KEY) {
+ maplibregl.setRTLTextPlugin(
+
"https://api.mapbox.com/mapbox-gl-js/plugins/mapbox-gl-rtl-text/v0.2.3/mapbox-gl-rtl-text.js";,
See
https://github.com/opens
hlfan left a comment (openstreetmap/openstreetmap-website#5720)
The goal is to display the routing engines' responses more accurately. Since
all of these support multiple legs, the sidebar does too, now.
And while this is a step to support via points, I wouldn't call that the goal.
--
Reply to
tomhughes left a comment (openstreetmap/openstreetmap-website#4042)
Also, the eslint warnings should be fixed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-2676933485
You are receiving this because you are sub
@tomhughes requested changes on this pull request.
> @@ -107,6 +107,8 @@ attachments_dir: ":rails_root/public/attachments"
#logstash_path: ""
# List of memcache servers to use for caching
#memcache_servers: []
+# URL of Maptiler API for vector maps
+maptiler_url: "https://api.maptiler.com/";
Closed #551 as completed via
openstreetmap/chef@3a68c02726f4f4c835b4b3d11367a542cbdce6f4.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/551#event-16419313054
You are receiving this because you are subscribed to this thread.
M
tomhughes left a comment (openstreetmap/openstreetmap-website#5720)
So the goal here is to eventually support via points?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5720#issuecomment-2676800886
You are receiving this because
tomhughes left a comment (openstreetmap/openstreetmap-website#5721)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5721#issuecomment-2676780086
You are receiving this because you are subscribed to this t
Merged #5721 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5721#event-16419095649
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes pushed 1 commit.
ff0c1b492a966b183d8a03f47bc4b8c9f598418d Filter out invisible nodes and ways
during initial selection
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5589/files/b4c0c62b403e6ed400f79f4d9d5f666ab620a28f..ff0c1b492a966b183d8a03f47bc4b
28 matches
Mail list logo
