Merged #5694 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5694#event-16390015634
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5224 as completed via #5694.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5224#event-16390015797
You are receiving this because you are subscribed to this thread.
Message ID:
_
@tomhughes commented on this pull request.
> @@ -43,7 +43,7 @@ def show
@note_includes_anonymous = @note.author.nil? || @note_comments.find {
|comment| comment.author.nil? }
-@note_comments = @note_comments.drop(1) if @note.author.nil? ||
@note.author.active?
+@note_comments =
@nenad-vujicic commented on this pull request.
> @@ -43,7 +43,7 @@ def show
@note_includes_anonymous = @note.author.nil? || @note_comments.find {
|comment| comment.author.nil? }
-@note_comments = @note_comments.drop(1) if @note.author.nil? ||
@note.author.active?
+@note_commen
@tomhughes approved this pull request.
Thanks. This looks good to me now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5694#pullrequestreview-2631270021
You are receiving this because you are subscribed to this thread.
Messa
@nenad-vujicic pushed 3 commits.
8f2a87d12c167baa958d3f460edfb2bccaaf9ead Improves behavior if note lacks
opening comment
6df4e57a469c4637b40b8714487b613a54aa2b95 Improves dropping of first note's
comment
1c51e4ea7bd5a8d2d81322c45404943a0275ef19 Improves notes_description helper
routine
--
@hlfan commented on this pull request.
> @@ -3312,6 +3312,8 @@ en:
ninth: "9th"
tenth: "10th"
time: "Time"
+ download: "Download track as GeoJSON"
Done.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-websi
@hlfan pushed 1 commit.
5f68458185f140c6ba61c8fff8ed282c3fad121a Improve download link translation
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5694/files/3939f24460b6c32c25a5432764ff5f4ff5e8dea6..5f68458185f140c6ba61c8fff8ed282c3fad121a
You are receiving th
mmd-osm left a comment (openstreetmap/openstreetmap-website#5080)
Closing since there were too many breaking upstream changes in the meantime.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080#issuecomment-2672436660
You are re
Closed #5080.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080#event-16387647115
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Merged #5713 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5713#event-16386464535
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes pushed 1 commit.
11a59aadfb8cf32de0808f8f8d98212cf9b21582 Allow users to delete their own diary
entries
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4540/files/eaf084759bbc2f98f9b0953f8d37661e564c5f79..11a59aadfb8cf32de0808f8f8d98212cf9b21582
You
@tomhughes pushed 1 commit.
6bdb7703c2e358879c8ac2f529880bd38a21fcf6 Add a locale selector
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3618/files/f1ebafff173668aa578f8a604234aef29c377eec..6bdb7703c2e358879c8ac2f529880bd38a21fcf6
You are receiving this becau
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#3618)
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Gener
@tomhughes requested changes on this pull request.
> @@ -3312,6 +3312,8 @@ en:
ninth: "9th"
tenth: "10th"
time: "Time"
+ download: "Download track as GeoJSON"
Can we make this `Download route as` please.
--
Reply to this email directly or view it on GitHub:
h
Merged #5711 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5711#event-16386464594
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5524)
So are you saying this doesn't work as is then? If it's not capable of doing
those things? Sounds like we would need it to include the user so we could
force a reauthentication if necessary?
--
Reply to this email directly or
@tomhughes commented on this pull request.
> @@ -36,6 +36,9 @@ OSM.Directions = function (map) {
OSM.DirectionsEndpoint(map, $("input[name='route_to']"), OSM.MARKER_RED,
endpointDragCallback, endpointChangeCallback)
];
+ const exportGroup = L.layerGroup([...endpoints.map(m => m.marke
tomhughes left a comment (openstreetmap/openstreetmap-website#5713)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5713#issuecomment-2672138482
You are receiving this because you are subscribed to this t
@tomhughes commented on this pull request.
> @@ -43,7 +43,7 @@ def show
@note_includes_anonymous = @note.author.nil? || @note_comments.find {
|comment| comment.author.nil? }
-@note_comments = @note_comments.drop(1) if @note.author.nil? ||
@note.author.active?
+@note_comments =
tomhughes left a comment (openstreetmap/openstreetmap-website#5711)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5711#issuecomment-2672102323
You are receiving this because you are subscribed to this t
@hlfan commented on this pull request.
> + { :id => "car", :icon => "M2.52 3.515A2.5 2.5 0 0 1 4.82
> 2h6.362c1 0 1.904.596 2.298 1.515l.792
> 1.848c.075.175.21.319.38.404.5.25.855.715.965 1.262l.335
> 1.679q.05.242.049.49v.413c0 .814-.39 1.543-1 1.997V13.5a.5.5 0 0
> 1-.5.5h-2
@hlfan pushed 1 commit.
b7d293c28006a6823005075d3eb3016f7b4fb4b6 Split directions engine select into
modes and providers
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5652/files/5591008c24dbd81362c55713148a2355a0c6abd5..b7d293c28006a6823005075d3eb3016f7b4fb4
@hlfan pushed 1 commit.
5591008c24dbd81362c55713148a2355a0c6abd5 Split directions engine select into
modes and providers
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5652/files/eae7f3c1dcc2bffc5563d2ac64c8239b1795caba..5591008c24dbd81362c55713148a2355a0c6ab
@hlfan pushed 2 commits.
20f3bacd88d341a8bc4965210098614b696009a9 Split engine translations
eae7f3c1dcc2bffc5563d2ac64c8239b1795caba Split directions engine select into
modes and providers
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5652/files/bc3abc403aa
@nenad-vujicic commented on this pull request.
> + note_ids = notes.pluck(:id)
+
+ sql_query = <<-SQL.squish
+WITH first_comment AS(
+ SELECT DISTINCT ON (note_id) *
+ FROM note_comments
+ WHERE note_id BETWEEN #{note_ids.min} AND #{note_ids.max}
+
kcne left a comment (openstreetmap/openstreetmap-website#5402)
I've resolved the conflicts in `yarn.lock` again. Since changes keep getting
merged into master, I keep running into conflicts. Are there any remaining
issues to address, or is this good to merge now?
--
Reply to this email directl
@kcne pushed 2 commits.
8b2400a8aeb9c9d53ce932aa9fbe3e978417cf49 Add heatmap data caching and query
for user contributions
6882e4e5d76aac473e63fd918cd74f8aa1221de7 Add tests for heatmap data in
UsersController
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/
@hlfan commented on this pull request.
> +modeGroup.html("");
+for (const mode of new Set(modes)) {
+ modeGroup.append(``);
+ modeGroup.append(``);
+}
Disabling the buttons and the selects options seems better, disabling all in
the template and enabling each in js when su
@HolgerJeromin commented on this pull request.
> -});
- }
-
- function setEngine(index) {
-chosenEngine = engines[index];
-select.val(index);
+ function setEngine(id) {
+const engines = OSM.Directions.engines;
+const desired = engines.find(engine => engine.id() === id);
+
30 matches
Mail list logo
